From 7506755eb1d5a4f5a9b8848ea62470ae5296b13b Mon Sep 17 00:00:00 2001 From: Shihao Xia Date: Wed, 22 Dec 2021 13:56:46 -0500 Subject: [PATCH] internal/resolver: fix possible goroutine leak in TestSafeConfigSelector (#5058) --- internal/resolver/config_selector_test.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/internal/resolver/config_selector_test.go b/internal/resolver/config_selector_test.go index e1dae8bde..7a8a5dbd6 100644 --- a/internal/resolver/config_selector_test.go +++ b/internal/resolver/config_selector_test.go @@ -112,7 +112,7 @@ func (s) TestSafeConfigSelector(t *testing.T) { cs1Done := false // set when cs2 is first called for dl := time.Now().Add(150 * time.Millisecond); !time.Now().After(dl); { - gotConfigChan := make(chan *RPCConfig) + gotConfigChan := make(chan *RPCConfig, 1) go func() { cfg, _ := scs.SelectConfig(testRPCInfo) gotConfigChan <- cfg