diff --git a/gcp/observability/observability_test.go b/gcp/observability/observability_test.go index e58a46452..07e78be56 100644 --- a/gcp/observability/observability_test.go +++ b/gcp/observability/observability_test.go @@ -388,6 +388,12 @@ func (s) TestOpenCensusIntegration(t *testing.T) { if value := fe.SeenViews["grpc.io/server/completed_rpcs"]; value != TypeOpenCensusViewCount { errs = append(errs, fmt.Errorf("unexpected type for grpc.io/server/completed_rpcs: %s != %s", value, TypeOpenCensusViewCount)) } + if value := fe.SeenViews["grpc.io/client/roundtrip_latency"]; value != TypeOpenCensusViewDistribution { + errs = append(errs, fmt.Errorf("unexpected type for grpc.io/client/completed_rpcs: %s != %s", value, TypeOpenCensusViewDistribution)) + } + if value := fe.SeenViews["grpc.io/server/server_latency"]; value != TypeOpenCensusViewDistribution { + errs = append(errs, fmt.Errorf("grpc.io/server/server_latency: %s != %s", value, TypeOpenCensusViewDistribution)) + } if fe.SeenSpans <= 0 { errs = append(errs, fmt.Errorf("unexpected number of seen spans: %v <= 0", fe.SeenSpans)) } diff --git a/gcp/observability/opencensus.go b/gcp/observability/opencensus.go index 760faaf2a..782e8333c 100644 --- a/gcp/observability/opencensus.go +++ b/gcp/observability/opencensus.go @@ -25,7 +25,6 @@ import ( "contrib.go.opencensus.io/exporter/stackdriver" "contrib.go.opencensus.io/exporter/stackdriver/monitoredresource" - "go.opencensus.io/plugin/ocgrpc" "go.opencensus.io/stats/view" "go.opencensus.io/trace" "google.golang.org/grpc" @@ -105,10 +104,10 @@ func startOpenCensus(config *config) error { } if config.CloudMonitoring != nil { - if err := view.Register(ocgrpc.ServerStartedRPCsView, ocgrpc.ClientCompletedRPCsView); err != nil { + if err := view.Register(opencensus.ClientStartedRPCsView, opencensus.ClientCompletedRPCsView, opencensus.ClientRoundtripLatencyView); err != nil { return fmt.Errorf("failed to register default client views: %v", err) } - if err := view.Register(ocgrpc.ClientStartedRPCsView, ocgrpc.ServerCompletedRPCsView); err != nil { + if err := view.Register(opencensus.ServerStartedRPCsView, opencensus.ServerCompletedRPCsView, opencensus.ServerLatencyView); err != nil { return fmt.Errorf("failed to register default server views: %v", err) } view.SetReportingPeriod(defaultMetricsReportingInterval)