grpc
/
grpc-go
mirror of https://github.com/grpc/grpc-go.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

add newline at EOF and section on tests/checkers

This commit is contained in:
Doug Fawley 2025-08-19 15:21:31 -07:00
parent baa13eb8e3
commit 89d67aaf2a
1 changed files with 13 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
.github/pull_request_template.md vendored
View File

@ -51,4 +51,16 @@ swift review.
6. Self-review your code changes before sending your PR.
7. Delete all of the above before sending your PR.
7. All tests must be passing or you PR cannot be merged. There are two github
checkers that need not be green:
1. We test the freshness of the generated proto code we maintain via the
`vet-proto` check. If the source proto files are updated, but our repo is
not updated, an optional checker will fail. This will be fixed by our
team in a separate PR and will not prevent the merge of your PR.
2. We run a checker that will fail if there is any change in dependencies of
an exported package via the `dependencies` check. If new dependencies are
added that are not appropriate, we may not accept your PR.
8. Delete all of the above before sending your PR.