From 4af0b510f8d05ff11ca06acca7b3fcc88b9800a7 Mon Sep 17 00:00:00 2001 From: iamqizhao Date: Fri, 25 Sep 2015 14:30:24 -0700 Subject: [PATCH 01/13] enable test coverage --- .travis.yml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/.travis.yml b/.travis.yml index 250356014..a133d41d4 100644 --- a/.travis.yml +++ b/.travis.yml @@ -1,4 +1,9 @@ language: go +before_install: + - go get github.com/axw/gocov/gocov + - go get github.com/mattn/goveralls + - go get code.google.com/p/go.tools/cmd/cover script: - make test testrace + - goveralls From 6b2f0e9831434c7e83e459de61a29c7302e555dc Mon Sep 17 00:00:00 2001 From: iamqizhao Date: Fri, 25 Sep 2015 14:36:22 -0700 Subject: [PATCH 02/13] package fix --- .travis.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index a133d41d4..1e7ed34f5 100644 --- a/.travis.yml +++ b/.travis.yml @@ -3,7 +3,7 @@ language: go before_install: - go get github.com/axw/gocov/gocov - go get github.com/mattn/goveralls - - go get code.google.com/p/go.tools/cmd/cover + - go get golang.org/x/tools/cmd/cover script: - make test testrace - goveralls From f911b7542e0a3a14f3346de47be2ac7bcc8f8052 Mon Sep 17 00:00:00 2001 From: iamqizhao Date: Fri, 25 Sep 2015 15:03:12 -0700 Subject: [PATCH 03/13] specify package --- .travis.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index 1e7ed34f5..027840515 100644 --- a/.travis.yml +++ b/.travis.yml @@ -6,4 +6,4 @@ before_install: - go get golang.org/x/tools/cmd/cover script: - make test testrace - - goveralls + - goveralls -package="google.golang.org/grpc" From c298b09b1deec438e12e7a662ae838efdb405d57 Mon Sep 17 00:00:00 2001 From: iamqizhao Date: Mon, 28 Sep 2015 10:19:10 -0700 Subject: [PATCH 04/13] revise goveralls cmd --- .travis.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index 027840515..3fab3bd65 100644 --- a/.travis.yml +++ b/.travis.yml @@ -6,4 +6,4 @@ before_install: - go get golang.org/x/tools/cmd/cover script: - make test testrace - - goveralls -package="google.golang.org/grpc" + - goveralls google.golang.org/grpc/... From e80c8e92262cd9a580446a6bd6e7fce3849a0699 Mon Sep 17 00:00:00 2001 From: iamqizhao Date: Mon, 28 Sep 2015 17:40:23 -0700 Subject: [PATCH 05/13] fix --- .travis.yml | 2 +- Makefile | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index 3fab3bd65..124d3261d 100644 --- a/.travis.yml +++ b/.travis.yml @@ -6,4 +6,4 @@ before_install: - go get golang.org/x/tools/cmd/cover script: - make test testrace - - goveralls google.golang.org/grpc/... + - make coverage diff --git a/Makefile b/Makefile index 0dc225ff4..4d0ba6a82 100644 --- a/Makefile +++ b/Makefile @@ -45,3 +45,6 @@ testrace: testdeps clean: go clean google.golang.org/grpc/... + +coverage: testdeps: + goveralls google.golang.org/grpc/... From 6b055d5dafb8c0c00020927e2724b2e93d990073 Mon Sep 17 00:00:00 2001 From: iamqizhao Date: Mon, 28 Sep 2015 17:44:12 -0700 Subject: [PATCH 06/13] fix typo --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 4d0ba6a82..197ff4e7d 100644 --- a/Makefile +++ b/Makefile @@ -46,5 +46,5 @@ testrace: testdeps clean: go clean google.golang.org/grpc/... -coverage: testdeps: +coverage: testdeps goveralls google.golang.org/grpc/... From bda7f81e9a64ceca1517129b1968142663cd95cc Mon Sep 17 00:00:00 2001 From: iamqizhao Date: Mon, 28 Sep 2015 18:54:00 -0700 Subject: [PATCH 07/13] add -v --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 197ff4e7d..5bc38be20 100644 --- a/Makefile +++ b/Makefile @@ -47,4 +47,4 @@ clean: go clean google.golang.org/grpc/... coverage: testdeps - goveralls google.golang.org/grpc/... + goveralls -v google.golang.org/grpc/... From 8555e5d5a137d0a30deb5f07a84d30d9c432a39d Mon Sep 17 00:00:00 2001 From: iamqizhao Date: Fri, 2 Oct 2015 10:52:53 -0700 Subject: [PATCH 08/13] try to address the issues caused by 2 repo names --- .travis.yml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/.travis.yml b/.travis.yml index 250356014..d4ca5329b 100644 --- a/.travis.yml +++ b/.travis.yml @@ -1,4 +1,9 @@ language: go +install: + - export GOPATH="$HOME/gopath" + - mkdir -p "$GOPATH/src/google.golang.org" + - mv "$TRAVIS_BUILD_DIR" "$GOPATH/src/google.golang.org/grpc" + script: - make test testrace From 773bcaef214340957ef768b62b5492a0feefd643 Mon Sep 17 00:00:00 2001 From: iamqizhao Date: Fri, 2 Oct 2015 11:09:57 -0700 Subject: [PATCH 09/13] fix .travis.yml --- .travis.yml | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/.travis.yml b/.travis.yml index 124d3261d..b0ce1f7d4 100644 --- a/.travis.yml +++ b/.travis.yml @@ -4,6 +4,12 @@ before_install: - go get github.com/axw/gocov/gocov - go get github.com/mattn/goveralls - go get golang.org/x/tools/cmd/cover + +install: + - export GOPATH="$HOME/gopath" + - mkdir -p "$GOPATH/src/google.golang.org" + - mv "$TRAVIS_BUILD_DIR" "$GOPATH/src/google.golang.org/grpc" + script: - make test testrace - make coverage From 2caa045e7f8103b201ec2281c46156d754de50ee Mon Sep 17 00:00:00 2001 From: iamqizhao Date: Fri, 2 Oct 2015 11:32:22 -0700 Subject: [PATCH 10/13] improve README --- README.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/README.md b/README.md index 94dc739e2..56902431a 100644 --- a/README.md +++ b/README.md @@ -1,6 +1,6 @@ #gRPC-Go -[![Build Status](https://travis-ci.org/grpc/grpc-go.svg)](https://travis-ci.org/grpc/grpc-go) [![GoDoc](https://godoc.org/google.golang.org/grpc?status.svg)](https://godoc.org/google.golang.org/grpc) [![Coverage Status](https://coveralls.io/repos/grpc/grpc-go/badge.svg?branch=master&service=github)](https://coveralls.io/github/grpc/grpc-go?branch=master) +[![Build Status](https://travis-ci.org/grpc/grpc-go.svg)](https://travis-ci.org/grpc/grpc-go) [![GoDoc](https://godoc.org/google.golang.org/grpc?status.svg)](https://godoc.org/google.golang.org/grpc) The Go implementation of [gRPC](http://www.grpc.io/): A high performance, open source, general RPC framework that puts mobile and HTTP/2 first. For more information see the [gRPC Quick Start](http://www.grpc.io/docs/) guide. @@ -20,11 +20,11 @@ This requires Go 1.4 or above. Constraints ----------- -The grpc package should only depend on standard Go packages and a short list of exceptions. A new addition to the list requires a discussion with gRPC-Go authors and consultants. +The grpc package should only depend on standard Go packages and a short list of exceptions. If your contribution introduce a new dependency which is NOT in the [list](http://godoc.org/google.golang.org/grpc?imports), you need a discussion with gRPC-Go authors and consultants. Documentation ------------- -You can find more detailed documentation and examples in the [examples directory](examples/). +You can find more detailed [API documentation](https://godoc.org/google.golang.org/grpc) and examples in the [examples directory](examples/). Status ------ From f096c73880ef104d34dc354a8ef6b36e129e31b2 Mon Sep 17 00:00:00 2001 From: iamqizhao Date: Fri, 2 Oct 2015 11:33:13 -0700 Subject: [PATCH 11/13] improve README --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 56902431a..8d89c6d82 100644 --- a/README.md +++ b/README.md @@ -20,7 +20,7 @@ This requires Go 1.4 or above. Constraints ----------- -The grpc package should only depend on standard Go packages and a short list of exceptions. If your contribution introduce a new dependency which is NOT in the [list](http://godoc.org/google.golang.org/grpc?imports), you need a discussion with gRPC-Go authors and consultants. +The grpc package should only depend on standard Go packages and a small number of exceptions. If your contribution introduce a new dependency which is NOT in the [list](http://godoc.org/google.golang.org/grpc?imports), you need a discussion with gRPC-Go authors and consultants. Documentation ------------- From d5ec12ed2153e79ffaaa98141f04154b5f3fb63a Mon Sep 17 00:00:00 2001 From: iamqizhao Date: Fri, 2 Oct 2015 11:35:11 -0700 Subject: [PATCH 12/13] improve README --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 8d89c6d82..8e0dfda69 100644 --- a/README.md +++ b/README.md @@ -20,7 +20,7 @@ This requires Go 1.4 or above. Constraints ----------- -The grpc package should only depend on standard Go packages and a small number of exceptions. If your contribution introduce a new dependency which is NOT in the [list](http://godoc.org/google.golang.org/grpc?imports), you need a discussion with gRPC-Go authors and consultants. +The grpc package should only depend on standard Go packages and a small number of exceptions. If your contribution introduces new dependencies which are NOT in the [list](http://godoc.org/google.golang.org/grpc?imports), you need a discussion with gRPC-Go authors and consultants. Documentation ------------- From 5f38293af946d4f576000523554590e88d365af5 Mon Sep 17 00:00:00 2001 From: iamqizhao Date: Fri, 2 Oct 2015 11:36:57 -0700 Subject: [PATCH 13/13] improve README --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 8e0dfda69..37b05f095 100644 --- a/README.md +++ b/README.md @@ -24,7 +24,7 @@ The grpc package should only depend on standard Go packages and a small number o Documentation ------------- -You can find more detailed [API documentation](https://godoc.org/google.golang.org/grpc) and examples in the [examples directory](examples/). +See [API documentation](https://godoc.org/google.golang.org/grpc) for package and API descriptions and find examples in the [examples directory](examples/). Status ------