grpc
/
grpc-go
mirror of https://github.com/grpc/grpc-go.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

cleanup: status formatting bug and comment grammar fix (#8260)

This commit is contained in:
Purnesh Dixit 2025-04-17 20:01:42 +05:30 committed by GitHub
parent 7d68bf62e2
commit aec13815d3
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
xds/internal/resolver/serviceconfig.go
View File

@ -142,7 +142,7 @@ type erroringConfigSelector struct {
} }
func newErroringConfigSelector(err error, xdsNodeID string) *erroringConfigSelector { func newErroringConfigSelector(err error, xdsNodeID string) *erroringConfigSelector {
return &erroringConfigSelector{err: annotateErrorWithNodeID(status.Errorf(codes.Unavailable, err.Error()), xdsNodeID)} return &erroringConfigSelector{err: annotateErrorWithNodeID(status.Error(codes.Unavailable, err.Error()), xdsNodeID)}
} }
func (cs *erroringConfigSelector) SelectConfig(iresolver.RPCInfo) (*iresolver.RPCConfig, error) { func (cs *erroringConfigSelector) SelectConfig(iresolver.RPCInfo) (*iresolver.RPCConfig, error) {

5
xds/server_test.go
View File

@ -701,9 +701,8 @@ func (s) TestServeAndCloseDoNotRace(t *testing.T) {
// resource error notifications for the invalid listener resource leading // resource error notifications for the invalid listener resource leading
// to service mode change to "not serving" each time. // to service mode change to "not serving" each time.
// //
// Even if the the server is currently NOT_SERVING, in the case (where we // Even if the server is currently NOT_SERVING and the new mode is also
// are NOT_SERVING and the new mode is also NOT_SERVING), the update is not // NOT_SERVING, the update is not suppressed as:
// suppressed as:
// 1. the error may have change // 1. the error may have change
// 2. it provides a timestamp of the last backoff attempt // 2. it provides a timestamp of the last backoff attempt
noopModeChangeCallback := func(_ net.Addr, _ ServingModeChangeArgs) {} noopModeChangeCallback := func(_ net.Addr, _ ServingModeChangeArgs) {}