Commit Graph

170 Commits

Author SHA1 Message Date
lyuxuan 4166ea7dad
Stage 2: Channelz metric collection (#1909) 2018-04-23 11:22:25 -07:00
Karsten Weiss 7de9139327 Fix typos (#1994) 2018-04-16 10:03:02 -07:00
Karsten Weiss 4d9544a0fd Simplify make() (gosimple)
This fixes:
benchmark/worker/benchmark_client.go:151:36: should use make([]*grpc.ClientConn, connCount) instead (S1019)
benchmark/worker/benchmark_client.go:231:47: should use make([]lockingHistogram, rpcCountPerConn * len(conns)) instead (S1019)
benchmark/worker/benchmark_client.go:343:39: should use make([]*stats.Histogram, len(bc.lockingHistograms)) instead (S1019)
benchmark/worker/benchmark_client.go:369:22: should use make([]uint32, len(mergedHistogram.Buckets)) instead (S1019)
encoding/encoding.go:85:47: should use make(map[string]Codec) instead (S1019)
proxy_test.go:116:26: should use make([]byte, len(msg)) instead (S1019)
2018-04-15 15:32:33 +02:00
Karsten Weiss 749a0db289 Use time.Since() helper function (gosimple)
(I've dropped similar gosimple cleanups using time.Until() as this API is not
available in go1.6 and go1.7)
2018-04-15 15:32:33 +02:00
Karsten Weiss 95bbf69653 Remove redundant return statements (gosimple)
This fixes:
balancer/base/balancer.go:149:2: redundant return statement (S1023)
balancer_v1_wrapper.go:260:2: redundant return statement (S1023)
balancer_v1_wrapper.go:273:2: redundant return statement (S1023)
balancer_v1_wrapper.go:285:2: redundant return statement (S1023)
benchmark/benchmark.go:68:2: redundant return statement (S1023)
clientconn.go:1461:2: redundant return statement (S1023)
grpclb.go:223:2: redundant return statement (S1023)
grpclb.go:260:2: redundant return statement (S1023)
grpclb_util.go:201:2: redundant return statement (S1023)
rpc_util.go:278:50: redundant return statement (S1023)
rpc_util.go:296:56: redundant return statement (S1023)
rpc_util.go:314:56: redundant return statement (S1023)
rpc_util.go:333:53: redundant return statement (S1023)
rpc_util.go:354:52: redundant return statement (S1023)
rpc_util.go:387:56: redundant return statement (S1023)
rpc_util.go:416:53: redundant return statement (S1023)
stream.go:651:2: redundant return statement (S1023)
2018-04-15 12:43:34 +02:00
Jean de Klerk 2759199bf7 Small spelling fixes (unknow -> unknown) (#1868) 2018-02-22 13:10:19 -08:00
dfawley 46fd263cc8
benchmarks: add flag to benchmain to use bufconn instead of network (#1837)
This will allow us to focus on grpc internals in profiling by excluding the cost of syscalls, which is a significant part of our time spent.
2018-02-15 14:52:38 -08:00
dfawley 5ba054bf37
encoding: Introduce new method for registering and choosing codecs (#1813) 2018-01-23 11:39:40 -08:00
lyuxuan 4f7a2c71d3
compare atomic and mutex performance in case of contention. (#1788) 2018-01-22 18:48:20 -08:00
lyuxuan 17c6e90cd5
compare atomic and mutex performance for incrementing/storing one variable (#1757) 2018-01-02 10:46:13 -08:00
Menghan Li b7dc71e7ea
Optimize codes.String() method using a switch instead of a slice of indexes (#1712) 2017-12-06 10:50:43 -08:00
dfawley abd3e10d78
Add context benchmarks (#1610) 2017-11-07 10:20:24 -08:00
Gyu-Ho Lee 865013bc17 *: replace deprecated grpc.Errorf calls with status.Errorf (#1651) 2017-11-06 10:24:20 -08:00
mmukhi ac0ac2b80e
Speed-up quota pools. (#1636)
* First commit.

* First commit.

* Second commit.

* Post-review update.
2017-11-02 13:39:27 -07:00
dfawley fc6acc5e5e
latency: Listen on localhost:0 instead of :0 in test (#1640) 2017-11-01 10:52:07 -07:00
dfawley 5c3d956e18 Re-add support for Go1.6 (#1603) 2017-10-20 12:05:20 -07:00
田欧 faebfcb7bf Remove single-entry var blocks (#1589) 2017-10-18 09:59:23 -07:00
dfawley c8405557a4 Remove Go1.6 support (#1492) 2017-10-04 13:57:10 -07:00
dfawley 8230f98ef7 benchmark: add type assertion benchmarks (#1556) 2017-10-03 13:03:49 -07:00
mmukhi 8214c28a62 Make IO Buffer size configurable. (#1544)
* Make IO Buffer size configurable.

* Fixing typo
2017-09-28 14:11:14 -07:00
Menghan Li a68137c927 Revert "Added localhost to net.Listen() calls to avoid macOS firewall dialog." (#1541)
This reverts commit c67cd636f9.
2017-09-27 00:01:17 -07:00
Hein Meling c67cd636f9 Added localhost to net.Listen() calls to avoid macOS firewall dialog. (#1539) 2017-09-26 10:19:45 -07:00
dfawley d4b75ebd4f benchmark: add primivites benchmark for Unlocking via defer vs. inline (#1534) 2017-09-21 12:46:03 -07:00
Zhouyihai Ding 1253dac14b benchmain: format output of benchmark to a table (#1493) 2017-09-20 15:06:19 -07:00
Menghan Li dce316936b Move primitives benchmarks to package primitives_test (#1522) 2017-09-19 16:43:00 -07:00
dfawley c443156028 benchmark: add primitives benchmarks for informational purposes (#1501) 2017-09-11 10:49:50 -07:00
dfawley d6870035ab Check "x/net/context" with `go vet` like "context" (#1490)
* Check "x/net/context" with `go vet` like "context"

Includes a signficant revamp of .travis.yml to execute a separate script for
all of the things we check before allowing a merge.

* fix bug in benchmain
2017-08-29 15:40:57 -07:00
dfawley 85a1e381f1 benchmain: add nop compressor and other usability tweaks (#1489) 2017-08-29 11:41:55 -07:00
dfawley 7fd9c2c66f benchmain: minor bug fixes (#1488) 2017-08-29 10:55:39 -07:00
ZhouyihaiDing 051e7013db add comment (#1464) 2017-08-25 13:09:52 -07:00
ZhouyihaiDing 7db1564ba1 benchmark: add benchmain/main.go to run benchmark with flag set (#1352) 2017-08-24 10:08:43 -07:00
dfawley 25b4a426b4 go-generate pb.go files and check in Travis to make sure they don't change (#1426) 2017-08-17 16:00:51 -07:00
Mehrdad Afshari 53ae6b7e90 Fix typo 2017-08-03 16:08:13 -07:00
ZhouyihaiDing 66c9ed803b Add flags for tls file path (#1419) 2017-08-03 15:23:02 -07:00
dfawley 4c7bb72916 benchmark: don't stop timer until after workers are done (#1407) 2017-07-31 11:36:28 -07:00
田欧 ca9e0c3458 Add testdata package and unify testdata to only one dir (#1297) 2017-07-25 10:24:45 -07:00
ZhouyihaiDing 6495e8dfeb benchmark: remove multi-layer for loop (#1339) 2017-07-21 13:39:06 -07:00
dfawley 9cb02b885b latency: sleep in Write when BDP is exceeded to avoid buffer bloat (#1330) 2017-06-26 16:20:44 -07:00
ZhouyihaiDing f0c566b827 benchmark: add latency/MTU/bandwidth into testcases (#1304) 2017-06-23 14:22:51 -07:00
田欧 a94a7ac054 add license for some files (#1296) 2017-06-12 18:10:06 -07:00
ZhouyihaiDing ba30de56b8 use subtests for the benchmark_test and add it into the Makefile (#1278)
* use subtests for the benchmark_test and add it into the Makefile

* benchmark: keep the original benchmark_test as version 16. use subtests benchmark as 17
2017-06-12 14:52:33 -07:00
dfawley cfd21dac77 Create latency package for realistically simulating network latency (#1286) 2017-06-09 09:24:50 -07:00
Jan Tattermusch ddbf6c46a6 autofix license notice 2017-06-08 14:42:19 +02:00
ZhouyihaiDing 6bb76488de add MaxConcurrentStreams to benchmark_test when start the server (#1271) 2017-05-31 14:15:37 -07:00
Tamir Duberstein 3773797869 Travis: add staticcheck (#1019)
Also only run golint and go vet in Go 1.8, and fix some vet failures.
2017-05-15 17:05:27 -07:00
apolcyn ee8ed34bcf get more metrics from go benchmark servers (#913)
* add user and system cpu usage to go benchmarks

* fix import and style issues

* sample elapsed time diffs after merging histograms

* style fixes and variables renames

* add pprof server to benchmark workers to grab different profile stats

* rename variables for consistency and default to no pprof
2017-04-03 15:53:03 -07:00
Alexander Polcyn bcc367f343 get rid of extra payload local variable 2017-02-09 16:16:18 -08:00
Alexander Polcyn a0bd789da9 fix wording 2017-02-09 16:12:53 -08:00
Alexander Polcyn 47b25d4b97 remove proto object allocs on streaming benchmark server 2016-12-21 11:28:07 -08:00
Mahak Mukhi 883bfc7bc8 pb.go file update 2016-10-28 12:37:56 -07:00