8ce7e6babb
stream: never return errors from CloseSend ( #2312 )
2018-09-19 08:44:26 -07:00
e193757038
internal/transport: remove some unused fields from structs ( #2213 )
...
- Flush and Authority are never read by the transport.
- Authority is used indirectly; move it to dialOptions.
- Delay is only set to false.
2018-07-13 09:56:47 -07:00
11b582728a
transport: move to internal to make room for new, public transport API ( #2212 )
...
This is a breaking change, but the transport package was never intended for use outside of grpc. Any current users that we are aware of are incorrect or have a preferred alternative.
2018-07-11 11:22:45 -07:00
f57a529f33
balancer: add rpc method to PickOptions ( #2204 )
...
Provide additional context to Pickers that wish to make decisions based on the RPC method.
Relevant issue: https://github.com/grpc/grpc-go/issues/2103
2018-07-11 10:18:09 -07:00
50de898e66
deprecate stream, move documentation to client|server stream ( #2198 )
...
docs: deprecate stream, move documentation to client|server stream
Deprecate Stream, and move the methods and documention to ServerStream
and ClientStream. This is due to the fact that there are different
semantics for SendMsg, and it's quite confusing to document one method
for two things. Furthermore, Stream is not actually used in any way
other than to be inherited by ClientStream and ServerStream.
Relevant issue: #2159
2018-07-09 16:46:25 -07:00
40cd6b15e2
stream: in withRetry, block until Status is valid and check on io.EOF ( #2199 )
...
Also, return an error if SendMsg is called after CloseSend.
2018-07-03 14:07:07 -07:00
d35d006431
Fix flaky test: TestClientStreamingError ( #2192 )
2018-07-02 10:08:26 -07:00
40a879c23a
client: Implement gRFC A6: configurable client-side retry support ( #2111 )
2018-06-27 16:18:41 -07:00
f9bde863c2
documentation: clarify SendMsg documentation ( #2171 )
...
documentation: clarify SendMsg documentation
Relevant issue: #2159
2018-06-27 16:16:07 -07:00
b28608a9db
channelz: move APIs to internal except channelz service ( #2157 )
2018-06-18 17:59:08 -07:00
bfe419798a
clarify CloseSend vs CloseAndRecv; better formatting ( #2071 )
...
clarify CloseSend vs CloseAndRecv; better formatting
2018-05-29 11:35:11 -07:00
091a800143
split encode into three functions ( #2058 )
2018-05-11 13:47:10 -07:00
b75baa103c
small documentation addition to NewStream ( #2060 )
2018-05-11 08:43:47 -07:00
0bc7c3280e
Revert "Less mem ( #1987 )" ( #2049 )
...
This reverts commit 7a8c989507
2018-05-03 11:37:59 -07:00
3592bccfd9
interop: Fix unimplemented method test ( #2040 )
...
* Don't send nil requests.
* Fix import name and get rid of condition.
* Let registered encoder deal with nil requests.
* Break encode into encode and compress.
2018-05-02 16:08:12 -07:00
7a8c989507
Less mem ( #1987 )
...
* Export changes to OSS.
* First commit.
* Cherry-pick.
* Documentation.
* Post review updates.
2018-04-30 09:54:33 -07:00
4166ea7dad
Stage 2: Channelz metric collection ( #1909 )
2018-04-23 11:22:25 -07:00
95bbf69653
Remove redundant return statements (gosimple)
...
This fixes:
balancer/base/balancer.go:149:2: redundant return statement (S1023)
balancer_v1_wrapper.go:260:2: redundant return statement (S1023)
balancer_v1_wrapper.go:273:2: redundant return statement (S1023)
balancer_v1_wrapper.go:285:2: redundant return statement (S1023)
benchmark/benchmark.go:68:2: redundant return statement (S1023)
clientconn.go:1461:2: redundant return statement (S1023)
grpclb.go:223:2: redundant return statement (S1023)
grpclb.go:260:2: redundant return statement (S1023)
grpclb_util.go:201:2: redundant return statement (S1023)
rpc_util.go:278:50: redundant return statement (S1023)
rpc_util.go:296:56: redundant return statement (S1023)
rpc_util.go:314:56: redundant return statement (S1023)
rpc_util.go:333:53: redundant return statement (S1023)
rpc_util.go:354:52: redundant return statement (S1023)
rpc_util.go:387:56: redundant return statement (S1023)
rpc_util.go:416:53: redundant return statement (S1023)
stream.go:651:2: redundant return statement (S1023)
2018-04-15 12:43:34 +02:00
2eae9d0c74
server: add grpc.Method function for extracting method from context ( #1961 )
2018-04-02 13:08:04 -07:00
1a70180f35
client: Fix race when using both client-side default CallOptions and per-call CallOptions ( #1948 )
2018-03-29 10:34:29 -07:00
57640c0e6f
Allow storing alternate transport.ServerStream implementations in context ( #1904 )
2018-03-20 17:02:32 -07:00
fa28bef939
client: export types implementing CallOptions for access by interceptors ( #1902 )
2018-03-16 15:57:34 -07:00
13975c0702
stream: split per-attempt data from clientStream ( #1900 )
...
This is pre-work to implementing retry support. Each retry attempt will have its own csAttempt. The fields left in clientStream are the same across all attempts.
2018-03-12 13:27:54 -07:00
2c2d834e8e
stats: add BeginTime to stats.End ( #1907 )
2018-03-12 09:16:36 -07:00
9aba04495f
server: Convert all non-status errors to codes.Unknown ( #1881 )
...
- convertCode utilized errors that were not allowed by the library per 9d0bc30edb/doc/statuscodes.md#1672
2018-03-08 13:46:26 -08:00
365770fcbd
streams: Stop cleaning up after orphaned streams ( #1854 )
...
This change introduces some behavior changes that should not impact users that
are following the proper stream protocol. Specifically, one of the following
conditions must be satisfied:
1. The user calls Close on the ClientConn.
2. The user cancels the context provided to NewClientStream, or its deadline
expires. (Note that it if the context is no longer needed before the deadline
expires, it is still recommended to call cancel to prevent bloat.) It is always
recommended to cancel contexts when they are no longer needed, and to
never use the background context directly, so all users should always be
doing this.
3. The user calls RecvMsg (or Recv in generated code) until a non-nil error is
returned.
4. The user receives any error from Header or SendMsg (or Send in generated
code) besides io.EOF. If none of the above happen, this will leak a goroutine
and a context, and grpc will not call the optionally-configured stats handler
with a stats.End message.
Before this change, if a user created a stream and the server ended the stream,
the stats handler would be invoked with a stats.End containing the final status
of the stream. Subsequent calls to RecvMsg would then trigger the stats handler
with InPayloads, which may be unexpected by stats handlers.
2018-02-08 10:51:16 -08:00
d09ec43545
Implement unary functionality using streams ( #1835 )
2018-02-05 12:54:13 -08:00
424e3e9894
Stream: do not cancel ctx created with service config timeout ( #1838 )
2018-02-02 10:35:15 -08:00
5ba054bf37
encoding: Introduce new method for registering and choosing codecs ( #1813 )
2018-01-23 11:39:40 -08:00
6913ad5cae
Document that all errors from RPCs are status errors ( #1782 )
2018-01-05 15:37:05 -08:00
c998149a22
Avoid copying headers/trailers in unary RPCs unless requested by CallOptions ( #1775 )
...
CPU profile shows that header copy takes a large proportion of CPU usage in a gRPC Call.
If the header is not needed, we don't need to pay the cost.
2018-01-03 09:13:06 -08:00
4e393e0b21
grpc: fix deprecation comments to conform to standard ( #1691 )
2017-12-18 09:23:42 -08:00
2ef021f78d
New grpclb implementation ( #1558 )
...
The new grpclb supports fallback to backends if remote balancer is unavailable
2017-11-27 11:16:26 -08:00
6253aa9397
set context timeout when Timeout value >= 0 ( #1678 )
...
To be consistent with call.go/invoke
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
2017-11-20 13:49:49 -08:00
816fa5b06f
Add proper support for 'identity' encoding type ( #1664 )
2017-11-17 09:24:54 -08:00
8ff8683602
Implement transparent retries for gRFC A6 ( #1597 )
2017-11-06 13:45:11 -08:00
5db344a40a
Introduce new Compressor/Decompressor API ( #1428 )
2017-10-31 10:21:13 -07:00
a4ff4e29c4
Get method string from stream ( #1588 )
2017-10-26 16:03:44 -07:00
a5986a5c88
Add functions to ClientConn so it satisfies an interface for generated code ( #1599 )
2017-10-20 14:21:31 -07:00
4bbdf230d7
New implementation of roundrobin and pickfirst ( #1506 )
2017-10-02 09:22:57 -07:00
894322f00c
Dedicated goroutine for writing. ( #1498 )
2017-09-14 13:44:14 -07:00
8233e124e4
Add new Resolver and Balancer APIs (gRFC L9) ( #1408 )
...
- Add package balancer and resolver.
- Change ClientConn internals to new APIs and adds a wrapper for v1 balancer.
2017-08-31 10:59:09 -07:00
e60698345e
Fix context warnings from govet. ( #1486 )
...
Pre-req work for #1484
2017-08-29 11:04:15 -07:00
01089b2972
Remove buf copy when the compressor exist ( #1427 )
2017-08-25 12:26:38 -07:00
9d99afc2fd
Automatic WriteStatus for RecvMsg/SendMsg error on server side ( #1409 )
...
automatically WriteStatus if there's any error when RecvMsg/SendMsg on server side.
2017-08-14 12:24:23 -07:00
86ec6baad9
Populate callInfo.peer object for streaming RPCs ( #1356 )
2017-07-11 13:56:13 -07:00
41d9b6ea2a
Do not flush NewStream header on client side for unary RPCs and streaming RPCs with requests. ( #1343 )
...
If it's not client streaming, we should already have the request to be sent,
so we don't flush the header.
If it's client streaming, the user may never send a request or send it any
time soon, so we ask the transport to flush the header.
And flush header even without metadata
2017-07-05 16:51:14 -07:00
2f3320d9d6
Updated documentation of ClientStream. ( #1320 )
2017-06-23 13:57:58 -07:00
c6b9664180
Add goroutine safety doc on stream ( #1313 )
2017-06-15 15:24:17 -07:00
ddbf6c46a6
autofix license notice
2017-06-08 14:42:19 +02:00
6fecf2831a
Reopening: Server shouldn't Fatalf in case it fails to encode. ( #1276 )
...
* Server shouldn't Fatalf in case it fails to encode.
2017-06-02 12:32:37 -07:00
843116533a
Revert "Server shouldn't Fatalf in case it fails to encode. ( #1251 )" ( #1274 )
...
This reverts commit d5bc85c1e9
2017-06-01 12:34:28 -07:00
d5bc85c1e9
Server shouldn't Fatalf in case it fails to encode. ( #1251 )
...
* Server shouldn't Fatalf in case it fails to encode.
* golint
* post-review update
2017-06-01 11:57:45 -07:00
4a7b4d033a
minor fix
2017-05-19 16:38:37 -07:00
27ae1472a3
remove some todo comments
2017-05-19 14:55:35 -07:00
d19bbe846e
change max message size functions name
2017-05-19 11:08:40 -07:00
35d77ea991
merge master, resolve conflicts
2017-05-15 13:54:22 -07:00
bdf9a640e4
add timeout test, add check or pointer filed in callOption, fix minor issues
2017-05-15 13:51:11 -07:00
88a73d35c9
Adding dial options for PerRPCCredentials ( #1225 )
...
* Adding dial options for PerRPCCredentials
* Added tests for PerRPCCredentials
* Post-review updates
* post-review updates
2017-05-11 11:07:38 -07:00
17760cfd5b
Calling handleRPC with context derived from the original ( #1227 )
...
* Calling handleRPC with different context derived from the original context
* change comment for tagRPC and stats fields
2017-05-10 17:54:49 -07:00
3ea287058c
Merge branch 'master' into service_config_pr
2017-05-07 16:49:32 -07:00
0914b46180
don't add defer func if stats handler is nil ( #1214 )
2017-05-02 10:16:45 -07:00
277e90a432
Client load report for grpclb. ( #1200 )
2017-04-27 10:43:38 -07:00
ecbc34aaca
move server defaults, delete defer cancel() in stream.go
2017-04-26 17:39:57 -07:00
9c5f260e67
make max size a pointer type and initialize function a CallOption
2017-04-26 15:50:58 -07:00
983d8372ea
update the merge of client api and sc
2017-04-21 16:18:59 -07:00
bab6b617b7
merge master
2017-04-21 16:07:34 -07:00
2d949be2fe
Make sure all in-flight streams close when ClientConn.Close() is called. ( #1136 )
...
* Make sure all in-flight streams close when ClientConn.Close() is called.
* added test
2017-04-21 15:03:04 -07:00
cb02ab4d25
change error message from InvalidArgument to ResourceExhausted
2017-04-13 16:51:56 -07:00
8788b75675
merge master resolve conflicts
2017-04-13 16:28:15 -07:00
cd8432ec07
Move handling stats.End to clientStream.finish() ( #1182 )
...
* move handling stats.End to clientStream.finish()
* add stats test for streaming RPC not calling last recv()
2017-04-12 11:55:54 -07:00
fa2968617c
Merge branch 'master' into service_config_pr
2017-04-06 14:12:34 -07:00
6f8b55318a
fix the testMaxMsgSizeServerAPI failure
2017-04-06 14:08:04 -07:00
1d27587e10
Change status package to deal with concrete types instead of interfaces ( #1171 )
2017-04-06 11:41:07 -07:00
f1bb70facf
gofmt
2017-04-05 15:08:25 -07:00
f02290b023
Merge branch 'master' into service_config_pr
2017-04-05 11:15:55 -07:00
b507112439
Add status package for reporting gRPC status and errors ( #1156 )
...
When an error implemented by the status package is returned from a service
handler, the server will transmit a rich status message in the
"grpc-status-details-bin" trailing metadata field if any detailed data is
attached to the error. Client-side, we will decode them if present in the
server's response and return them to the user code performing the RPC.
This is backward compatible with the existing errors supported by the grpc
package. However, the grpc.Errorf, grpc.Code and grpc.ErrorDesc functions for
managing errors are now deprecated; status.Errorf and status.Status type
asserions should be used instead.
2017-04-05 10:35:40 -07:00
50d4175072
Add client and service side apis for limiting the send/recv msg size. Update MethodConfig struct
2017-04-03 15:03:24 -07:00
a94b0948a3
Client should have a check on maximum size of received message size.
2017-03-09 16:58:23 -08:00
cb653e4b61
Change stats APIs ( #1030 )
...
Change stats API from one static handler to one handler per server or client.
2017-01-09 17:11:32 -08:00
09aecb094e
Add the initial service config support ( #1009 )
...
* Add the initial service config support
* start scWatcher later
* remove timeoutCh
* address the comments
* deal with dial timeout
* defer cancel for the newly created context for correct lifetime management
* fix the defer order
* added other 2 missing cancels
2016-12-19 16:31:00 -08:00
deb01f422a
add stats tagger APIs and connection stats. ( #992 )
...
* add stats.tagger APIs and connection stats.
* fix comments
use ac.ctx in http2client
change name and comments
small fixes stats_tests
* add a TODO to ConnTagInfo
* rename handle to handleRPC
* modify stats comments
2016-11-30 16:25:46 -08:00
ff0b1db33e
fix comments
2016-11-08 10:31:02 -08:00
3de821b781
remote end stats in header() and SendMsg()
2016-11-07 18:30:22 -08:00
badd5540a4
fix comments
2016-11-07 17:55:44 -08:00
5938492b60
fix comments
2016-11-07 15:16:52 -08:00
a4edc462a2
renaming
2016-11-07 15:16:52 -08:00
aa5b5c7e2a
client side, use user context, and change sent time
2016-11-07 15:16:52 -08:00
1d2a929ae5
add stats.Begin and stats.End
2016-11-07 15:16:52 -08:00
c0087b3c91
add failfast option to stats
2016-11-07 15:16:52 -08:00
c698588285
Renaming types and variables
2016-11-07 15:16:52 -08:00
e42a66c81b
add client stats
2016-11-07 15:16:52 -08:00
7984a9c679
change CallBack to handler, and move ctx out of Stats.
2016-11-07 15:16:52 -08:00
17ee5a3637
Add package stats, and export stats on server side.
2016-11-07 15:16:52 -08:00
e790079956
Add grpc.SetHeader and ServerStream.SetHeader
2016-10-11 13:58:16 -07:00
1247834778
Allow multiple calls to setTrailer
2016-09-29 14:38:20 -07:00
52f6504dc2
Merge pull request #867 from iamqizhao/master
...
Support client side interceptor
2016-09-02 15:12:15 -07:00
5e734ab23e
Avoid creating transport stream error outside of transport
2016-09-02 11:57:42 -07:00
1e47e17230
Support client side interceptor
2016-08-26 13:50:38 -07:00
c72b08a774
Change errors returned by ac.wait()
2016-08-16 16:56:16 -07:00
dfawley
Mike Cheng
Jean de Klerk
lyuxuan
mmukhi
Karsten Weiss
Joshua Humphries
Brian Tiger Chow
Menghan Li
Ewan Chou
Daniel Nephin
Gyu-Ho Lee
Zhouyihai Ding
Cesar Ghali
Jan Tattermusch
kirk
Qi Zhao