grpc
/
grpc-java
mirror of https://github.com/grpc/grpc-java.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

core: Restore optimization for InProcess RPC order 

fea577c80 disabled an optimization that some tests notice, as it can
change execution order. This restores the old behavior, at slight
expense to seeing relationship between in-use tracking and idle mode.
This commit is contained in:
Eric Anderson 2024-05-24 10:07:32 -07:00
parent 960012d76e
commit 018917ae59
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
core/src/main/java/io/grpc/internal/ManagedChannelImpl.java
View File

@ -889,6 +889,12 @@ final class ManagedChannelImpl extends ManagedChannel implements
if (configSelector.get() != INITIAL_PENDING_SELECTOR) {
return newClientCall(method, callOptions);
}
syncContext.execute(new Runnable() {
@Override
public void run() {
exitIdleMode();
}
});
if (configSelector.get() != INITIAL_PENDING_SELECTOR) {
// This is an optimization for the case (typically with InProcessTransport) when name
// resolution result is immediately available at this point. Otherwise, some users'
@ -921,10 +927,6 @@ final class ManagedChannelImpl extends ManagedChannel implements
if (pendingCalls == null) {
pendingCalls = new LinkedHashSet<>();
inUseStateAggregator.updateObjectInUse(pendingCallsInUseObject, true);
// It's possible to be in idle mode while inUseStateAggregator is in-use, if one of
// the subchannels is in use. But we should never be in idle mode when pendingCalls is
// in use.
exitIdleMode();
}
pendingCalls.add(pendingCall);
} else {