grpc
/
grpc-java
mirror of https://github.com/grpc/grpc-java.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

stub: Deprecate StreamObservers (#10654) 

This class is of questionable utility and generally not used.
This commit is contained in:
Terry Wilson 2023-11-08 15:00:32 -08:00 committed by GitHub
parent 3ca3b9975e
commit 0346b40e4e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
benchmarks/src/main/java/io/grpc/benchmarks/qps/AsyncServer.java
View File

@ -26,7 +26,6 @@ import io.grpc.benchmarks.proto.Messages;
import io.grpc.netty.NettyServerBuilder; import io.grpc.netty.NettyServerBuilder;
import io.grpc.stub.ServerCallStreamObserver; import io.grpc.stub.ServerCallStreamObserver;
import io.grpc.stub.StreamObserver; import io.grpc.stub.StreamObserver;
import io.grpc.stub.StreamObservers;
import io.grpc.testing.TlsTesting; import io.grpc.testing.TlsTesting;
import io.netty.channel.EventLoopGroup; import io.netty.channel.EventLoopGroup;
import io.netty.channel.ServerChannel; import io.netty.channel.ServerChannel;
@ -282,6 +281,7 @@ public class AsyncServer {
} }
@Override @Override
@SuppressWarnings("deprecation") // For StreamObservers, ideally we refactor this class out.
public void streamingFromServer( public void streamingFromServer(
final Messages.SimpleRequest request, final Messages.SimpleRequest request,
final StreamObserver<Messages.SimpleResponse> observer) { final StreamObserver<Messages.SimpleResponse> observer) {
@ -291,7 +291,7 @@ public class AsyncServer {
(ServerCallStreamObserver<Messages.SimpleResponse>) observer; (ServerCallStreamObserver<Messages.SimpleResponse>) observer;
// If the client cancels, copyWithFlowControl takes care of calling // If the client cancels, copyWithFlowControl takes care of calling
// responseObserver.onCompleted() for us // responseObserver.onCompleted() for us
StreamObservers.copyWithFlowControl( io.grpc.stub.StreamObservers.copyWithFlowControl(
new Iterator<Messages.SimpleResponse>() { new Iterator<Messages.SimpleResponse>() {
@Override @Override
public boolean hasNext() { public boolean hasNext() {
@ -312,6 +312,7 @@ public class AsyncServer {
} }
@Override @Override
@SuppressWarnings("deprecation") // For StreamObservers, ideally we refactor this class out.
public StreamObserver<Messages.SimpleRequest> streamingBothWays( public StreamObserver<Messages.SimpleRequest> streamingBothWays(
final StreamObserver<Messages.SimpleResponse> observer) { final StreamObserver<Messages.SimpleResponse> observer) {
// receive data forever and send data forever until client cancels or we shut down. // receive data forever and send data forever until client cancels or we shut down.
@ -319,7 +320,7 @@ public class AsyncServer {
(ServerCallStreamObserver<Messages.SimpleResponse>) observer; (ServerCallStreamObserver<Messages.SimpleResponse>) observer;
// If the client cancels, copyWithFlowControl takes care of calling // If the client cancels, copyWithFlowControl takes care of calling
// responseObserver.onCompleted() for us // responseObserver.onCompleted() for us
StreamObservers.copyWithFlowControl( io.grpc.stub.StreamObservers.copyWithFlowControl(
new Iterator<Messages.SimpleResponse>() { new Iterator<Messages.SimpleResponse>() {
@Override @Override
public boolean hasNext() { public boolean hasNext() {

3
stub/src/main/java/io/grpc/stub/StreamObservers.java
View File

@ -23,7 +23,10 @@ import java.util.Iterator;
/** /**
* Utility functions for working with {@link StreamObserver} and it's common subclasses like * Utility functions for working with {@link StreamObserver} and it's common subclasses like
* {@link CallStreamObserver}. * {@link CallStreamObserver}.
*
* @deprecated Of questionable utility and generally not used.
*/ */
@Deprecated
@ExperimentalApi("https://github.com/grpc/grpc-java/issues/4694") @ExperimentalApi("https://github.com/grpc/grpc-java/issues/4694")
public final class StreamObservers { public final class StreamObservers {
/** /**