diff --git a/auth/src/main/java/io/grpc/auth/ClientAuthInterceptor.java b/auth/src/main/java/io/grpc/auth/ClientAuthInterceptor.java index 608013f70c..ccd02f0f74 100644 --- a/auth/src/main/java/io/grpc/auth/ClientAuthInterceptor.java +++ b/auth/src/main/java/io/grpc/auth/ClientAuthInterceptor.java @@ -70,7 +70,7 @@ public final class ClientAuthInterceptor implements ClientInterceptor { public ClientAuthInterceptor( Credentials credentials, @SuppressWarnings("unused") Executor executor) { - this.credentials = Preconditions.checkNotNull(credentials); + this.credentials = Preconditions.checkNotNull(credentials, "credentials"); // TODO(louiscryan): refresh token asynchronously with this executor. } diff --git a/core/src/main/java/io/grpc/CallOptions.java b/core/src/main/java/io/grpc/CallOptions.java index 9b35d8d03a..0d9919d81c 100644 --- a/core/src/main/java/io/grpc/CallOptions.java +++ b/core/src/main/java/io/grpc/CallOptions.java @@ -183,7 +183,7 @@ public final class CallOptions { @ExperimentalApi("https://github.com/grpc/grpc-java/issues/1766") public CallOptions withAffinity(Attributes affinity) { CallOptions newOptions = new CallOptions(this); - newOptions.affinity = Preconditions.checkNotNull(affinity); + newOptions.affinity = Preconditions.checkNotNull(affinity, "affinity"); return newOptions; } @@ -289,7 +289,7 @@ public final class CallOptions { * @return Key object */ public static Key of(String name, T defaultValue) { - Preconditions.checkNotNull(name); + Preconditions.checkNotNull(name, "name"); return new Key(name, defaultValue); } } @@ -302,8 +302,8 @@ public final class CallOptions { */ @ExperimentalApi("https://github.com/grpc/grpc-java/issues/1869") public CallOptions withOption(Key key, T value) { - Preconditions.checkNotNull(key); - Preconditions.checkNotNull(value); + Preconditions.checkNotNull(key, "key"); + Preconditions.checkNotNull(value, "value"); CallOptions newOptions = new CallOptions(this); int existingIdx = -1; @@ -335,7 +335,7 @@ public final class CallOptions { @ExperimentalApi("https://github.com/grpc/grpc-java/issues/1869") @SuppressWarnings("unchecked") public T getOption(Key key) { - Preconditions.checkNotNull(key); + Preconditions.checkNotNull(key, "key"); for (int i = 0; i < customOptions.length; i++) { if (key.equals(customOptions[i][0])) { return (T) customOptions[i][1]; diff --git a/core/src/main/java/io/grpc/ClientInterceptors.java b/core/src/main/java/io/grpc/ClientInterceptors.java index 0f8dc6c42e..f92345cdc2 100644 --- a/core/src/main/java/io/grpc/ClientInterceptors.java +++ b/core/src/main/java/io/grpc/ClientInterceptors.java @@ -98,7 +98,7 @@ public class ClientInterceptors { * @return a new channel instance with the interceptors applied. */ public static Channel intercept(Channel channel, List interceptors) { - Preconditions.checkNotNull(channel); + Preconditions.checkNotNull(channel, "channel"); for (ClientInterceptor interceptor : interceptors) { channel = new InterceptorChannel(channel, interceptor); } diff --git a/core/src/main/java/io/grpc/Context.java b/core/src/main/java/io/grpc/Context.java index dcba3e72bf..7ddb6444fd 100644 --- a/core/src/main/java/io/grpc/Context.java +++ b/core/src/main/java/io/grpc/Context.java @@ -349,7 +349,7 @@ public class Context { * will still be bound. */ public void detach(Context toAttach) { - Preconditions.checkNotNull(toAttach); + Preconditions.checkNotNull(toAttach, "toAttach"); if (toAttach.attach() != this) { // Log a severe message instead of throwing an exception as the context to attach is assumed // to be the correct one and the unbalanced state represents a coding mistake in a lower @@ -406,8 +406,8 @@ public class Context { */ public void addListener(final CancellationListener cancellationListener, final Executor executor) { - Preconditions.checkNotNull(cancellationListener); - Preconditions.checkNotNull(executor); + Preconditions.checkNotNull(cancellationListener, "cancellationListener"); + Preconditions.checkNotNull(executor, "executor"); if (canBeCancelled) { ExecutableListener executableListener = new ExecutableListener(executor, cancellationListener); @@ -778,7 +778,7 @@ public class Context { } Key(String name, T defaultValue) { - this.name = Preconditions.checkNotNull(name); + this.name = Preconditions.checkNotNull(name, "name"); this.defaultValue = defaultValue; } diff --git a/core/src/main/java/io/grpc/Deadline.java b/core/src/main/java/io/grpc/Deadline.java index 9a8ab59cac..7062cbbc8a 100644 --- a/core/src/main/java/io/grpc/Deadline.java +++ b/core/src/main/java/io/grpc/Deadline.java @@ -60,7 +60,7 @@ public final class Deadline implements Comparable { @VisibleForTesting static Deadline after(long duration, TimeUnit units, Ticker ticker) { - Preconditions.checkNotNull(units); + Preconditions.checkNotNull(units, "units"); return new Deadline(ticker, units.toNanos(duration), true); } diff --git a/core/src/main/java/io/grpc/DecompressorRegistry.java b/core/src/main/java/io/grpc/DecompressorRegistry.java index 5abab52e6c..92c86235c5 100644 --- a/core/src/main/java/io/grpc/DecompressorRegistry.java +++ b/core/src/main/java/io/grpc/DecompressorRegistry.java @@ -160,7 +160,7 @@ public final class DecompressorRegistry { final boolean advertised; DecompressorInfo(Decompressor decompressor, boolean advertised) { - this.decompressor = checkNotNull(decompressor); + this.decompressor = checkNotNull(decompressor, "decompressor"); this.advertised = advertised; } } diff --git a/core/src/main/java/io/grpc/Metadata.java b/core/src/main/java/io/grpc/Metadata.java index 5d65806cd1..962c0c2d46 100644 --- a/core/src/main/java/io/grpc/Metadata.java +++ b/core/src/main/java/io/grpc/Metadata.java @@ -320,7 +320,7 @@ public final class Metadata { * Perform a simple merge of two sets of metadata. */ public void merge(Metadata other) { - Preconditions.checkNotNull(other); + Preconditions.checkNotNull(other, "other"); for (Map.Entry> keyEntry : other.store.entrySet()) { for (int i = 0; i < keyEntry.getValue().size(); i++) { // Must copy the MetadataEntries since they are mutated. If the two Metadata objects are @@ -334,7 +334,7 @@ public final class Metadata { * Merge values for the given set of keys into this set of metadata. */ public void merge(Metadata other, Set> keys) { - Preconditions.checkNotNull(other); + Preconditions.checkNotNull(other, "other"); for (Key key : keys) { List values = other.store.get(key.name()); if (values == null) { @@ -480,7 +480,7 @@ public final class Metadata { } private static String validateName(String n) { - checkNotNull(n); + checkNotNull(n, "name"); checkArgument(n.length() != 0, "token must have at least 1 tchar"); for (int i = 0; i < n.length(); i++) { char tChar = n.charAt(i); @@ -496,7 +496,7 @@ public final class Metadata { } private Key(String name) { - this.originalName = checkNotNull(name); + this.originalName = checkNotNull(name, "name"); // Intern the result for faster string identity checking. this.name = validateName(this.originalName.toLowerCase(Locale.ROOT)).intern(); this.nameBytes = this.name.getBytes(US_ASCII); @@ -604,7 +604,7 @@ public final class Metadata { !name.endsWith(BINARY_HEADER_SUFFIX), "ASCII header is named %s. It must not end with %s", name, BINARY_HEADER_SUFFIX); - this.marshaller = Preconditions.checkNotNull(marshaller); + this.marshaller = Preconditions.checkNotNull(marshaller, "marshaller"); } @Override @@ -630,8 +630,8 @@ public final class Metadata { * Constructor used when application layer adds a parsed value. */ private MetadataEntry(Key key, Object parsed) { - this.parsed = Preconditions.checkNotNull(parsed); - this.key = Preconditions.checkNotNull(key); + this.parsed = Preconditions.checkNotNull(parsed, "parsed"); + this.key = Preconditions.checkNotNull(key, "key"); this.isBinary = key instanceof BinaryKey; } @@ -639,7 +639,7 @@ public final class Metadata { * Constructor used when reading a value from the transport. */ private MetadataEntry(boolean isBinary, byte[] serialized) { - Preconditions.checkNotNull(serialized); + Preconditions.checkNotNull(serialized, "serialized"); this.serializedBinary = serialized; this.isBinary = isBinary; } diff --git a/core/src/main/java/io/grpc/ServerInterceptors.java b/core/src/main/java/io/grpc/ServerInterceptors.java index 6b7a0110fd..821b154237 100644 --- a/core/src/main/java/io/grpc/ServerInterceptors.java +++ b/core/src/main/java/io/grpc/ServerInterceptors.java @@ -105,7 +105,7 @@ public class ServerInterceptors { public static ServerServiceDefinition intercept(BindableService bindableService, ServerInterceptor... interceptors) { - Preconditions.checkNotNull(bindableService); + Preconditions.checkNotNull(bindableService, "bindableService"); return intercept(bindableService.bindService(), Arrays.asList(interceptors)); } @@ -120,7 +120,7 @@ public class ServerInterceptors { */ public static ServerServiceDefinition intercept(ServerServiceDefinition serviceDef, List interceptors) { - Preconditions.checkNotNull(serviceDef); + Preconditions.checkNotNull(serviceDef, "serviceDef"); if (interceptors.isEmpty()) { return serviceDef; } @@ -134,7 +134,7 @@ public class ServerInterceptors { public static ServerServiceDefinition intercept(BindableService bindableService, List interceptors) { - Preconditions.checkNotNull(bindableService); + Preconditions.checkNotNull(bindableService, "bindableService"); return intercept(bindableService.bindService(), interceptors); } diff --git a/core/src/main/java/io/grpc/ServerServiceDefinition.java b/core/src/main/java/io/grpc/ServerServiceDefinition.java index 6c41c5bc8e..088cb6502c 100644 --- a/core/src/main/java/io/grpc/ServerServiceDefinition.java +++ b/core/src/main/java/io/grpc/ServerServiceDefinition.java @@ -59,7 +59,7 @@ public final class ServerServiceDefinition { private ServerServiceDefinition( ServiceDescriptor serviceDescriptor, Map> methods) { - this.serviceDescriptor = checkNotNull(serviceDescriptor); + this.serviceDescriptor = checkNotNull(serviceDescriptor, "serviceDescriptor"); this.methods = ImmutableMap.copyOf(methods); } diff --git a/core/src/main/java/io/grpc/ServiceDescriptor.java b/core/src/main/java/io/grpc/ServiceDescriptor.java index 056c735bdd..20781e1a6a 100644 --- a/core/src/main/java/io/grpc/ServiceDescriptor.java +++ b/core/src/main/java/io/grpc/ServiceDescriptor.java @@ -51,7 +51,7 @@ public final class ServiceDescriptor { } public ServiceDescriptor(String name, Collection> methods) { - this.name = Preconditions.checkNotNull(name); + this.name = Preconditions.checkNotNull(name, "name"); this.methods = Collections.unmodifiableList(new ArrayList>(methods)); } diff --git a/core/src/main/java/io/grpc/Status.java b/core/src/main/java/io/grpc/Status.java index 057b6b383b..630d8a6ff0 100644 --- a/core/src/main/java/io/grpc/Status.java +++ b/core/src/main/java/io/grpc/Status.java @@ -406,7 +406,7 @@ public final class Status { * @return non-{@code null} status */ public static Status fromThrowable(Throwable t) { - Throwable cause = checkNotNull(t); + Throwable cause = checkNotNull(t, "t"); while (cause != null) { if (cause instanceof StatusException) { return ((StatusException) cause).getStatus(); @@ -426,7 +426,7 @@ public final class Status { */ @ExperimentalApi public static Metadata trailersFromThrowable(Throwable t) { - Throwable cause = checkNotNull(t); + Throwable cause = checkNotNull(t, "t"); while (cause != null) { if (cause instanceof StatusException) { return ((StatusException) cause).getTrailers(); @@ -455,7 +455,7 @@ public final class Status { } private Status(Code code, @Nullable String description, @Nullable Throwable cause) { - this.code = checkNotNull(code); + this.code = checkNotNull(code, "code"); this.description = description; this.cause = cause; } diff --git a/core/src/main/java/io/grpc/inprocess/InProcessChannelBuilder.java b/core/src/main/java/io/grpc/inprocess/InProcessChannelBuilder.java index 003e111a35..7bea513f5d 100644 --- a/core/src/main/java/io/grpc/inprocess/InProcessChannelBuilder.java +++ b/core/src/main/java/io/grpc/inprocess/InProcessChannelBuilder.java @@ -64,7 +64,7 @@ public class InProcessChannelBuilder extends private InProcessChannelBuilder(String name) { super(new InProcessSocketAddress(name), "localhost"); - this.name = Preconditions.checkNotNull(name); + this.name = Preconditions.checkNotNull(name, "name"); } /** diff --git a/core/src/main/java/io/grpc/inprocess/InProcessTransport.java b/core/src/main/java/io/grpc/inprocess/InProcessTransport.java index 5c085c20c2..d902589ed4 100644 --- a/core/src/main/java/io/grpc/inprocess/InProcessTransport.java +++ b/core/src/main/java/io/grpc/inprocess/InProcessTransport.java @@ -233,8 +233,8 @@ class InProcessTransport implements ServerTransport, ConnectionClientTransport { private MethodDescriptor method; private InProcessStream(MethodDescriptor method, Metadata headers) { - this.method = checkNotNull(method); - this.headers = checkNotNull(headers); + this.method = checkNotNull(method, "method"); + this.headers = checkNotNull(headers, "headers"); } diff --git a/core/src/main/java/io/grpc/internal/AbstractManagedChannelImplBuilder.java b/core/src/main/java/io/grpc/internal/AbstractManagedChannelImplBuilder.java index c514553389..e896bfea83 100644 --- a/core/src/main/java/io/grpc/internal/AbstractManagedChannelImplBuilder.java +++ b/core/src/main/java/io/grpc/internal/AbstractManagedChannelImplBuilder.java @@ -112,7 +112,7 @@ public abstract class AbstractManagedChannelImplBuilder private long idleTimeoutMillis = ManagedChannelImpl.IDLE_TIMEOUT_MILLIS_DISABLE; protected AbstractManagedChannelImplBuilder(String target) { - this.target = Preconditions.checkNotNull(target); + this.target = Preconditions.checkNotNull(target, "target"); this.directServerAddress = null; } diff --git a/core/src/main/java/io/grpc/internal/AbstractServerStream.java b/core/src/main/java/io/grpc/internal/AbstractServerStream.java index a71fd58d87..05033ad381 100644 --- a/core/src/main/java/io/grpc/internal/AbstractServerStream.java +++ b/core/src/main/java/io/grpc/internal/AbstractServerStream.java @@ -177,7 +177,7 @@ public abstract class AbstractServerStream extends AbstractStream2 * thread. */ public final void setListener(ServerStreamListener listener) { - this.listener = Preconditions.checkNotNull(listener); + this.listener = Preconditions.checkNotNull(listener, "listener"); // Now that the stream has actually been initialized, call the listener's onReady callback if // appropriate. diff --git a/core/src/main/java/io/grpc/internal/AbstractStream.java b/core/src/main/java/io/grpc/internal/AbstractStream.java index a6ddb68b1e..b1ba497198 100644 --- a/core/src/main/java/io/grpc/internal/AbstractStream.java +++ b/core/src/main/java/io/grpc/internal/AbstractStream.java @@ -166,7 +166,7 @@ public abstract class AbstractStream implements Stream { @Override public void writeMessage(InputStream message) { - checkNotNull(message); + checkNotNull(message, "message"); outboundPhase(Phase.MESSAGE); if (!framer.isClosed()) { framer.writePayload(message); diff --git a/core/src/main/java/io/grpc/internal/AbstractStream2.java b/core/src/main/java/io/grpc/internal/AbstractStream2.java index c346f99845..5b8356c408 100644 --- a/core/src/main/java/io/grpc/internal/AbstractStream2.java +++ b/core/src/main/java/io/grpc/internal/AbstractStream2.java @@ -65,7 +65,7 @@ public abstract class AbstractStream2 implements Stream { @Override public final void writeMessage(InputStream message) { - checkNotNull(message); + checkNotNull(message, "message"); if (!framer().isClosed()) { framer().writePayload(message); } diff --git a/core/src/main/java/io/grpc/internal/Http2ClientStream.java b/core/src/main/java/io/grpc/internal/Http2ClientStream.java index d870954f79..14500fbbc5 100644 --- a/core/src/main/java/io/grpc/internal/Http2ClientStream.java +++ b/core/src/main/java/io/grpc/internal/Http2ClientStream.java @@ -82,7 +82,7 @@ public abstract class Http2ClientStream extends AbstractClientStream { * @param headers the received headers */ protected void transportHeadersReceived(Metadata headers) { - Preconditions.checkNotNull(headers); + Preconditions.checkNotNull(headers, "headers"); if (transportError != null) { // Already received a transport error so just augment it. transportError = transportError.augmentDescription(headers.toString()); @@ -150,7 +150,7 @@ public abstract class Http2ClientStream extends AbstractClientStream { * @param trailers the received terminal trailer metadata */ protected void transportTrailersReceived(Metadata trailers) { - Preconditions.checkNotNull(trailers); + Preconditions.checkNotNull(trailers, "trailers"); if (transportError != null) { // Already received a transport error so just augment it. transportError = transportError.augmentDescription(trailers.toString()); diff --git a/core/src/main/java/io/grpc/internal/LogExceptionRunnable.java b/core/src/main/java/io/grpc/internal/LogExceptionRunnable.java index 2b0e5b2a05..4f444e61ea 100644 --- a/core/src/main/java/io/grpc/internal/LogExceptionRunnable.java +++ b/core/src/main/java/io/grpc/internal/LogExceptionRunnable.java @@ -49,7 +49,7 @@ public final class LogExceptionRunnable implements Runnable { private final Runnable task; public LogExceptionRunnable(Runnable task) { - this.task = checkNotNull(task); + this.task = checkNotNull(task, "task"); } @Override diff --git a/core/src/main/java/io/grpc/internal/ServerImpl.java b/core/src/main/java/io/grpc/internal/ServerImpl.java index 08777309b7..a1a36a1b16 100644 --- a/core/src/main/java/io/grpc/internal/ServerImpl.java +++ b/core/src/main/java/io/grpc/internal/ServerImpl.java @@ -123,7 +123,7 @@ public final class ServerImpl extends io.grpc.Server { this.transportServer = Preconditions.checkNotNull(transportServer, "transportServer"); // Fork from the passed in context so that it does not propagate cancellation, it only // inherits values. - this.rootContext = Preconditions.checkNotNull(rootContext).fork(); + this.rootContext = Preconditions.checkNotNull(rootContext, "rootContext").fork(); this.decompressorRegistry = decompressorRegistry; this.compressorRegistry = compressorRegistry; } diff --git a/interop-testing/src/main/java/io/grpc/testing/integration/StressTestClient.java b/interop-testing/src/main/java/io/grpc/testing/integration/StressTestClient.java index 6ef2f07d80..fa8af60168 100644 --- a/interop-testing/src/main/java/io/grpc/testing/integration/StressTestClient.java +++ b/interop-testing/src/main/java/io/grpc/testing/integration/StressTestClient.java @@ -364,10 +364,11 @@ public class StressTestClient { Worker(ManagedChannel channel, List testCaseWeightPairs, int durationSec, String gaugeName) { Preconditions.checkArgument(durationSec >= -1, "durationSec must be gte -1."); - this.channel = Preconditions.checkNotNull(channel); - this.testCaseWeightPairs = Preconditions.checkNotNull(testCaseWeightPairs); + this.channel = Preconditions.checkNotNull(channel, "channel"); + this.testCaseWeightPairs = + Preconditions.checkNotNull(testCaseWeightPairs, "testCaseWeightPairs"); this.durationSec = durationSec == -1 ? null : durationSec; - this.gaugeName = Preconditions.checkNotNull(gaugeName); + this.gaugeName = Preconditions.checkNotNull(gaugeName, "gaugeName"); } @Override @@ -493,7 +494,7 @@ public class StressTestClient { final Iterator testCases; WeightedTestCaseSelector(List testCaseWeightPairs) { - Preconditions.checkNotNull(testCaseWeightPairs); + Preconditions.checkNotNull(testCaseWeightPairs, "testCaseWeightPairs"); Preconditions.checkArgument(testCaseWeightPairs.size() > 0); List testCases = new ArrayList(); @@ -549,7 +550,7 @@ public class StressTestClient { TestCaseWeightPair(TestCases testCase, int weight) { Preconditions.checkArgument(weight >= 0, "weight must be positive."); - this.testCase = Preconditions.checkNotNull(testCase); + this.testCase = Preconditions.checkNotNull(testCase, "testCase"); this.weight = weight; } diff --git a/interop-testing/src/main/java/io/grpc/testing/integration/TestCases.java b/interop-testing/src/main/java/io/grpc/testing/integration/TestCases.java index 5aa807406c..b71bcca7b1 100644 --- a/interop-testing/src/main/java/io/grpc/testing/integration/TestCases.java +++ b/interop-testing/src/main/java/io/grpc/testing/integration/TestCases.java @@ -71,7 +71,7 @@ public enum TestCases { * matching is done case insensitive. */ public static TestCases fromString(String s) { - Preconditions.checkNotNull(s); + Preconditions.checkNotNull(s, "s"); return TestCases.valueOf(s.toUpperCase()); } } diff --git a/netty/src/main/java/io/grpc/netty/CancelClientStreamCommand.java b/netty/src/main/java/io/grpc/netty/CancelClientStreamCommand.java index 9d0020cdf3..f68cd51e29 100644 --- a/netty/src/main/java/io/grpc/netty/CancelClientStreamCommand.java +++ b/netty/src/main/java/io/grpc/netty/CancelClientStreamCommand.java @@ -44,7 +44,7 @@ class CancelClientStreamCommand extends WriteQueue.AbstractQueuedCommand { CancelClientStreamCommand(NettyClientStream stream, Status reason) { this.stream = Preconditions.checkNotNull(stream, "stream"); - Preconditions.checkNotNull(reason); + Preconditions.checkNotNull(reason, "reason"); Preconditions.checkArgument(!reason.isOk(), "Should not cancel with OK status"); this.reason = reason; } diff --git a/netty/src/main/java/io/grpc/netty/CancelServerStreamCommand.java b/netty/src/main/java/io/grpc/netty/CancelServerStreamCommand.java index 9d2a31f75d..420fd8f3ef 100644 --- a/netty/src/main/java/io/grpc/netty/CancelServerStreamCommand.java +++ b/netty/src/main/java/io/grpc/netty/CancelServerStreamCommand.java @@ -45,8 +45,8 @@ class CancelServerStreamCommand extends WriteQueue.AbstractQueuedCommand { private final Status reason; CancelServerStreamCommand(NettyServerStream.TransportState stream, Status reason) { - this.stream = Preconditions.checkNotNull(stream); - this.reason = Preconditions.checkNotNull(reason); + this.stream = Preconditions.checkNotNull(stream, "stream"); + this.reason = Preconditions.checkNotNull(reason, "reason"); } NettyServerStream.TransportState stream() { diff --git a/netty/src/main/java/io/grpc/netty/NettyChannelBuilder.java b/netty/src/main/java/io/grpc/netty/NettyChannelBuilder.java index 43d33804be..4c0b2cf55e 100644 --- a/netty/src/main/java/io/grpc/netty/NettyChannelBuilder.java +++ b/netty/src/main/java/io/grpc/netty/NettyChannelBuilder.java @@ -124,7 +124,7 @@ public class NettyChannelBuilder extends AbstractManagedChannelImplBuilder channelType) { - this.channelType = Preconditions.checkNotNull(channelType); + this.channelType = Preconditions.checkNotNull(channelType, "channelType"); return this; } diff --git a/netty/src/main/java/io/grpc/netty/NettyServerBuilder.java b/netty/src/main/java/io/grpc/netty/NettyServerBuilder.java index 5e9f74d049..3102a90f2e 100644 --- a/netty/src/main/java/io/grpc/netty/NettyServerBuilder.java +++ b/netty/src/main/java/io/grpc/netty/NettyServerBuilder.java @@ -104,7 +104,7 @@ public final class NettyServerBuilder extends AbstractServerImplBuilder channelType) { - this.channelType = Preconditions.checkNotNull(channelType); + this.channelType = Preconditions.checkNotNull(channelType, "channelType"); return this; } diff --git a/netty/src/main/java/io/grpc/netty/ProtocolNegotiators.java b/netty/src/main/java/io/grpc/netty/ProtocolNegotiators.java index 2516f88cb5..0b0ad12e5b 100644 --- a/netty/src/main/java/io/grpc/netty/ProtocolNegotiators.java +++ b/netty/src/main/java/io/grpc/netty/ProtocolNegotiators.java @@ -223,8 +223,8 @@ public final class ProtocolNegotiators { private final int port; TlsNegotiator(SslContext sslContext, String host, int port) { - this.sslContext = checkNotNull(sslContext); - this.host = checkNotNull(host); + this.sslContext = checkNotNull(sslContext, "sslContext"); + this.host = checkNotNull(host, "host"); this.port = port; } diff --git a/netty/src/main/java/io/grpc/netty/SendResponseHeadersCommand.java b/netty/src/main/java/io/grpc/netty/SendResponseHeadersCommand.java index 702d320dcf..ae79936e27 100644 --- a/netty/src/main/java/io/grpc/netty/SendResponseHeadersCommand.java +++ b/netty/src/main/java/io/grpc/netty/SendResponseHeadersCommand.java @@ -44,8 +44,8 @@ class SendResponseHeadersCommand extends WriteQueue.AbstractQueuedCommand { private final boolean endOfStream; SendResponseHeadersCommand(StreamIdHolder stream, Http2Headers headers, boolean endOfStream) { - this.stream = Preconditions.checkNotNull(stream); - this.headers = Preconditions.checkNotNull(headers); + this.stream = Preconditions.checkNotNull(stream, "stream"); + this.headers = Preconditions.checkNotNull(headers, "headers"); this.endOfStream = endOfStream; } diff --git a/okhttp/src/main/java/io/grpc/okhttp/AsyncFrameWriter.java b/okhttp/src/main/java/io/grpc/okhttp/AsyncFrameWriter.java index 75db1dfdbf..9f5a9093e8 100644 --- a/okhttp/src/main/java/io/grpc/okhttp/AsyncFrameWriter.java +++ b/okhttp/src/main/java/io/grpc/okhttp/AsyncFrameWriter.java @@ -70,8 +70,8 @@ class AsyncFrameWriter implements FrameWriter { void becomeConnected(FrameWriter frameWriter, Socket socket) { Preconditions.checkState(this.frameWriter == null, "AsyncFrameWriter's setFrameWriter() should only be called once."); - this.frameWriter = Preconditions.checkNotNull(frameWriter); - this.socket = Preconditions.checkNotNull(socket); + this.frameWriter = Preconditions.checkNotNull(frameWriter, "frameWriter"); + this.socket = Preconditions.checkNotNull(socket, "socket"); } @Override diff --git a/okhttp/src/main/java/io/grpc/okhttp/OkHttpChannelBuilder.java b/okhttp/src/main/java/io/grpc/okhttp/OkHttpChannelBuilder.java index 66e3af9488..b7ec5e2b5e 100644 --- a/okhttp/src/main/java/io/grpc/okhttp/OkHttpChannelBuilder.java +++ b/okhttp/src/main/java/io/grpc/okhttp/OkHttpChannelBuilder.java @@ -154,7 +154,7 @@ public class OkHttpChannelBuilder extends *

Default: TLS */ public final OkHttpChannelBuilder negotiationType(NegotiationType type) { - negotiationType = Preconditions.checkNotNull(type); + negotiationType = Preconditions.checkNotNull(type, "type"); return this; } diff --git a/okhttp/src/main/java/io/grpc/okhttp/OkHttpClientTransport.java b/okhttp/src/main/java/io/grpc/okhttp/OkHttpClientTransport.java index f43714aeda..d0da488f59 100644 --- a/okhttp/src/main/java/io/grpc/okhttp/OkHttpClientTransport.java +++ b/okhttp/src/main/java/io/grpc/okhttp/OkHttpClientTransport.java @@ -211,16 +211,16 @@ class OkHttpClientTransport implements ConnectionClientTransport { this.maxMessageSize = maxMessageSize; defaultAuthority = "notarealauthority:80"; this.userAgent = GrpcUtil.getGrpcUserAgent("okhttp", userAgent); - this.executor = Preconditions.checkNotNull(executor); + this.executor = Preconditions.checkNotNull(executor, "executor"); serializingExecutor = new SerializingExecutor(executor); - this.testFrameReader = Preconditions.checkNotNull(frameReader); - this.testFrameWriter = Preconditions.checkNotNull(testFrameWriter); - this.socket = Preconditions.checkNotNull(socket); + this.testFrameReader = Preconditions.checkNotNull(frameReader, "frameReader"); + this.testFrameWriter = Preconditions.checkNotNull(testFrameWriter, "testFrameWriter"); + this.socket = Preconditions.checkNotNull(socket, "socket"); this.nextStreamId = nextStreamId; this.ticker = ticker; this.connectionSpec = null; this.connectingCallback = connectingCallback; - this.connectedFuture = Preconditions.checkNotNull(connectedFuture); + this.connectedFuture = Preconditions.checkNotNull(connectedFuture, "connectedFuture"); } /** diff --git a/okhttp/src/main/java/io/grpc/okhttp/OkHttpProtocolNegotiator.java b/okhttp/src/main/java/io/grpc/okhttp/OkHttpProtocolNegotiator.java index f22ad74458..b9ee439850 100644 --- a/okhttp/src/main/java/io/grpc/okhttp/OkHttpProtocolNegotiator.java +++ b/okhttp/src/main/java/io/grpc/okhttp/OkHttpProtocolNegotiator.java @@ -61,7 +61,7 @@ class OkHttpProtocolNegotiator { @VisibleForTesting OkHttpProtocolNegotiator(Platform platform) { - this.platform = checkNotNull(platform); + this.platform = checkNotNull(platform, "platform"); } public static OkHttpProtocolNegotiator get() { diff --git a/okhttp/src/main/java/io/grpc/okhttp/OkHttpTlsUpgrader.java b/okhttp/src/main/java/io/grpc/okhttp/OkHttpTlsUpgrader.java index 4cb9c5bcf5..9433f42ccb 100644 --- a/okhttp/src/main/java/io/grpc/okhttp/OkHttpTlsUpgrader.java +++ b/okhttp/src/main/java/io/grpc/okhttp/OkHttpTlsUpgrader.java @@ -65,9 +65,9 @@ final class OkHttpTlsUpgrader { */ public static SSLSocket upgrade(SSLSocketFactory sslSocketFactory, Socket socket, String host, int port, ConnectionSpec spec) throws IOException { - Preconditions.checkNotNull(sslSocketFactory); - Preconditions.checkNotNull(socket); - Preconditions.checkNotNull(spec); + Preconditions.checkNotNull(sslSocketFactory, "sslSocketFactory"); + Preconditions.checkNotNull(socket, "socket"); + Preconditions.checkNotNull(spec, "spec"); SSLSocket sslSocket = (SSLSocket) sslSocketFactory.createSocket( socket, host, port, true /* auto close */); spec.apply(sslSocket, false); diff --git a/stub/src/main/java/io/grpc/stub/AbstractStub.java b/stub/src/main/java/io/grpc/stub/AbstractStub.java index 5b3788bf16..802f1b307b 100644 --- a/stub/src/main/java/io/grpc/stub/AbstractStub.java +++ b/stub/src/main/java/io/grpc/stub/AbstractStub.java @@ -73,8 +73,8 @@ public abstract class AbstractStub> { * @param callOptions the runtime call options to be applied to every call on this stub */ protected AbstractStub(Channel channel, CallOptions callOptions) { - this.channel = checkNotNull(channel); - this.callOptions = checkNotNull(callOptions); + this.channel = checkNotNull(channel, "channel"); + this.callOptions = checkNotNull(callOptions, "callOptions"); } /** @@ -155,7 +155,7 @@ public abstract class AbstractStub> { public final S withChannel(Channel newChannel) { return build(newChannel, callOptions); } - + /** * Sets a custom option to be passed to client interceptors on the channel * {@link io.grpc.ClientInterceptor} via the CallOptions parameter. diff --git a/stub/src/main/java/io/grpc/stub/ClientCalls.java b/stub/src/main/java/io/grpc/stub/ClientCalls.java index e605354cd9..bbb897a281 100644 --- a/stub/src/main/java/io/grpc/stub/ClientCalls.java +++ b/stub/src/main/java/io/grpc/stub/ClientCalls.java @@ -219,7 +219,7 @@ public class ClientCalls { * exception will be generated from an {@link Status#UNKNOWN} status. */ private static StatusRuntimeException toStatusRuntimeException(Throwable t) { - Throwable cause = checkNotNull(t); + Throwable cause = checkNotNull(t, "t"); while (cause != null) { // If we have an embedded status, use it and replace the cause if (cause instanceof StatusException) { diff --git a/stub/src/main/java/io/grpc/stub/ServerCalls.java b/stub/src/main/java/io/grpc/stub/ServerCalls.java index 5b9471a9c0..68b072e71a 100644 --- a/stub/src/main/java/io/grpc/stub/ServerCalls.java +++ b/stub/src/main/java/io/grpc/stub/ServerCalls.java @@ -372,8 +372,8 @@ public class ServerCalls { */ public static void asyncUnimplementedUnaryCall(MethodDescriptor methodDescriptor, StreamObserver responseObserver) { - checkNotNull(methodDescriptor); - checkNotNull(responseObserver); + checkNotNull(methodDescriptor, "methodDescriptor"); + checkNotNull(responseObserver, "responseObserver"); responseObserver.onError(Status.UNIMPLEMENTED .withDescription(String.format("Method %s is unimplemented", methodDescriptor.getFullMethodName())) diff --git a/stub/src/main/java/io/grpc/stub/StreamObservers.java b/stub/src/main/java/io/grpc/stub/StreamObservers.java index 37cb0a0d10..63eca2ffd9 100644 --- a/stub/src/main/java/io/grpc/stub/StreamObservers.java +++ b/stub/src/main/java/io/grpc/stub/StreamObservers.java @@ -56,8 +56,8 @@ public class StreamObservers { */ public static void copyWithFlowControl(final Iterator source, final CallStreamObserver target) { - Preconditions.checkNotNull(source); - Preconditions.checkNotNull(target); + Preconditions.checkNotNull(source, "source"); + Preconditions.checkNotNull(target, "target"); target.setOnReadyHandler(new Runnable() { @Override public void run() { @@ -84,7 +84,7 @@ public class StreamObservers { */ public static void copyWithFlowControl(final Iterable source, CallStreamObserver target) { - Preconditions.checkNotNull(source); + Preconditions.checkNotNull(source, "source"); copyWithFlowControl(source.iterator(), target); } }