From 13ef2261d669795205588e292c547dc8ed9c31f7 Mon Sep 17 00:00:00 2001 From: myPrecious Date: Sat, 12 Aug 2017 06:42:14 +0800 Subject: [PATCH] core: Use bulk operation instead of iteration --- core/src/main/java/io/grpc/PickFirstBalancerFactory.java | 4 +--- grpclb/src/main/java/io/grpc/grpclb/GrpclbLoadBalancer.java | 4 +--- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/core/src/main/java/io/grpc/PickFirstBalancerFactory.java b/core/src/main/java/io/grpc/PickFirstBalancerFactory.java index a1177ed337..40c5931b62 100644 --- a/core/src/main/java/io/grpc/PickFirstBalancerFactory.java +++ b/core/src/main/java/io/grpc/PickFirstBalancerFactory.java @@ -133,9 +133,7 @@ public final class PickFirstBalancerFactory extends LoadBalancer.Factory { List groupList) { List addrs = new ArrayList(); for (EquivalentAddressGroup group : groupList) { - for (SocketAddress addr : group.getAddresses()) { - addrs.add(addr); - } + addrs.addAll(group.getAddresses()); } return new EquivalentAddressGroup(addrs); } diff --git a/grpclb/src/main/java/io/grpc/grpclb/GrpclbLoadBalancer.java b/grpclb/src/main/java/io/grpc/grpclb/GrpclbLoadBalancer.java index fd0fb1b74c..ecfae44d4d 100644 --- a/grpclb/src/main/java/io/grpc/grpclb/GrpclbLoadBalancer.java +++ b/grpclb/src/main/java/io/grpc/grpclb/GrpclbLoadBalancer.java @@ -626,9 +626,7 @@ class GrpclbLoadBalancer extends LoadBalancer implements WithLogId { List groupList) { List addrs = new ArrayList(); for (EquivalentAddressGroup group : groupList) { - for (SocketAddress addr : group.getAddresses()) { - addrs.add(addr); - } + addrs.addAll(group.getAddresses()); } return new EquivalentAddressGroup(addrs); }