grpc
/
grpc-java
mirror of https://github.com/grpc/grpc-java.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

core: Disable panic mode 

It is now discovering legitimate errors in some tests that need to be
resolved first. Follow progress at #3293.
This commit is contained in:
Eric Anderson 2018-02-27 13:42:06 -08:00
parent 09d305c3fc
commit 1b5aadf068
2 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
core/src/main/java/io/grpc/internal/ManagedChannelImpl.java
View File

@ -119,8 +119,12 @@ final class ManagedChannelImpl extends ManagedChannel implements Instrumented<Ch
@Override @Override
void handleUncaughtThrowable(Throwable t) { void handleUncaughtThrowable(Throwable t) {
super.handleUncaughtThrowable(t); super.handleUncaughtThrowable(t);
// Disabled because it breaks some tests, as it detects pre-existing issues.
// See #3293
if (false) {
panic(t); panic(t);
} }
}
}; };
private boolean fullStreamDecompression; private boolean fullStreamDecompression;

3
core/src/test/java/io/grpc/internal/ManagedChannelImplTest.java
View File

@ -97,6 +97,7 @@ import java.util.concurrent.atomic.AtomicBoolean;
import java.util.concurrent.atomic.AtomicLong; import java.util.concurrent.atomic.AtomicLong;
import javax.annotation.Nullable; import javax.annotation.Nullable;
import org.junit.After; import org.junit.After;
import org.junit.Assume;
import org.junit.Before; import org.junit.Before;
import org.junit.Rule; import org.junit.Rule;
import org.junit.Test; import org.junit.Test;
@ -1673,6 +1674,8 @@ public class ManagedChannelImplTest {
} }
private void verifyPanicMode(Throwable cause) { private void verifyPanicMode(Throwable cause) {
Assume.assumeTrue("Panic mode disabled to resolve issues with some tests. See #3293", false);
@SuppressWarnings("unchecked") @SuppressWarnings("unchecked")
ClientCall.Listener<Integer> mockListener = ClientCall.Listener<Integer> mockListener =
(ClientCall.Listener<Integer>) mock(ClientCall.Listener.class); (ClientCall.Listener<Integer>) mock(ClientCall.Listener.class);