From 21dec30924b17ef1348369c66d69ff107fd73e90 Mon Sep 17 00:00:00 2001 From: John Cormie Date: Tue, 9 Jul 2024 12:46:21 -0700 Subject: [PATCH] Establish a default connect timeout. (#11359) Enables the timer added in #11137 --- .../io/grpc/binder/internal/BinderClientTransportFactory.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/binder/src/main/java/io/grpc/binder/internal/BinderClientTransportFactory.java b/binder/src/main/java/io/grpc/binder/internal/BinderClientTransportFactory.java index d28180241e..1e2b80b2fd 100644 --- a/binder/src/main/java/io/grpc/binder/internal/BinderClientTransportFactory.java +++ b/binder/src/main/java/io/grpc/binder/internal/BinderClientTransportFactory.java @@ -127,7 +127,7 @@ public final class BinderClientTransportFactory implements ClientTransportFactor BindServiceFlags bindServiceFlags = BindServiceFlags.DEFAULTS; InboundParcelablePolicy inboundParcelablePolicy = InboundParcelablePolicy.DEFAULT; OneWayBinderProxy.Decorator binderDecorator = OneWayBinderProxy.IDENTITY_DECORATOR; - long readyTimeoutMillis = -1; // TODO(jdcormie) Set an non-infinite default in a separate PR. + long readyTimeoutMillis = 60_000; @Override public BinderClientTransportFactory buildClientTransportFactory() { @@ -210,7 +210,7 @@ public final class BinderClientTransportFactory implements ClientTransportFactor * fail-fast work * as expected despite certain edge cases that could otherwise stall the transport indefinitely. * - *

Optional. Use a negative value to wait indefinitely. + *

Optional but enabled by default. Use a negative value to wait indefinitely. */ public Builder setReadyTimeoutMillis(long readyTimeoutMillis) { this.readyTimeoutMillis = readyTimeoutMillis;