grpc
/
grpc-java
mirror of https://github.com/grpc/grpc-java.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

opentelemetry: Remove delayed attempt recording 

In OpenCensus recording an attempt was delayed in order to wait for
inboundUncompressedSize(). But we don't need that in OpenTelemetry, and
could have removed this code when copying from OpenCensus.
This commit is contained in:
Eric Anderson 2024-04-19 13:01:35 -07:00
parent 5c9b492318
commit 2840fd6b47
1 changed files with 1 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
opentelemetry/src/main/java/io/grpc/opentelemetry/OpenTelemetryMetricsModule.java
View File

@ -39,7 +39,6 @@ import io.grpc.Status;
import io.grpc.Status.Code;
import io.grpc.StreamTracer;
import java.util.concurrent.TimeUnit;
import java.util.concurrent.atomic.AtomicBoolean;
import java.util.concurrent.atomic.AtomicIntegerFieldUpdater;
import java.util.concurrent.atomic.AtomicLong;
import java.util.concurrent.atomic.AtomicLongFieldUpdater;
@ -122,7 +121,6 @@ final class OpenTelemetryMetricsModule {
final Stopwatch stopwatch;
final CallAttemptsTracerFactory attemptsState;
final AtomicBoolean inboundReceivedOrClosed = new AtomicBoolean();
final OpenTelemetryMetricsModule module;
final StreamInfo info;
final String fullMethodName;
@ -160,17 +158,6 @@ final class OpenTelemetryMetricsModule {
}
}
@Override
@SuppressWarnings("NonAtomicVolatileUpdate")
public void inboundMessage(int seqNo) {
if (inboundReceivedOrClosed.compareAndSet(false, true)) {
// Because inboundUncompressedSize() might be called after streamClosed(),
// we will report stats in callEnded(). Note that this attempt is already committed.
attemptsState.inboundMetricTracer = this;
}
}
@Override
public void streamClosed(Status status) {
stopwatch.stop();
@ -186,12 +173,7 @@ final class OpenTelemetryMetricsModule {
}
}
attemptsState.attemptEnded();
if (inboundReceivedOrClosed.compareAndSet(false, true)) {
// Stream is closed early. So no need to record metrics for any inbound events after this
// point.
recordFinishedAttempt();
} // Otherwise will report metrics in callEnded() to guarantee all inbound metrics are
// recorded.
recordFinishedAttempt();
}
void recordFinishedAttempt() {
@ -211,7 +193,6 @@ final class OpenTelemetryMetricsModule {
@VisibleForTesting
static final class CallAttemptsTracerFactory extends ClientStreamTracer.Factory {
ClientTracer inboundMetricTracer;
private final OpenTelemetryMetricsModule module;
private final Stopwatch attemptStopwatch;
private final Stopwatch callStopWatch;
@ -310,10 +291,6 @@ final class OpenTelemetryMetricsModule {
tracer.attemptNanos = attemptStopwatch.elapsed(TimeUnit.NANOSECONDS);
tracer.statusCode = status.getCode();
tracer.recordFinishedAttempt();
} else if (inboundMetricTracer != null) {
// activeStreams has been decremented to 0 by attemptEnded(),
// so inboundMetricTracer.statusCode is guaranteed to be assigned already.
inboundMetricTracer.recordFinishedAttempt();
}
callLatencyNanos = callStopWatch.elapsed(TimeUnit.NANOSECONDS);
// TODO(dnvindhya): record target as an attribute