googleapis: Stabilize google-c2p resolver

Preserve google-c2p-experimental support for the moment to ease testing
migration.
This commit is contained in:
Eric Anderson 2022-03-04 12:50:17 -08:00
parent b66250e9e5
commit 2a364838be
4 changed files with 86 additions and 3 deletions

View File

@ -0,0 +1,52 @@
/*
* Copyright 2022 The gRPC Authors
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package io.grpc.googleapis;
import io.grpc.Internal;
import io.grpc.NameResolver;
import io.grpc.NameResolver.Args;
import io.grpc.NameResolverProvider;
import java.net.URI;
/**
* A provider for {@link GoogleCloudToProdNameResolver}, with experimental scheme.
*/
@Internal
public final class GoogleCloudToProdExperimentalNameResolverProvider extends NameResolverProvider {
private final GoogleCloudToProdNameResolverProvider delegate =
new GoogleCloudToProdNameResolverProvider("google-c2p-experimental");
@Override
public NameResolver newNameResolver(URI targetUri, Args args) {
return delegate.newNameResolver(targetUri, args);
}
@Override
public String getDefaultScheme() {
return delegate.getDefaultScheme();
}
@Override
protected boolean isAvailable() {
return delegate.isAvailable();
}
@Override
protected int priority() {
return delegate.priority();
}
}

View File

@ -16,6 +16,7 @@
package io.grpc.googleapis; package io.grpc.googleapis;
import com.google.common.base.Preconditions;
import io.grpc.Internal; import io.grpc.Internal;
import io.grpc.NameResolver; import io.grpc.NameResolver;
import io.grpc.NameResolver.Args; import io.grpc.NameResolver.Args;
@ -35,11 +36,21 @@ import java.util.Map;
@Internal @Internal
public final class GoogleCloudToProdNameResolverProvider extends NameResolverProvider { public final class GoogleCloudToProdNameResolverProvider extends NameResolverProvider {
private static final String SCHEME = "google-c2p-experimental"; private static final String SCHEME = "google-c2p";
private final String scheme;
public GoogleCloudToProdNameResolverProvider() {
this(SCHEME);
}
GoogleCloudToProdNameResolverProvider(String scheme) {
this.scheme = Preconditions.checkNotNull(scheme, "scheme");
}
@Override @Override
public NameResolver newNameResolver(URI targetUri, Args args) { public NameResolver newNameResolver(URI targetUri, Args args) {
if (SCHEME.equals(targetUri.getScheme())) { if (scheme.equals(targetUri.getScheme())) {
return new GoogleCloudToProdNameResolver( return new GoogleCloudToProdNameResolver(
targetUri, args, GrpcUtil.SHARED_CHANNEL_EXECUTOR, targetUri, args, GrpcUtil.SHARED_CHANNEL_EXECUTOR,
new SharedXdsClientPoolProviderBootstrapSetter()); new SharedXdsClientPoolProviderBootstrapSetter());
@ -49,7 +60,7 @@ public final class GoogleCloudToProdNameResolverProvider extends NameResolverPro
@Override @Override
public String getDefaultScheme() { public String getDefaultScheme() {
return SCHEME; return scheme;
} }
@Override @Override

View File

@ -1 +1,2 @@
io.grpc.googleapis.GoogleCloudToProdExperimentalNameResolverProvider
io.grpc.googleapis.GoogleCloudToProdNameResolverProvider io.grpc.googleapis.GoogleCloudToProdNameResolverProvider

View File

@ -71,9 +71,28 @@ public class GoogleCloudToProdNameResolverProviderTest {
fail("GoogleCloudToProdNameResolverProvider not registered"); fail("GoogleCloudToProdNameResolverProvider not registered");
} }
@Test
public void experimentalProvided() {
for (NameResolverProvider current
: InternalServiceProviders.getCandidatesViaServiceLoader(
NameResolverProvider.class, getClass().getClassLoader())) {
if (current instanceof GoogleCloudToProdExperimentalNameResolverProvider) {
return;
}
}
fail("GoogleCloudToProdExperimentalNameResolverProvider not registered");
}
@Test @Test
public void newNameResolver() { public void newNameResolver() {
assertThat(provider assertThat(provider
.newNameResolver(URI.create("google-c2p:///foo.googleapis.com"), args))
.isInstanceOf(GoogleCloudToProdNameResolver.class);
}
@Test
public void experimentalNewNameResolver() {
assertThat(new GoogleCloudToProdExperimentalNameResolverProvider()
.newNameResolver(URI.create("google-c2p-experimental:///foo.googleapis.com"), args)) .newNameResolver(URI.create("google-c2p-experimental:///foo.googleapis.com"), args))
.isInstanceOf(GoogleCloudToProdNameResolver.class); .isInstanceOf(GoogleCloudToProdNameResolver.class);
} }