From 34857580ff723a79dea1337cf799d0d30087a9e0 Mon Sep 17 00:00:00 2001 From: Kun Zhang Date: Wed, 16 Aug 2017 15:59:48 -0700 Subject: [PATCH] core/test: remove ineffective assertions. (#3352) The assertions are actually wrong and fail every time. It doesn't cause test failures because SharedResourceHolder calls them in a scheduled executor because of its delayed close feature. It's better to remove them, rather than leaving them there deceiving us. --- core/src/test/java/io/grpc/internal/DnsNameResolverTest.java | 2 -- 1 file changed, 2 deletions(-) diff --git a/core/src/test/java/io/grpc/internal/DnsNameResolverTest.java b/core/src/test/java/io/grpc/internal/DnsNameResolverTest.java index 181b210197..fd8fd932d8 100644 --- a/core/src/test/java/io/grpc/internal/DnsNameResolverTest.java +++ b/core/src/test/java/io/grpc/internal/DnsNameResolverTest.java @@ -79,7 +79,6 @@ public class DnsNameResolverTest { @Override public void close(ScheduledExecutorService instance) { - assertSame(fakeClock, instance); } }; @@ -92,7 +91,6 @@ public class DnsNameResolverTest { @Override public void close(ExecutorService instance) { - assertSame(fakeExecutor, instance); } };