From 35ff624eb214d2b080eeb97cf3955bcdf90a1379 Mon Sep 17 00:00:00 2001 From: Eric Anderson Date: Wed, 8 Jul 2015 09:46:06 -0700 Subject: [PATCH] Metadata.Key's name is non-null; don't check for null There is a Preconditions.checkNotNull guaranteeing name is not null. --- core/src/main/java/io/grpc/Metadata.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/core/src/main/java/io/grpc/Metadata.java b/core/src/main/java/io/grpc/Metadata.java index 4a55c4a44f..9480fc6bfa 100644 --- a/core/src/main/java/io/grpc/Metadata.java +++ b/core/src/main/java/io/grpc/Metadata.java @@ -444,12 +444,12 @@ public abstract class Metadata { return false; } Key key = (Key) o; - return !(name != null ? !name.equals(key.name) : key.name != null); + return name.equals(key.name); } @Override public int hashCode() { - return name != null ? name.hashCode() : 0; + return name.hashCode(); } @Override