From 3c19325587643e94442fe720d72bae64cdc00e6c Mon Sep 17 00:00:00 2001 From: Tony An Date: Mon, 31 Jul 2023 14:03:00 -0700 Subject: [PATCH] removed assert for flakey static stride scheduler with multiple threads (#10437) on master branch --- .../main/java/io/grpc/xds/WeightedRoundRobinLoadBalancer.java | 3 --- 1 file changed, 3 deletions(-) diff --git a/xds/src/main/java/io/grpc/xds/WeightedRoundRobinLoadBalancer.java b/xds/src/main/java/io/grpc/xds/WeightedRoundRobinLoadBalancer.java index c2f06c8046..1d39844058 100644 --- a/xds/src/main/java/io/grpc/xds/WeightedRoundRobinLoadBalancer.java +++ b/xds/src/main/java/io/grpc/xds/WeightedRoundRobinLoadBalancer.java @@ -431,9 +431,7 @@ final class WeightedRoundRobinLoadBalancer extends RoundRobinLoadBalancer { * an offset that varies per backend index is also included to the calculation. */ int pick() { - int i = 0; while (true) { - i++; long sequence = this.nextSequence(); int backendIndex = (int) (sequence % scaledWeights.length); long generation = sequence / scaledWeights.length; @@ -442,7 +440,6 @@ final class WeightedRoundRobinLoadBalancer extends RoundRobinLoadBalancer { if ((weight * generation + offset) % K_MAX_WEIGHT < K_MAX_WEIGHT - weight) { continue; } - assert i <= scaledWeights.length : "scheduler has more than one pass through"; return backendIndex; } }