From 3d51756d61b1e63d662bd2229a1318bbbe2c9f77 Mon Sep 17 00:00:00 2001 From: zpencer Date: Thu, 1 Nov 2018 16:14:42 -0700 Subject: [PATCH] core, services: fix more import lints (#5021) --- .../java/io/grpc/internal/RoundRobinLoadBalancerTest.java | 1 + .../test/java/io/grpc/util/ForwardingLoadBalancerTest.java | 2 -- .../grpc/services/HealthCheckingLoadBalancerFactoryTest.java | 4 ++-- 3 files changed, 3 insertions(+), 4 deletions(-) diff --git a/core/src/test/java/io/grpc/internal/RoundRobinLoadBalancerTest.java b/core/src/test/java/io/grpc/internal/RoundRobinLoadBalancerTest.java index 7bdbef39a6..f8fc434062 100644 --- a/core/src/test/java/io/grpc/internal/RoundRobinLoadBalancerTest.java +++ b/core/src/test/java/io/grpc/internal/RoundRobinLoadBalancerTest.java @@ -624,6 +624,7 @@ public class RoundRobinLoadBalancerTest { picker = pickerCaptor.getValue(); // second pick with a different stickiness value + @SuppressWarnings("unused") Subchannel sc2 = picker.pickSubchannel(mockArgs).getSubchannel(); // go back to ready diff --git a/core/src/test/java/io/grpc/util/ForwardingLoadBalancerTest.java b/core/src/test/java/io/grpc/util/ForwardingLoadBalancerTest.java index be6c7f7d2e..0122646684 100644 --- a/core/src/test/java/io/grpc/util/ForwardingLoadBalancerTest.java +++ b/core/src/test/java/io/grpc/util/ForwardingLoadBalancerTest.java @@ -21,7 +21,6 @@ import static org.mockito.Mockito.mock; import io.grpc.ForwardingTestUtil; import io.grpc.LoadBalancer; import java.lang.reflect.Method; -import java.net.SocketAddress; import java.util.Collections; import org.junit.Test; import org.junit.runner.RunWith; @@ -41,7 +40,6 @@ public class ForwardingLoadBalancerTest { @Test public void allMethodsForwarded() throws Exception { - final SocketAddress mockAddr = mock(SocketAddress.class); ForwardingTestUtil.testMethodsForwarded( LoadBalancer.class, mockDelegate, diff --git a/services/src/test/java/io/grpc/services/HealthCheckingLoadBalancerFactoryTest.java b/services/src/test/java/io/grpc/services/HealthCheckingLoadBalancerFactoryTest.java index 68cf840ad4..da39803fe9 100644 --- a/services/src/test/java/io/grpc/services/HealthCheckingLoadBalancerFactoryTest.java +++ b/services/src/test/java/io/grpc/services/HealthCheckingLoadBalancerFactoryTest.java @@ -71,6 +71,7 @@ import io.grpc.stub.StreamObserver; import java.net.SocketAddress; import java.util.Arrays; import java.util.Collections; +import java.util.Deque; import java.util.HashMap; import java.util.LinkedList; import java.util.List; @@ -959,9 +960,8 @@ public class HealthCheckingLoadBalancerFactoryTest { } private static class HealthImpl extends HealthGrpc.HealthImplBase { - boolean isImplemented = true; boolean checkCalled; - final LinkedList calls = new LinkedList(); + final Deque calls = new LinkedList(); @Override public void check(HealthCheckRequest request,