diff --git a/benchmarks/build.gradle b/benchmarks/build.gradle index 342c22d3b1..4d402e82b6 100644 --- a/benchmarks/build.gradle +++ b/benchmarks/build.gradle @@ -24,7 +24,7 @@ jmh { warmupIterations = 10 iterations = 10 fork = 1 - jvmArgs = "-server -Xms768m -Xmx768m -dsa -da -XX:+AggressiveOpts -XX:+UseBiasedLocking -XX:+UseFastAccessorMethods -XX:+OptimizeStringConcat" + jvmArgs = "-server -Xms2g -Xmx2g -dsa -da -XX:+AggressiveOpts -XX:+UseBiasedLocking -XX:+UseFastAccessorMethods -XX:+OptimizeStringConcat" } dependencies { diff --git a/benchmarks/src/jmh/java/io/grpc/benchmarks/netty/AbstractBenchmark.java b/benchmarks/src/jmh/java/io/grpc/benchmarks/netty/AbstractBenchmark.java index e5fc0fbac8..a04c284314 100644 --- a/benchmarks/src/jmh/java/io/grpc/benchmarks/netty/AbstractBenchmark.java +++ b/benchmarks/src/jmh/java/io/grpc/benchmarks/netty/AbstractBenchmark.java @@ -419,8 +419,6 @@ public abstract class AbstractBenchmark { counter.addAndGet(counterDelta); requestObserverRef.get().onValue(request.slice()); streamingCall.request(1); - } else { - requestObserverRef.get().onCompleted(); } } @@ -463,8 +461,6 @@ public abstract class AbstractBenchmark { if (!done.get()) { counter.addAndGet(counterDelta); streamingCall.request(1); - } else { - requestObserverRef.get().onCompleted(); } } diff --git a/stub/src/main/java/io/grpc/stub/StreamObserver.java b/stub/src/main/java/io/grpc/stub/StreamObserver.java index b9a3e81e38..482af60c9c 100644 --- a/stub/src/main/java/io/grpc/stub/StreamObserver.java +++ b/stub/src/main/java/io/grpc/stub/StreamObserver.java @@ -55,7 +55,7 @@ public interface StreamObserver { * * @param value the value passed to the stream */ - public void onValue(V value); + void onValue(V value); /** * Receives a terminating error from the stream. @@ -66,7 +66,7 @@ public interface StreamObserver { * * @param t the error occurred on the stream */ - public void onError(Throwable t); + void onError(Throwable t); /** * Receives a notification of successful stream completion. @@ -75,5 +75,5 @@ public interface StreamObserver { * exception is thrown by an implementation of {@code onCompleted} no further calls to any method * are allowed. */ - public void onCompleted(); + void onCompleted(); }