From 40f401d0e70bd7b0ea16f6cc155a83dad19b6b25 Mon Sep 17 00:00:00 2001 From: Eric Anderson Date: Thu, 17 Oct 2019 07:39:18 -0700 Subject: [PATCH] api: Clarify setting safe/idempotent may change other value --- api/src/main/java/io/grpc/MethodDescriptor.java | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/api/src/main/java/io/grpc/MethodDescriptor.java b/api/src/main/java/io/grpc/MethodDescriptor.java index 105db29e56..6e3c42918d 100644 --- a/api/src/main/java/io/grpc/MethodDescriptor.java +++ b/api/src/main/java/io/grpc/MethodDescriptor.java @@ -534,7 +534,9 @@ public final class MethodDescriptor { /** * Sets whether the method is idempotent. If true, calling this method more than once doesn't - * have additional side effects. If {@code false}, method is also not safe. + * have additional side effects. If {@code false}, method is also not safe. Note that implies + * calling {@code builder.setIdempotent(false).setIdempotent(true)} will leave {@code + * isSafe() == false}. * * @since 1.1.0 */ @@ -549,7 +551,8 @@ public final class MethodDescriptor { /** * Sets whether this method is safe. If true, calling this method any number of times doesn't - * have side effects. If {@code true}, method is also idempotent. + * have side effects. If {@code true}, method is also idempotent. Note that implies calling + * {@code builder.setSafe(true).setSafe(false)} will leave {@code isIdempotent() == true}. * * @since 1.1.0 */