From 5dbe53c050d8e5f82b65df1e0c110e5c4fdaa5e7 Mon Sep 17 00:00:00 2001 From: Eric Anderson Date: Fri, 11 Jan 2019 16:14:50 -0800 Subject: [PATCH] core: Remove incorrect usages of VisibleForTesting The visibility is (correctly) used in non-testing scenarios. --- .../io/grpc/internal/AbstractManagedChannelImplBuilder.java | 1 - core/src/main/java/io/grpc/internal/ProxySocketAddress.java | 2 -- 2 files changed, 3 deletions(-) diff --git a/core/src/main/java/io/grpc/internal/AbstractManagedChannelImplBuilder.java b/core/src/main/java/io/grpc/internal/AbstractManagedChannelImplBuilder.java index 3830c075fd..abadccea31 100644 --- a/core/src/main/java/io/grpc/internal/AbstractManagedChannelImplBuilder.java +++ b/core/src/main/java/io/grpc/internal/AbstractManagedChannelImplBuilder.java @@ -77,7 +77,6 @@ public abstract class AbstractManagedChannelImplBuilder /** * An idle timeout smaller than this would be capped to it. */ - @VisibleForTesting static final long IDLE_MODE_MIN_TIMEOUT_MILLIS = TimeUnit.SECONDS.toMillis(1); private static final ObjectPool DEFAULT_EXECUTOR_POOL = diff --git a/core/src/main/java/io/grpc/internal/ProxySocketAddress.java b/core/src/main/java/io/grpc/internal/ProxySocketAddress.java index e55c8fe303..ae9d00bc69 100644 --- a/core/src/main/java/io/grpc/internal/ProxySocketAddress.java +++ b/core/src/main/java/io/grpc/internal/ProxySocketAddress.java @@ -16,7 +16,6 @@ package io.grpc.internal; -import com.google.common.annotations.VisibleForTesting; import com.google.common.base.Preconditions; import java.net.SocketAddress; @@ -29,7 +28,6 @@ final class ProxySocketAddress extends SocketAddress { private final SocketAddress address; private final ProxyParameters proxyParameters; - @VisibleForTesting ProxySocketAddress(SocketAddress address, ProxyParameters proxyParameters) { this.address = Preconditions.checkNotNull(address); this.proxyParameters = Preconditions.checkNotNull(proxyParameters);