noop: resolve lint warnings found at import. (#4496)

This commit is contained in:
Kun Zhang 2018-05-23 11:58:19 -07:00 committed by GitHub
parent 5c4f2c7c0f
commit 68a462e447
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 9 additions and 11 deletions

View File

@ -42,14 +42,14 @@ public class CallOptionsTest {
= CallOptions.Key.createWithDefault("option1", "default"); = CallOptions.Key.createWithDefault("option1", "default");
private static final CallOptions.Key<String> OPTION_2 private static final CallOptions.Key<String> OPTION_2
= CallOptions.Key.createWithDefault("option2", "default"); = CallOptions.Key.createWithDefault("option2", "default");
private String sampleAuthority = "authority"; private final String sampleAuthority = "authority";
private String sampleCompressor = "compressor"; private final String sampleCompressor = "compressor";
private Deadline.Ticker ticker = new FakeTicker(); private final Deadline.Ticker ticker = new FakeTicker();
private Deadline sampleDeadline = Deadline.after(1, NANOSECONDS, ticker); private final Deadline sampleDeadline = Deadline.after(1, NANOSECONDS, ticker);
private CallCredentials sampleCreds = mock(CallCredentials.class); private final CallCredentials sampleCreds = mock(CallCredentials.class);
private ClientStreamTracer.Factory tracerFactory1 = new FakeTracerFactory("tracerFactory1"); private final ClientStreamTracer.Factory tracerFactory1 = new FakeTracerFactory("tracerFactory1");
private ClientStreamTracer.Factory tracerFactory2 = new FakeTracerFactory("tracerFactory2"); private final ClientStreamTracer.Factory tracerFactory2 = new FakeTracerFactory("tracerFactory2");
private CallOptions allSet = CallOptions.DEFAULT private final CallOptions allSet = CallOptions.DEFAULT
.withAuthority(sampleAuthority) .withAuthority(sampleAuthority)
.withDeadline(sampleDeadline) .withDeadline(sampleDeadline)
.withCallCredentials(sampleCreds) .withCallCredentials(sampleCreds)

View File

@ -22,7 +22,6 @@ import com.google.protobuf.Message.Builder;
import com.google.protobuf.util.JsonFormat; import com.google.protobuf.util.JsonFormat;
import com.google.protobuf.util.JsonFormat.Parser; import com.google.protobuf.util.JsonFormat.Parser;
import com.google.protobuf.util.JsonFormat.Printer; import com.google.protobuf.util.JsonFormat.Printer;
import io.grpc.ExperimentalApi;
import io.grpc.MethodDescriptor.Marshaller; import io.grpc.MethodDescriptor.Marshaller;
import io.grpc.Status; import io.grpc.Status;
import java.io.ByteArrayInputStream; import java.io.ByteArrayInputStream;

View File

@ -73,6 +73,7 @@ public abstract class GrpcHttp2ConnectionHandler extends Http2ConnectionHandler
* useful if the channel will soon be deregistered from the executor and used in a non-Netty * useful if the channel will soon be deregistered from the executor and used in a non-Netty
* context. * context.
*/ */
@SuppressWarnings("FutureReturnValueIgnored")
public void notifyUnused() { public void notifyUnused() {
channelUnused.setSuccess(null); channelUnused.setSuccess(null);
} }

View File

@ -23,14 +23,12 @@ import io.grpc.ClientInterceptor;
import io.grpc.ServerInterceptor; import io.grpc.ServerInterceptor;
import java.io.IOException; import java.io.IOException;
import java.util.concurrent.atomic.AtomicLong; import java.util.concurrent.atomic.AtomicLong;
import java.util.logging.Logger;
import javax.annotation.Nullable; import javax.annotation.Nullable;
/** /**
* The default implementation of a {@link BinaryLogProvider}. * The default implementation of a {@link BinaryLogProvider}.
*/ */
class BinaryLogProviderImpl extends BinaryLogProvider { class BinaryLogProviderImpl extends BinaryLogProvider {
private static final Logger logger = Logger.getLogger(BinaryLogProviderImpl.class.getName());
private final BinlogHelper.Factory factory; private final BinlogHelper.Factory factory;
private final BinaryLogSink sink; private final BinaryLogSink sink;
private final AtomicLong counter = new AtomicLong(); private final AtomicLong counter = new AtomicLong();