diff --git a/java_grpc_library.bzl b/java_grpc_library.bzl index 9c271a83ee..5ea8386fdd 100644 --- a/java_grpc_library.bzl +++ b/java_grpc_library.bzl @@ -1,39 +1,43 @@ def _path_ignoring_repository(f): - if (len(f.owner.workspace_root) == 0): - return f.short_path - return f.path[f.path.find(f.owner.workspace_root)+len(f.owner.workspace_root)+1:] + if (len(f.owner.workspace_root) == 0): + return f.short_path + return f.path[f.path.find(f.owner.workspace_root) + len(f.owner.workspace_root) + 1:] def _gensource_impl(ctx): - if len(ctx.attr.srcs) > 1: - fail("Only one src value supported", "srcs") - for s in ctx.attr.srcs: - if s.label.package != ctx.label.package: - print(("in srcs attribute of {0}: Proto source with label {1} should be in " - + "same package as consuming rule").format(ctx.label, s.label)) - # Use .jar since .srcjar makes protoc think output will be a directory - srcdotjar = ctx.new_file(ctx.label.name + "_src.jar") + if len(ctx.attr.srcs) > 1: + fail("Only one src value supported", "srcs") + for s in ctx.attr.srcs: + if s.label.package != ctx.label.package: + print(("in srcs attribute of {0}: Proto source with label {1} should be in " + + "same package as consuming rule").format(ctx.label, s.label)) - srcs = [f for dep in ctx.attr.srcs for f in dep.proto.direct_sources] - includes = [f for dep in ctx.attr.srcs for f in dep.proto.transitive_imports] + # Use .jar since .srcjar makes protoc think output will be a directory + srcdotjar = ctx.new_file(ctx.label.name + "_src.jar") - flavor = ctx.attr.flavor - if flavor == "normal": - flavor = "" - ctx.action( - inputs = [ctx.executable._java_plugin] + srcs + includes, - outputs = [srcdotjar], - executable = ctx.executable._protoc, - arguments = [ - "--plugin=protoc-gen-grpc-java=" + ctx.executable._java_plugin.path, - "--grpc-java_out={0},enable_deprecated={1}:{2}" - .format(flavor, str(ctx.attr.enable_deprecated).lower(), srcdotjar.path)] - + ["-I{0}={1}".format(_path_ignoring_repository(include), include.path) for include in includes] - + [_path_ignoring_repository(src) for src in srcs]) - ctx.action( - command = "cp $1 $2", - inputs = [srcdotjar], - outputs = [ctx.outputs.srcjar], - arguments = [srcdotjar.path, ctx.outputs.srcjar.path]) + srcs = [f for dep in ctx.attr.srcs for f in dep.proto.direct_sources] + includes = [f for dep in ctx.attr.srcs for f in dep.proto.transitive_imports] + + flavor = ctx.attr.flavor + if flavor == "normal": + flavor = "" + ctx.action( + inputs = [ctx.executable._java_plugin] + srcs + includes, + outputs = [srcdotjar], + executable = ctx.executable._protoc, + arguments = [ + "--plugin=protoc-gen-grpc-java=" + ctx.executable._java_plugin.path, + "--grpc-java_out={0},enable_deprecated={1}:{2}" + .format(flavor, str(ctx.attr.enable_deprecated).lower(), srcdotjar.path), + ] + + ["-I{0}={1}".format(_path_ignoring_repository(include), include.path) for include in includes] + + [_path_ignoring_repository(src) for src in srcs], + ) + ctx.action( + command = "cp $1 $2", + inputs = [srcdotjar], + outputs = [ctx.outputs.srcjar], + arguments = [srcdotjar.path, ctx.outputs.srcjar.path], + ) _gensource = rule( attrs = { @@ -69,65 +73,70 @@ _gensource = rule( implementation = _gensource_impl, ) -def java_grpc_library(name, srcs, deps, flavor=None, - enable_deprecated=None, visibility=None, - **kwargs): - """Generates and compiles gRPC Java sources for services defined in a proto - file. This rule is compatible with java_proto_library and java_lite_proto_library. +def java_grpc_library( + name, + srcs, + deps, + flavor = None, + enable_deprecated = None, + visibility = None, + **kwargs): + """Generates and compiles gRPC Java sources for services defined in a proto + file. This rule is compatible with java_proto_library and java_lite_proto_library. - Do note that this rule only scans through the proto file for RPC services. It - does not generate Java classes for proto messages. You will need a separate - java_proto_library or java_lite_proto_library rule. + Do note that this rule only scans through the proto file for RPC services. It + does not generate Java classes for proto messages. You will need a separate + java_proto_library or java_lite_proto_library rule. - Args: - name: (str) A unique name for this rule. Required. - srcs: (list) a single proto_library target that contains the schema of the - service. Required. - deps: (list) a single java_proto_library target for the proto_library in - srcs. Required. - flavor: (str) "normal" (default) for normal proto runtime. "lite" - for the lite runtime. - visibility: (list) the visibility list - **kwargs: Passed through to generated targets - """ - if flavor == None: - flavor = "normal" + Args: + name: (str) A unique name for this rule. Required. + srcs: (list) a single proto_library target that contains the schema of the + service. Required. + deps: (list) a single java_proto_library target for the proto_library in + srcs. Required. + flavor: (str) "normal" (default) for normal proto runtime. "lite" + for the lite runtime. + visibility: (list) the visibility list + **kwargs: Passed through to generated targets + """ + if flavor == None: + flavor = "normal" - if len(deps) > 1: - print("Multiple values in 'deps' is deprecated in " + name) + if len(deps) > 1: + print("Multiple values in 'deps' is deprecated in " + name) - gensource_name = name + "__do_not_reference__srcjar" - _gensource( - name = gensource_name, - srcs = srcs, - flavor = flavor, - enable_deprecated = enable_deprecated, - visibility = ["//visibility:private"], - **kwargs - ) + gensource_name = name + "__do_not_reference__srcjar" + _gensource( + name = gensource_name, + srcs = srcs, + flavor = flavor, + enable_deprecated = enable_deprecated, + visibility = ["//visibility:private"], + **kwargs + ) - added_deps = [ - "@io_grpc_grpc_java//core", - "@io_grpc_grpc_java//stub", - "@io_grpc_grpc_java//stub:javax_annotation", - "@com_google_guava_guava//jar", - ] - if flavor == "normal": - added_deps += [ - "@com_google_protobuf//:protobuf_java", - "@io_grpc_grpc_java//protobuf", + added_deps = [ + "@io_grpc_grpc_java//core", + "@io_grpc_grpc_java//stub", + "@io_grpc_grpc_java//stub:javax_annotation", + "@com_google_guava_guava//jar", ] - elif flavor == "lite": - added_deps += ["@io_grpc_grpc_java//protobuf-lite"] - else: - fail("Unknown flavor type", "flavor") + if flavor == "normal": + added_deps += [ + "@com_google_protobuf//:protobuf_java", + "@io_grpc_grpc_java//protobuf", + ] + elif flavor == "lite": + added_deps += ["@io_grpc_grpc_java//protobuf-lite"] + else: + fail("Unknown flavor type", "flavor") - native.java_library( - name = name, - srcs = [gensource_name], - visibility = visibility, - deps = [ - "@com_google_code_findbugs_jsr305//jar", - ] + deps + added_deps, - **kwargs - ) + native.java_library( + name = name, + srcs = [gensource_name], + visibility = visibility, + deps = [ + "@com_google_code_findbugs_jsr305//jar", + ] + deps + added_deps, + **kwargs + )