From 6da8f471f7bac93ea88a713dc0db31eaa6f5669f Mon Sep 17 00:00:00 2001 From: Kun Zhang Date: Mon, 28 Nov 2016 17:45:11 -0800 Subject: [PATCH] compiler: whitelist USER32.DLL. (#2455) The 32-bit windows grpc codegen built with protobuf 3.0.2 depends on USER32.DLL, while the previous release built with protobuf 3.0.0 didn't. Both protobuf and grpc codegen are built under msys2-mingw32. "objdump -x libprotobuf-10.dll | grep DLL" also shows the USER32.DLL dependency being brought by protobuf: 3.0.0 DLL Name: KERNEL32.dll DLL Name: msvcrt.dll DLL Name: zlib1.dll DLL Name: libgcc_s_dw2-1.dll DLL Name: libstdc++-6.dll 3.0.2 DLL Name: KERNEL32.dll DLL Name: msvcrt.dll DLL Name: USER32.dll DLL Name: zlib1.dll DLL Name: libgcc_s_dw2-1.dll DLL Name: libstdc++-6.dll While unexpected, USER32.dll is shipped with Windows so having such dependency shouldn't cause any trouble. --- compiler/check-artifact.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/compiler/check-artifact.sh b/compiler/check-artifact.sh index a915e2acba..af318611c9 100755 --- a/compiler/check-artifact.sh +++ b/compiler/check-artifact.sh @@ -96,7 +96,7 @@ checkDependencies () echo "Checking dependencies of $1" if [[ "$OS" == windows ]]; then dump_cmd='objdump -x '"$1"' | fgrep "DLL Name"' - white_list="KERNEL32\.dll\|msvcrt\.dll" + white_list="KERNEL32\.dll\|msvcrt\.dll\|USER32\.dll" elif [[ "$OS" == linux ]]; then dump_cmd='ldd '"$1" if [[ "$ARCH" == x86_32 ]]; then