From 7aa807ce6d894254348ad5f300bff4d6be4190d1 Mon Sep 17 00:00:00 2001 From: Eric Gribkoff Date: Tue, 2 May 2017 10:24:23 -0700 Subject: [PATCH] compiler: remove streaming calls from javadoc for newFutureStub FutureStubs only support unary calls --- .../grpc/io/grpc/benchmarks/proto/BenchmarkServiceGrpc.java | 2 +- .../main/grpc/io/grpc/benchmarks/proto/WorkerServiceGrpc.java | 2 +- compiler/src/java_plugin/cpp/java_generator.cpp | 4 ++-- compiler/src/test/golden/TestService.java.txt | 2 +- compiler/src/testLite/golden/TestService.java.txt | 2 +- compiler/src/testNano/golden/TestService.java.txt | 2 +- .../generated/main/grpc/io/grpc/grpclb/LoadBalancerGrpc.java | 2 +- .../src/generated/main/grpc/io/grpc/health/v1/HealthGrpc.java | 2 +- .../grpc/io/grpc/instrumentation/v1alpha/MonitoringGrpc.java | 2 +- .../grpc/io/grpc/reflection/v1alpha/ServerReflectionGrpc.java | 2 +- .../io/grpc/reflection/testing/AnotherDynamicServiceGrpc.java | 2 +- .../grpc/io/grpc/reflection/testing/DynamicServiceGrpc.java | 2 +- .../io/grpc/reflection/testing/ReflectableServiceGrpc.java | 2 +- .../grpc/io/grpc/testing/integration/MetricsServiceGrpc.java | 2 +- .../io/grpc/testing/integration/ReconnectServiceGrpc.java | 2 +- .../grpc/io/grpc/testing/integration/TestServiceGrpc.java | 2 +- .../io/grpc/testing/integration/UnimplementedServiceGrpc.java | 2 +- 17 files changed, 18 insertions(+), 18 deletions(-) diff --git a/benchmarks/src/generated/main/grpc/io/grpc/benchmarks/proto/BenchmarkServiceGrpc.java b/benchmarks/src/generated/main/grpc/io/grpc/benchmarks/proto/BenchmarkServiceGrpc.java index a4505aaee5..2ebeb3202b 100644 --- a/benchmarks/src/generated/main/grpc/io/grpc/benchmarks/proto/BenchmarkServiceGrpc.java +++ b/benchmarks/src/generated/main/grpc/io/grpc/benchmarks/proto/BenchmarkServiceGrpc.java @@ -68,7 +68,7 @@ public final class BenchmarkServiceGrpc { } /** - * Creates a new ListenableFuture-style stub that supports unary and streaming output calls on the service + * Creates a new ListenableFuture-style stub that supports unary calls on the service */ public static BenchmarkServiceFutureStub newFutureStub( io.grpc.Channel channel) { diff --git a/benchmarks/src/generated/main/grpc/io/grpc/benchmarks/proto/WorkerServiceGrpc.java b/benchmarks/src/generated/main/grpc/io/grpc/benchmarks/proto/WorkerServiceGrpc.java index 7be1d5d1ba..68a245c6f5 100644 --- a/benchmarks/src/generated/main/grpc/io/grpc/benchmarks/proto/WorkerServiceGrpc.java +++ b/benchmarks/src/generated/main/grpc/io/grpc/benchmarks/proto/WorkerServiceGrpc.java @@ -92,7 +92,7 @@ public final class WorkerServiceGrpc { } /** - * Creates a new ListenableFuture-style stub that supports unary and streaming output calls on the service + * Creates a new ListenableFuture-style stub that supports unary calls on the service */ public static WorkerServiceFutureStub newFutureStub( io.grpc.Channel channel) { diff --git a/compiler/src/java_plugin/cpp/java_generator.cpp b/compiler/src/java_plugin/cpp/java_generator.cpp index d48263e25a..3ce4adba55 100644 --- a/compiler/src/java_plugin/cpp/java_generator.cpp +++ b/compiler/src/java_plugin/cpp/java_generator.cpp @@ -1078,8 +1078,8 @@ static void PrintService(const ServiceDescriptor* service, p->Print("}\n\n"); // TODO(nmittler): Replace with WriteDocComment once included by protobuf distro. - GrpcWriteDocComment(p, " Creates a new ListenableFuture-style stub that supports unary and " - "streaming output calls on the service"); + GrpcWriteDocComment(p, " Creates a new ListenableFuture-style stub that supports unary calls " + "on the service"); p->Print( *vars, "public static $service_name$FutureStub newFutureStub(\n" diff --git a/compiler/src/test/golden/TestService.java.txt b/compiler/src/test/golden/TestService.java.txt index 4de84cd181..7fd62e3440 100644 --- a/compiler/src/test/golden/TestService.java.txt +++ b/compiler/src/test/golden/TestService.java.txt @@ -107,7 +107,7 @@ public final class TestServiceGrpc { } /** - * Creates a new ListenableFuture-style stub that supports unary and streaming output calls on the service + * Creates a new ListenableFuture-style stub that supports unary calls on the service */ public static TestServiceFutureStub newFutureStub( io.grpc.Channel channel) { diff --git a/compiler/src/testLite/golden/TestService.java.txt b/compiler/src/testLite/golden/TestService.java.txt index 57c5dd0be9..7ddcfe278b 100644 --- a/compiler/src/testLite/golden/TestService.java.txt +++ b/compiler/src/testLite/golden/TestService.java.txt @@ -107,7 +107,7 @@ public final class TestServiceGrpc { } /** - * Creates a new ListenableFuture-style stub that supports unary and streaming output calls on the service + * Creates a new ListenableFuture-style stub that supports unary calls on the service */ public static TestServiceFutureStub newFutureStub( io.grpc.Channel channel) { diff --git a/compiler/src/testNano/golden/TestService.java.txt b/compiler/src/testNano/golden/TestService.java.txt index 11df28fa06..9453264de7 100644 --- a/compiler/src/testNano/golden/TestService.java.txt +++ b/compiler/src/testNano/golden/TestService.java.txt @@ -170,7 +170,7 @@ public final class TestServiceGrpc { } /** - * Creates a new ListenableFuture-style stub that supports unary and streaming output calls on the service + * Creates a new ListenableFuture-style stub that supports unary calls on the service */ public static TestServiceFutureStub newFutureStub( io.grpc.Channel channel) { diff --git a/grpclb/src/generated/main/grpc/io/grpc/grpclb/LoadBalancerGrpc.java b/grpclb/src/generated/main/grpc/io/grpc/grpclb/LoadBalancerGrpc.java index 2a074345b3..0a0651aadc 100644 --- a/grpclb/src/generated/main/grpc/io/grpc/grpclb/LoadBalancerGrpc.java +++ b/grpclb/src/generated/main/grpc/io/grpc/grpclb/LoadBalancerGrpc.java @@ -56,7 +56,7 @@ public final class LoadBalancerGrpc { } /** - * Creates a new ListenableFuture-style stub that supports unary and streaming output calls on the service + * Creates a new ListenableFuture-style stub that supports unary calls on the service */ public static LoadBalancerFutureStub newFutureStub( io.grpc.Channel channel) { diff --git a/services/src/generated/main/grpc/io/grpc/health/v1/HealthGrpc.java b/services/src/generated/main/grpc/io/grpc/health/v1/HealthGrpc.java index bc51b4e6e6..97bf02b77b 100644 --- a/services/src/generated/main/grpc/io/grpc/health/v1/HealthGrpc.java +++ b/services/src/generated/main/grpc/io/grpc/health/v1/HealthGrpc.java @@ -56,7 +56,7 @@ public final class HealthGrpc { } /** - * Creates a new ListenableFuture-style stub that supports unary and streaming output calls on the service + * Creates a new ListenableFuture-style stub that supports unary calls on the service */ public static HealthFutureStub newFutureStub( io.grpc.Channel channel) { diff --git a/services/src/generated/main/grpc/io/grpc/instrumentation/v1alpha/MonitoringGrpc.java b/services/src/generated/main/grpc/io/grpc/instrumentation/v1alpha/MonitoringGrpc.java index d0577f4374..73a38e3b40 100644 --- a/services/src/generated/main/grpc/io/grpc/instrumentation/v1alpha/MonitoringGrpc.java +++ b/services/src/generated/main/grpc/io/grpc/instrumentation/v1alpha/MonitoringGrpc.java @@ -104,7 +104,7 @@ public final class MonitoringGrpc { } /** - * Creates a new ListenableFuture-style stub that supports unary and streaming output calls on the service + * Creates a new ListenableFuture-style stub that supports unary calls on the service */ public static MonitoringFutureStub newFutureStub( io.grpc.Channel channel) { diff --git a/services/src/generated/main/grpc/io/grpc/reflection/v1alpha/ServerReflectionGrpc.java b/services/src/generated/main/grpc/io/grpc/reflection/v1alpha/ServerReflectionGrpc.java index cb050e8064..7aa8a1f620 100644 --- a/services/src/generated/main/grpc/io/grpc/reflection/v1alpha/ServerReflectionGrpc.java +++ b/services/src/generated/main/grpc/io/grpc/reflection/v1alpha/ServerReflectionGrpc.java @@ -56,7 +56,7 @@ public final class ServerReflectionGrpc { } /** - * Creates a new ListenableFuture-style stub that supports unary and streaming output calls on the service + * Creates a new ListenableFuture-style stub that supports unary calls on the service */ public static ServerReflectionFutureStub newFutureStub( io.grpc.Channel channel) { diff --git a/services/src/generated/test/grpc/io/grpc/reflection/testing/AnotherDynamicServiceGrpc.java b/services/src/generated/test/grpc/io/grpc/reflection/testing/AnotherDynamicServiceGrpc.java index 063d54ad6b..0d4e66a0c9 100644 --- a/services/src/generated/test/grpc/io/grpc/reflection/testing/AnotherDynamicServiceGrpc.java +++ b/services/src/generated/test/grpc/io/grpc/reflection/testing/AnotherDynamicServiceGrpc.java @@ -59,7 +59,7 @@ public final class AnotherDynamicServiceGrpc { } /** - * Creates a new ListenableFuture-style stub that supports unary and streaming output calls on the service + * Creates a new ListenableFuture-style stub that supports unary calls on the service */ public static AnotherDynamicServiceFutureStub newFutureStub( io.grpc.Channel channel) { diff --git a/services/src/generated/test/grpc/io/grpc/reflection/testing/DynamicServiceGrpc.java b/services/src/generated/test/grpc/io/grpc/reflection/testing/DynamicServiceGrpc.java index 55418c46b0..79b2b1c424 100644 --- a/services/src/generated/test/grpc/io/grpc/reflection/testing/DynamicServiceGrpc.java +++ b/services/src/generated/test/grpc/io/grpc/reflection/testing/DynamicServiceGrpc.java @@ -59,7 +59,7 @@ public final class DynamicServiceGrpc { } /** - * Creates a new ListenableFuture-style stub that supports unary and streaming output calls on the service + * Creates a new ListenableFuture-style stub that supports unary calls on the service */ public static DynamicServiceFutureStub newFutureStub( io.grpc.Channel channel) { diff --git a/services/src/generated/test/grpc/io/grpc/reflection/testing/ReflectableServiceGrpc.java b/services/src/generated/test/grpc/io/grpc/reflection/testing/ReflectableServiceGrpc.java index 28822f2d5e..c4c630b5be 100644 --- a/services/src/generated/test/grpc/io/grpc/reflection/testing/ReflectableServiceGrpc.java +++ b/services/src/generated/test/grpc/io/grpc/reflection/testing/ReflectableServiceGrpc.java @@ -56,7 +56,7 @@ public final class ReflectableServiceGrpc { } /** - * Creates a new ListenableFuture-style stub that supports unary and streaming output calls on the service + * Creates a new ListenableFuture-style stub that supports unary calls on the service */ public static ReflectableServiceFutureStub newFutureStub( io.grpc.Channel channel) { diff --git a/testing-proto/src/generated/main/grpc/io/grpc/testing/integration/MetricsServiceGrpc.java b/testing-proto/src/generated/main/grpc/io/grpc/testing/integration/MetricsServiceGrpc.java index b474d48270..0f119fc59e 100644 --- a/testing-proto/src/generated/main/grpc/io/grpc/testing/integration/MetricsServiceGrpc.java +++ b/testing-proto/src/generated/main/grpc/io/grpc/testing/integration/MetricsServiceGrpc.java @@ -68,7 +68,7 @@ public final class MetricsServiceGrpc { } /** - * Creates a new ListenableFuture-style stub that supports unary and streaming output calls on the service + * Creates a new ListenableFuture-style stub that supports unary calls on the service */ public static MetricsServiceFutureStub newFutureStub( io.grpc.Channel channel) { diff --git a/testing-proto/src/generated/main/grpc/io/grpc/testing/integration/ReconnectServiceGrpc.java b/testing-proto/src/generated/main/grpc/io/grpc/testing/integration/ReconnectServiceGrpc.java index 92f78a31e0..5433869223 100644 --- a/testing-proto/src/generated/main/grpc/io/grpc/testing/integration/ReconnectServiceGrpc.java +++ b/testing-proto/src/generated/main/grpc/io/grpc/testing/integration/ReconnectServiceGrpc.java @@ -71,7 +71,7 @@ public final class ReconnectServiceGrpc { } /** - * Creates a new ListenableFuture-style stub that supports unary and streaming output calls on the service + * Creates a new ListenableFuture-style stub that supports unary calls on the service */ public static ReconnectServiceFutureStub newFutureStub( io.grpc.Channel channel) { diff --git a/testing-proto/src/generated/main/grpc/io/grpc/testing/integration/TestServiceGrpc.java b/testing-proto/src/generated/main/grpc/io/grpc/testing/integration/TestServiceGrpc.java index d14c834fdb..d791e29c23 100644 --- a/testing-proto/src/generated/main/grpc/io/grpc/testing/integration/TestServiceGrpc.java +++ b/testing-proto/src/generated/main/grpc/io/grpc/testing/integration/TestServiceGrpc.java @@ -144,7 +144,7 @@ public final class TestServiceGrpc { } /** - * Creates a new ListenableFuture-style stub that supports unary and streaming output calls on the service + * Creates a new ListenableFuture-style stub that supports unary calls on the service */ public static TestServiceFutureStub newFutureStub( io.grpc.Channel channel) { diff --git a/testing-proto/src/generated/main/grpc/io/grpc/testing/integration/UnimplementedServiceGrpc.java b/testing-proto/src/generated/main/grpc/io/grpc/testing/integration/UnimplementedServiceGrpc.java index 71445bfc53..ddfd75b8eb 100644 --- a/testing-proto/src/generated/main/grpc/io/grpc/testing/integration/UnimplementedServiceGrpc.java +++ b/testing-proto/src/generated/main/grpc/io/grpc/testing/integration/UnimplementedServiceGrpc.java @@ -60,7 +60,7 @@ public final class UnimplementedServiceGrpc { } /** - * Creates a new ListenableFuture-style stub that supports unary and streaming output calls on the service + * Creates a new ListenableFuture-style stub that supports unary calls on the service */ public static UnimplementedServiceFutureStub newFutureStub( io.grpc.Channel channel) {