grpc
/
grpc-java
mirror of https://github.com/grpc/grpc-java.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

rls: Fix RouteLookupConfig test arguments 

This PR fixes a few cosmetic violations of the ErrorProne patterns
introduced in PR #8645: ParameterName, and TimeUnitMismatch.
This commit is contained in:
Sergii Tkachenko 2021-12-01 15:02:13 -08:00 committed by Sergii Tkachenko
parent 27b03c66a6
commit 7aaa418ec7
2 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
rls/src/test/java/io/grpc/rls/RlsProtoConvertersTest.java
View File

@ -199,7 +199,7 @@ public class RlsProtoConvertersTest {
ExtraKeys.create("host-key", "service-key", "method-key"), ExtraKeys.create("host-key", "service-key", "method-key"),
ImmutableMap.of("constKey1", "value1"))), ImmutableMap.of("constKey1", "value1"))),
/* lookupService= */ "service1", /* lookupService= */ "service1",
/* lookupServiceTimeoutInMillis= */ TimeUnit.SECONDS.toNanos(2), /* lookupServiceTimeoutInNanos= */ TimeUnit.SECONDS.toNanos(2),
/* maxAgeInNanos= */ TimeUnit.SECONDS.toNanos(300), /* maxAgeInNanos= */ TimeUnit.SECONDS.toNanos(300),
/* staleAgeInNanos= */ TimeUnit.SECONDS.toNanos(240), /* staleAgeInNanos= */ TimeUnit.SECONDS.toNanos(240),
/* cacheSizeBytes= */ 1000, /* cacheSizeBytes= */ 1000,
@ -351,7 +351,7 @@ public class RlsProtoConvertersTest {
ExtraKeys.DEFAULT, ExtraKeys.DEFAULT,
ImmutableMap.<String, String>of())), ImmutableMap.<String, String>of())),
/* lookupService= */ "service1", /* lookupService= */ "service1",
/* lookupServiceTimeoutInMillis= */ TimeUnit.SECONDS.toNanos(10), /* lookupServiceTimeoutInNanos= */ TimeUnit.SECONDS.toNanos(10),
/* maxAgeInNanos= */ TimeUnit.MINUTES.toNanos(5), /* maxAgeInNanos= */ TimeUnit.MINUTES.toNanos(5),
/* staleAgeInNanos= */ TimeUnit.MINUTES.toNanos(5), /* staleAgeInNanos= */ TimeUnit.MINUTES.toNanos(5),
/* cacheSizeBytes= */ 5 * 1024 * 1024, /* cacheSizeBytes= */ 5 * 1024 * 1024,
@ -409,7 +409,7 @@ public class RlsProtoConvertersTest {
ExtraKeys.DEFAULT, ExtraKeys.DEFAULT,
ImmutableMap.<String, String>of())), ImmutableMap.<String, String>of())),
/* lookupService= */ "service1", /* lookupService= */ "service1",
/* lookupServiceTimeoutInMillis= */ TimeUnit.SECONDS.toNanos(2), /* lookupServiceTimeoutInNanos= */ TimeUnit.SECONDS.toNanos(2),
/* maxAgeInNanos= */ TimeUnit.SECONDS.toNanos(300), /* maxAgeInNanos= */ TimeUnit.SECONDS.toNanos(300),
/* staleAgeInNanos= */ TimeUnit.SECONDS.toNanos(300), /* staleAgeInNanos= */ TimeUnit.SECONDS.toNanos(300),
/* cacheSizeBytes= */ 1000, /* cacheSizeBytes= */ 1000,

6
rls/src/test/java/io/grpc/rls/RlsRequestFactoryTest.java
View File

@ -65,9 +65,9 @@ public class RlsRequestFactoryTest {
ExtraKeys.create(null, null, null), ExtraKeys.create(null, null, null),
ImmutableMap.of("const-key-4", "const-value-4"))), ImmutableMap.of("const-key-4", "const-value-4"))),
/* lookupService= */ "bigtable-rls.googleapis.com", /* lookupService= */ "bigtable-rls.googleapis.com",
/* lookupServiceTimeoutInMillis= */ TimeUnit.SECONDS.toMillis(2), /* lookupServiceTimeoutInNanos= */ TimeUnit.SECONDS.toNanos(2),
/* maxAgeInMillis= */ TimeUnit.SECONDS.toMillis(300), /* maxAgeInNanos= */ TimeUnit.SECONDS.toNanos(300),
/* staleAgeInMillis= */ TimeUnit.SECONDS.toMillis(240), /* staleAgeInNanos= */ TimeUnit.SECONDS.toNanos(240),
/* cacheSizeBytes= */ 1000, /* cacheSizeBytes= */ 1000,
/* defaultTarget= */ "us_east_1.cloudbigtable.googleapis.com"); /* defaultTarget= */ "us_east_1.cloudbigtable.googleapis.com");