From 8473e270eb79d23378e2c96e3d9c9a8e9c91f066 Mon Sep 17 00:00:00 2001 From: Terry Wilson Date: Mon, 10 Oct 2022 15:06:59 -0700 Subject: [PATCH] xds: CdsLoadBalancer2 to use acceptResolvedAddresses (#9570) xds: CdsLoadBalancer2 to use acceptResolvedAddresses Moving over from handleResolvedAddresses() as part of an API migration. --- xds/src/main/java/io/grpc/xds/CdsLoadBalancer2.java | 5 +++-- xds/src/test/java/io/grpc/xds/CdsLoadBalancer2Test.java | 2 +- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/xds/src/main/java/io/grpc/xds/CdsLoadBalancer2.java b/xds/src/main/java/io/grpc/xds/CdsLoadBalancer2.java index afbb21008e..0db0f59eaa 100644 --- a/xds/src/main/java/io/grpc/xds/CdsLoadBalancer2.java +++ b/xds/src/main/java/io/grpc/xds/CdsLoadBalancer2.java @@ -79,9 +79,9 @@ final class CdsLoadBalancer2 extends LoadBalancer { } @Override - public void handleResolvedAddresses(ResolvedAddresses resolvedAddresses) { + public boolean acceptResolvedAddresses(ResolvedAddresses resolvedAddresses) { if (this.resolvedAddresses != null) { - return; + return true; } logger.log(XdsLogLevel.DEBUG, "Received resolution result: {0}", resolvedAddresses); this.resolvedAddresses = resolvedAddresses; @@ -91,6 +91,7 @@ final class CdsLoadBalancer2 extends LoadBalancer { logger.log(XdsLogLevel.INFO, "Config: {0}", config); cdsLbState = new CdsLbState(config.name); cdsLbState.start(); + return true; } @Override diff --git a/xds/src/test/java/io/grpc/xds/CdsLoadBalancer2Test.java b/xds/src/test/java/io/grpc/xds/CdsLoadBalancer2Test.java index 23c3c4dba7..60ddb9f3da 100644 --- a/xds/src/test/java/io/grpc/xds/CdsLoadBalancer2Test.java +++ b/xds/src/test/java/io/grpc/xds/CdsLoadBalancer2Test.java @@ -135,7 +135,7 @@ public class CdsLoadBalancer2Test { lbRegistry.register(new FakeLoadBalancerProvider("least_request_experimental", new LeastRequestLoadBalancerProvider())); loadBalancer = new CdsLoadBalancer2(helper, lbRegistry); - loadBalancer.handleResolvedAddresses( + loadBalancer.acceptResolvedAddresses( ResolvedAddresses.newBuilder() .setAddresses(Collections.emptyList()) .setAttributes(