From 8b716a2f18eb1f9e4db24e386cc67b70a932a6f1 Mon Sep 17 00:00:00 2001
From: Shohei Kamimori <jyane.kstm@gmail.com>
Date: Fri, 8 Dec 2017 02:07:31 +0900
Subject: [PATCH] netty: add test for NettyServerBuilder

---
 .../io/grpc/netty/NettyServerBuilderTest.java | 57 +++++++++++++++++--
 1 file changed, 52 insertions(+), 5 deletions(-)

diff --git a/netty/src/test/java/io/grpc/netty/NettyServerBuilderTest.java b/netty/src/test/java/io/grpc/netty/NettyServerBuilderTest.java
index 4fe6e346da..bde1b7f28c 100644
--- a/netty/src/test/java/io/grpc/netty/NettyServerBuilderTest.java
+++ b/netty/src/test/java/io/grpc/netty/NettyServerBuilderTest.java
@@ -36,9 +36,10 @@ public class NettyServerBuilderTest {
 
   @Rule public final ExpectedException thrown = ExpectedException.none();
 
+  private NettyServerBuilder builder = NettyServerBuilder.forPort(8080);
+
   @Test
   public void sslContextCanBeNull() {
-    NettyServerBuilder builder = NettyServerBuilder.forPort(8080);
     builder.sslContext(null);
   }
 
@@ -47,8 +48,6 @@ public class NettyServerBuilderTest {
     SslContext sslContext = mock(SslContext.class);
     when(sslContext.isClient()).thenReturn(true);
 
-    NettyServerBuilder builder = NettyServerBuilder.forPort(8080);
-
     thrown.expect(IllegalArgumentException.class);
     thrown.expectMessage("Client SSL context can not be used for server");
     builder.sslContext(sslContext);
@@ -59,7 +58,7 @@ public class NettyServerBuilderTest {
     thrown.expect(IllegalArgumentException.class);
     thrown.expectMessage("keepalive time must be positive");
 
-    NettyServerBuilder.forPort(8080).keepAliveTime(-10L, TimeUnit.HOURS);
+    builder.keepAliveTime(-10L, TimeUnit.HOURS);
   }
 
   @Test
@@ -67,6 +66,54 @@ public class NettyServerBuilderTest {
     thrown.expect(IllegalArgumentException.class);
     thrown.expectMessage("keepalive timeout must be positive");
 
-    NettyServerBuilder.forPort(8080).keepAliveTimeout(-10L, TimeUnit.HOURS);
+    builder.keepAliveTimeout(-10L, TimeUnit.HOURS);
+  }
+
+  @Test
+  public void failIfMaxConcurrentCallsPerConnectionNegative() {
+    thrown.expect(IllegalArgumentException.class);
+    thrown.expectMessage("max must be positive");
+
+    builder.maxConcurrentCallsPerConnection(0);
+  }
+
+  @Test
+  public void failIfMaxHeaderListSizeNegative() {
+    thrown.expect(IllegalArgumentException.class);
+    thrown.expectMessage("maxHeaderListSize must be > 0");
+
+    builder.maxHeaderListSize(0);
+  }
+
+  @Test
+  public void failIfMaxConnectionIdleNegative() {
+    thrown.expect(IllegalArgumentException.class);
+    thrown.expectMessage("max connection idle must be positive");
+
+    builder.maxConnectionIdle(-1, TimeUnit.HOURS);
+  }
+
+  @Test
+  public void failIfMaxConnectionAgeNegative() {
+    thrown.expect(IllegalArgumentException.class);
+    thrown.expectMessage("max connection age must be positive");
+
+    builder.maxConnectionAge(-1, TimeUnit.HOURS);
+  }
+
+  @Test
+  public void failIfMaxConnectionAgeGraceNegative() {
+    thrown.expect(IllegalArgumentException.class);
+    thrown.expectMessage("max connection age grace must be non-negative");
+
+    builder.maxConnectionAgeGrace(-1, TimeUnit.HOURS);
+  }
+
+  @Test
+  public void failIfPermitKeepAliveTimeNegative() {
+    thrown.expect(IllegalArgumentException.class);
+    thrown.expectMessage("permit keepalive time must be non-negative");
+
+    builder.permitKeepAliveTime(-1, TimeUnit.HOURS);
   }
 }