From 9148095df4f9d8c0af3f6e9f960bc5bc0822e119 Mon Sep 17 00:00:00 2001 From: Benjamin Peterson Date: Wed, 7 Jun 2023 21:50:43 -0700 Subject: [PATCH] netty: simplify SendGrpcFrameCommand DefaultByteBufHolder has many perfectly good implementations. It should be enought to implement the replace method. --- .../io/grpc/netty/SendGrpcFrameCommand.java | 33 ++----------------- 1 file changed, 2 insertions(+), 31 deletions(-) diff --git a/netty/src/main/java/io/grpc/netty/SendGrpcFrameCommand.java b/netty/src/main/java/io/grpc/netty/SendGrpcFrameCommand.java index 4624dc8783..9c2507e368 100644 --- a/netty/src/main/java/io/grpc/netty/SendGrpcFrameCommand.java +++ b/netty/src/main/java/io/grpc/netty/SendGrpcFrameCommand.java @@ -55,37 +55,8 @@ final class SendGrpcFrameCommand extends DefaultByteBufHolder implements WriteQu } @Override - public ByteBufHolder copy() { - return new SendGrpcFrameCommand(stream, content().copy(), endStream); - } - - @Override - public ByteBufHolder duplicate() { - return new SendGrpcFrameCommand(stream, content().duplicate(), endStream); - } - - @Override - public SendGrpcFrameCommand retain() { - super.retain(); - return this; - } - - @Override - public SendGrpcFrameCommand retain(int increment) { - super.retain(increment); - return this; - } - - @Override - public SendGrpcFrameCommand touch() { - super.touch(); - return this; - } - - @Override - public SendGrpcFrameCommand touch(Object hint) { - super.touch(hint); - return this; + public ByteBufHolder replace(ByteBuf content) { + return new SendGrpcFrameCommand(stream, content, endStream); } @Override