grpc
/
grpc-java
mirror of https://github.com/grpc/grpc-java.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Disable Netty eventloop graceful termination 

When shutting down the Netty event loop, we have already guaranteed that
all users of it are no longer running. Doing a shutdownGracefully is
just delaying graceful JVM termination by two seconds. This is very
noticeable for short-lived processes, like our integration tests.

We would actually also prefer to shutdown quickly and get a
RejectedExecutionException for any newly queued tasks, because that
would be a legitimate bug.

shutdown() is deprecated, thus we do shutdownGracefully with a timeout
of 0.
This commit is contained in:
Eric Anderson 2015-05-15 18:10:25 -07:00
parent 65291321d8
commit 98c6355079
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
netty/src/main/java/io/grpc/transport/netty/Utils.java
View File

@ -55,6 +55,7 @@ import java.util.Map;
import java.util.concurrent.ExecutorService; import java.util.concurrent.ExecutorService;
import java.util.concurrent.Executors; import java.util.concurrent.Executors;
import java.util.concurrent.ThreadFactory; import java.util.concurrent.ThreadFactory;
import java.util.concurrent.TimeUnit;
/** /**
* Common utility methods. * Common utility methods.
@ -198,7 +199,7 @@ class Utils {
@Override @Override
public void close(EventLoopGroup instance) { public void close(EventLoopGroup instance) {
instance.shutdownGracefully(); instance.shutdownGracefully(0, 0, TimeUnit.SECONDS);
} }
@Override @Override