From 9f78b2bd3c49b65f91f5bf82856a7bc56f1a8d23 Mon Sep 17 00:00:00 2001 From: Larry Safran Date: Thu, 20 Jul 2023 15:32:35 -0700 Subject: [PATCH] Revert "Change the default for staleAge to be maxAge - 1 minute rather than maxage (unless maxAge is < 2 minutes) for the RLS configuration from proto. (#10397)" (#10399) This reverts commit 56d1c42c8049bd0d658b746fffba70dd6ee9308d. --- rls/src/main/java/io/grpc/rls/RlsProtoConverters.java | 2 +- rls/src/test/java/io/grpc/rls/RlsProtoConvertersTest.java | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/rls/src/main/java/io/grpc/rls/RlsProtoConverters.java b/rls/src/main/java/io/grpc/rls/RlsProtoConverters.java index 21168bce3b..cd164f5e2a 100644 --- a/rls/src/main/java/io/grpc/rls/RlsProtoConverters.java +++ b/rls/src/main/java/io/grpc/rls/RlsProtoConverters.java @@ -153,7 +153,7 @@ final class RlsProtoConverters { maxAge = MAX_AGE_NANOS; } if (staleAge == null) { - staleAge = maxAge >= MINUTES.toNanos(2) ? maxAge - MINUTES.toNanos(1) : maxAge; + staleAge = MAX_AGE_NANOS; } maxAge = Math.min(maxAge, MAX_AGE_NANOS); staleAge = Math.min(staleAge, maxAge); diff --git a/rls/src/test/java/io/grpc/rls/RlsProtoConvertersTest.java b/rls/src/test/java/io/grpc/rls/RlsProtoConvertersTest.java index 4cf7ac4fbb..98b7101fd5 100644 --- a/rls/src/test/java/io/grpc/rls/RlsProtoConvertersTest.java +++ b/rls/src/test/java/io/grpc/rls/RlsProtoConvertersTest.java @@ -354,7 +354,7 @@ public class RlsProtoConvertersTest { .lookupService("service1") .lookupServiceTimeoutInNanos(TimeUnit.SECONDS.toNanos(10)) .maxAgeInNanos(TimeUnit.MINUTES.toNanos(5)) - .staleAgeInNanos(TimeUnit.MINUTES.toNanos(4)) + .staleAgeInNanos(TimeUnit.MINUTES.toNanos(5)) .cacheSizeBytes(5 * 1024 * 1024) .defaultTarget("us_east_1.cloudbigtable.googleapis.com") .build();