From a14689eff8bd0b63a2b15423c56dc455dc9c967e Mon Sep 17 00:00:00 2001 From: ZHANG Dapeng Date: Mon, 20 Mar 2017 11:54:57 -0700 Subject: [PATCH] netty: move startWriteQueue right after channel is constructed Now that the commit 65e4d9f has split the channel instantiation and `connect()`, we can `startWriteQueue()` even earlier. --- netty/src/main/java/io/grpc/netty/NettyClientTransport.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/netty/src/main/java/io/grpc/netty/NettyClientTransport.java b/netty/src/main/java/io/grpc/netty/NettyClientTransport.java index 0633f39fb0..8ec469a834 100644 --- a/netty/src/main/java/io/grpc/netty/NettyClientTransport.java +++ b/netty/src/main/java/io/grpc/netty/NettyClientTransport.java @@ -190,6 +190,8 @@ class NettyClientTransport implements ConnectionClientTransport { */ b.handler(negotiationHandler); channel = b.register().channel(); + // Start the write queue as soon as the channel is constructed + handler.startWriteQueue(channel); // Start the connection operation to the server. channel.connect(address).addListener(new ChannelFutureListener() { @Override @@ -206,8 +208,6 @@ class NettyClientTransport implements ConnectionClientTransport { } } }); - // Start the write queue as soon as the channel is constructed - handler.startWriteQueue(channel); // This write will have no effect, yet it will only complete once the negotiationHandler // flushes any pending writes. channel.write(NettyClientHandler.NOOP_MESSAGE).addListener(new ChannelFutureListener() {