all: fix usages of any(<Primitive>.class) matchers

In Mockito 2, if a method expects a primitive type, but an any(<Primitive>.class) matcher is used in its place, it will throw an error. To prepare for this upcoming breakage, change
all existing any(<Primitive>.class) matchers to use the correct any<Primitive>() matcher.
This commit is contained in:
Tim van der Lippe 2019-02-04 17:01:00 +00:00 committed by Carl Mastrangelo
parent 0dbab26bb4
commit a31473ef20
6 changed files with 68 additions and 43 deletions

View File

@ -26,6 +26,8 @@ import static org.junit.Assert.assertTrue;
import static org.junit.Assert.fail;
import static org.mockito.AdditionalAnswers.delegatesTo;
import static org.mockito.Matchers.any;
import static org.mockito.Matchers.anyBoolean;
import static org.mockito.Matchers.anyInt;
import static org.mockito.Matchers.same;
import static org.mockito.Mockito.doAnswer;
import static org.mockito.Mockito.mock;
@ -390,7 +392,7 @@ public class AbstractClientStreamTest {
assertSame(Status.Code.DATA_LOSS, statusCaptor.getValue().getCode());
assertEquals("data___loss", statusCaptor.getValue().getDescription());
}
@Test
public void getRequest() {
AbstractClientStream.Sink sink = mock(AbstractClientStream.Sink.class);
@ -414,8 +416,7 @@ public class AbstractClientStreamTest {
assertTrue(payloadCaptor.getValue() != null);
// GET requests don't have BODY.
verify(sink, never())
.writeFrame(
any(WritableBuffer.class), any(Boolean.class), any(Boolean.class), any(Integer.class));
.writeFrame(any(WritableBuffer.class), anyBoolean(), anyBoolean(), anyInt());
assertThat(tracer.nextOutboundEvent()).isEqualTo("outboundMessage(0)");
assertThat(tracer.nextOutboundEvent()).matches("outboundMessageSent\\(0, [0-9]+, [0-9]+\\)");
assertNull(tracer.nextOutboundEvent());

View File

@ -20,6 +20,8 @@ import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertNull;
import static org.mockito.AdditionalAnswers.delegatesTo;
import static org.mockito.Matchers.any;
import static org.mockito.Matchers.anyBoolean;
import static org.mockito.Matchers.anyInt;
import static org.mockito.Matchers.eq;
import static org.mockito.Matchers.same;
import static org.mockito.Mockito.mock;
@ -270,8 +272,7 @@ public class AbstractServerStreamTest {
stream.writeMessage(new ByteArrayInputStream(new byte[]{}));
verify(sink, never())
.writeFrame(any(WritableBuffer.class), any(Boolean.class), any(Integer.class));
verify(sink, never()).writeFrame(any(WritableBuffer.class), anyBoolean(), anyInt());
}
@Test

View File

@ -23,6 +23,7 @@ import static org.junit.Assert.assertNotNull;
import static org.junit.Assert.assertNull;
import static org.junit.Assert.assertTrue;
import static org.mockito.Matchers.any;
import static org.mockito.Matchers.anyInt;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.when;
@ -178,12 +179,13 @@ public class ProxyDetectorImplTest {
proxyUser,
proxyPassword.toCharArray());
when(authenticator.requestPasswordAuthentication(
any(String.class),
any(InetAddress.class),
any(Integer.class),
any(String.class),
any(String.class),
any(String.class))).thenReturn(auth);
any(String.class),
any(InetAddress.class),
anyInt(),
any(String.class),
any(String.class),
any(String.class)))
.thenReturn(auth);
when(proxySelector.select(any(URI.class))).thenReturn(ImmutableList.of(proxy));
ProxyParameters detected = proxyDetector.proxyFor(destination);

View File

@ -30,6 +30,7 @@ import static org.junit.Assert.assertNotNull;
import static org.junit.Assert.assertNull;
import static org.junit.Assert.assertTrue;
import static org.mockito.Matchers.any;
import static org.mockito.Matchers.anyBoolean;
import static org.mockito.Matchers.eq;
import static org.mockito.Matchers.isA;
import static org.mockito.Matchers.same;
@ -437,8 +438,7 @@ public class NettyClientStreamTest extends NettyStreamTestBase<NettyClientStream
Mockito.reset(writeQueue);
ChannelPromise completedPromise = new DefaultChannelPromise(channel)
.setSuccess();
when(writeQueue.enqueue(any(QueuedCommand.class), any(boolean.class)))
.thenReturn(completedPromise);
when(writeQueue.enqueue(any(QueuedCommand.class), anyBoolean())).thenReturn(completedPromise);
stream = new NettyClientStream(
new TransportStateImpl(handler, DEFAULT_MAX_MESSAGE_SIZE),

View File

@ -37,6 +37,8 @@ import static org.junit.Assert.assertSame;
import static org.junit.Assert.assertTrue;
import static org.mockito.AdditionalAnswers.delegatesTo;
import static org.mockito.Matchers.any;
import static org.mockito.Matchers.anyInt;
import static org.mockito.Matchers.anyLong;
import static org.mockito.Matchers.anyString;
import static org.mockito.Matchers.eq;
import static org.mockito.Mockito.atLeastOnce;
@ -690,9 +692,13 @@ public class NettyServerHandlerTest extends NettyHandlerTestBase<NettyServerHand
fakeClock().forwardTime(20, TimeUnit.MINUTES);
// GO_AWAY not sent yet
verifyWrite(never()).writeGoAway(
any(ChannelHandlerContext.class), any(Integer.class), any(Long.class), any(ByteBuf.class),
any(ChannelPromise.class));
verifyWrite(never())
.writeGoAway(
any(ChannelHandlerContext.class),
anyInt(),
anyLong(),
any(ByteBuf.class),
any(ChannelPromise.class));
assertTrue(channel().isOpen());
}
@ -770,9 +776,13 @@ public class NettyServerHandlerTest extends NettyHandlerTestBase<NettyServerHand
fakeClock().forwardNanos(maxConnectionIdleInNanos);
// GO_AWAY not sent when active
verifyWrite(never()).writeGoAway(
any(ChannelHandlerContext.class), any(Integer.class), any(Long.class), any(ByteBuf.class),
any(ChannelPromise.class));
verifyWrite(never())
.writeGoAway(
any(ChannelHandlerContext.class),
anyInt(),
anyLong(),
any(ByteBuf.class),
any(ChannelPromise.class));
assertTrue(channel().isOpen());
channelRead(rstStreamFrame(STREAM_ID, (int) Http2Error.CANCEL.code()));
@ -810,9 +820,13 @@ public class NettyServerHandlerTest extends NettyHandlerTestBase<NettyServerHand
fakeClock().forwardNanos(maxConnectionIdleInNanos);
// GO_AWAY not sent when active
verifyWrite(never()).writeGoAway(
any(ChannelHandlerContext.class), any(Integer.class), any(Long.class), any(ByteBuf.class),
any(ChannelPromise.class));
verifyWrite(never())
.writeGoAway(
any(ChannelHandlerContext.class),
anyInt(),
anyLong(),
any(ByteBuf.class),
any(ChannelPromise.class));
assertTrue(channel().isOpen());
channelRead(rstStreamFrame(STREAM_ID, (int) Http2Error.CANCEL.code()));
@ -849,9 +863,13 @@ public class NettyServerHandlerTest extends NettyHandlerTestBase<NettyServerHand
fakeClock().forwardTime(20, TimeUnit.MINUTES);
// GO_AWAY not sent yet
verifyWrite(never()).writeGoAway(
any(ChannelHandlerContext.class), any(Integer.class), any(Long.class), any(ByteBuf.class),
any(ChannelPromise.class));
verifyWrite(never())
.writeGoAway(
any(ChannelHandlerContext.class),
anyInt(),
anyLong(),
any(ByteBuf.class),
any(ChannelPromise.class));
assertTrue(channel().isOpen());
}

View File

@ -28,6 +28,7 @@ import static org.junit.Assert.assertSame;
import static org.junit.Assert.assertTrue;
import static org.junit.Assert.fail;
import static org.mockito.Matchers.any;
import static org.mockito.Matchers.anyLong;
import static org.mockito.Matchers.eq;
import static org.mockito.Matchers.isNull;
import static org.mockito.Matchers.same;
@ -1004,15 +1005,16 @@ public final class BinlogHelperTest {
});
call.start(mockListener, new Metadata());
ArgumentCaptor<Duration> callOptTimeoutCaptor = ArgumentCaptor.forClass(Duration.class);
verify(mockSinkWriter).logClientHeader(
any(Integer.class),
any(String.class),
any(String.class),
callOptTimeoutCaptor.capture(),
any(Metadata.class),
any(GrpcLogEntry.Logger.class),
any(Long.class),
any(SocketAddress.class));
verify(mockSinkWriter)
.logClientHeader(
anyLong(),
any(String.class),
any(String.class),
callOptTimeoutCaptor.capture(),
any(Metadata.class),
any(GrpcLogEntry.Logger.class),
anyLong(),
any(SocketAddress.class));
Duration timeout = callOptTimeoutCaptor.getValue();
assertThat(TimeUnit.SECONDS.toNanos(1) - Durations.toNanos(timeout))
.isAtMost(TimeUnit.MILLISECONDS.toNanos(250));
@ -1060,15 +1062,16 @@ public final class BinlogHelperTest {
ClientCall.Listener<byte[]> mockListener = mock(ClientCall.Listener.class);
callFuture.get().start(mockListener, new Metadata());
ArgumentCaptor<Duration> callOptTimeoutCaptor = ArgumentCaptor.forClass(Duration.class);
verify(mockSinkWriter).logClientHeader(
any(Integer.class),
any(String.class),
any(String.class),
callOptTimeoutCaptor.capture(),
any(Metadata.class),
any(GrpcLogEntry.Logger.class),
any(Long.class),
any(SocketAddress.class));
verify(mockSinkWriter)
.logClientHeader(
anyLong(),
any(String.class),
any(String.class),
callOptTimeoutCaptor.capture(),
any(Metadata.class),
any(GrpcLogEntry.Logger.class),
anyLong(),
any(SocketAddress.class));
Duration timeout = callOptTimeoutCaptor.getValue();
assertThat(TimeUnit.SECONDS.toNanos(1) - Durations.toNanos(timeout))
.isAtMost(TimeUnit.MILLISECONDS.toNanos(250));