xds,googleapis: Default GRPC_EXPERIMENTAL_XDS_FEDERATION to true (#10093)

This commit is contained in:
Terry Wilson 2023-04-24 11:01:32 -07:00 committed by GitHub
parent 68b67b616e
commit a384c16e8c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 5 additions and 4 deletions

View File

@ -66,8 +66,8 @@ final class GoogleCloudToProdNameResolver extends NameResolver {
|| System.getProperty("io.grpc.xds.bootstrapConfig") != null;
@VisibleForTesting
static boolean enableFederation =
!Strings.isNullOrEmpty(System.getenv("GRPC_EXPERIMENTAL_XDS_FEDERATION"))
&& Boolean.parseBoolean(System.getenv("GRPC_EXPERIMENTAL_XDS_FEDERATION"));
Strings.isNullOrEmpty(System.getenv("GRPC_EXPERIMENTAL_XDS_FEDERATION"))
|| Boolean.parseBoolean(System.getenv("GRPC_EXPERIMENTAL_XDS_FEDERATION"));
private static final String serverUriOverride =
System.getenv("GRPC_TEST_ONLY_GOOGLE_C2P_RESOLVER_TRAFFIC_DIRECTOR_URI");

View File

@ -159,6 +159,7 @@ public class GoogleCloudToProdNameResolverTest {
public void hasProvidedBootstrapDelegateToDns() {
GoogleCloudToProdNameResolver.isOnGcp = true;
GoogleCloudToProdNameResolver.xdsBootstrapProvided = true;
GoogleCloudToProdNameResolver.enableFederation = false;
createResolver();
resolver.start(mockListener);
assertThat(delegatedResolver.keySet()).containsExactly("dns");

View File

@ -57,8 +57,8 @@ class BootstrapperImpl extends Bootstrapper {
// Feature-gating environment variables.
static boolean enableFederation =
!Strings.isNullOrEmpty(System.getenv("GRPC_EXPERIMENTAL_XDS_FEDERATION"))
&& Boolean.parseBoolean(System.getenv("GRPC_EXPERIMENTAL_XDS_FEDERATION"));
Strings.isNullOrEmpty(System.getenv("GRPC_EXPERIMENTAL_XDS_FEDERATION"))
|| Boolean.parseBoolean(System.getenv("GRPC_EXPERIMENTAL_XDS_FEDERATION"));
// Client features.
@VisibleForTesting