grpc
/
grpc-java
mirror of https://github.com/grpc/grpc-java.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

context: don't log to logger in static initialization. (#2581)

This commit is contained in:
Kun Zhang 2017-01-10 11:10:15 -08:00 committed by GitHub
parent de10b94128
commit a3a5420922
1 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
context/src/main/java/io/grpc/Context.java
View File

@ -131,7 +131,14 @@ public class Context {
Class<?> clazz = Class.forName("io.grpc.override.ContextStorageOverride");
newStorage = (Storage) clazz.getConstructor().newInstance();
} catch (ClassNotFoundException e) {
log.log(Level.FINE, "Storage override doesn't exist. Using default.", e);
if (log.isLoggable(Level.FINE)) {
// Avoid writing to logger because custom log handlers may try to use Context, which is
// problemantic (e.g., NullPointerException) because the Context class has not done loading
// at this point. The caveat is that in environments stderr may be disabled, thus this
// message would go nowhere.
System.err.println("io.grpc.Context: Storage override doesn't exist. Using default.");
e.printStackTrace();
}
newStorage = new ThreadLocalContextStorage();
} catch (Exception e) {
error = e;