grpc
/
grpc-java
mirror of https://github.com/grpc/grpc-java.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

services: log an error to java logger when health-check disabled. (#5261) 

This is required by the spec:
https://github.com/grpc/proposal/blob/master/A17-client-side-health-checking.md
This commit is contained in:
Kun Zhang 2019-01-22 15:17:56 -08:00 committed by GitHub
parent 985bf0aa74
commit abdae25c8d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
services/src/main/java/io/grpc/services/HealthCheckingLoadBalancerFactory.java
View File

@ -56,6 +56,8 @@ import java.util.List;
import java.util.Map; import java.util.Map;
import java.util.concurrent.ScheduledExecutorService; import java.util.concurrent.ScheduledExecutorService;
import java.util.concurrent.TimeUnit; import java.util.concurrent.TimeUnit;
import java.util.logging.Level;
import java.util.logging.Logger;
import javax.annotation.Nullable; import javax.annotation.Nullable;
/** /**
@ -69,6 +71,8 @@ import javax.annotation.Nullable;
final class HealthCheckingLoadBalancerFactory extends Factory { final class HealthCheckingLoadBalancerFactory extends Factory {
private static final Attributes.Key<HealthCheckState> KEY_HEALTH_CHECK_STATE = private static final Attributes.Key<HealthCheckState> KEY_HEALTH_CHECK_STATE =
Attributes.Key.create("io.grpc.services.HealthCheckingLoadBalancerFactory.healthCheckState"); Attributes.Key.create("io.grpc.services.HealthCheckingLoadBalancerFactory.healthCheckState");
private static final Logger logger =
Logger.getLogger(HealthCheckingLoadBalancerFactory.class.getName());
private final Factory delegateFactory; private final Factory delegateFactory;
private final BackoffPolicy.Provider backoffPolicyProvider; private final BackoffPolicy.Provider backoffPolicyProvider;
@ -421,6 +425,9 @@ final class HealthCheckingLoadBalancerFactory extends Factory {
void handleStreamClosed(Status status) { void handleStreamClosed(Status status) {
if (Objects.equal(status.getCode(), Code.UNIMPLEMENTED)) { if (Objects.equal(status.getCode(), Code.UNIMPLEMENTED)) {
disabled = true; disabled = true;
logger.log(
Level.SEVERE, "Health-check with {0} is disabled. Server returned: {1}",
new Object[] {subchannel.getAllAddresses(), status});
subchannelLogger.log(ChannelLogLevel.ERROR, "Health-check disabled: {0}", status); subchannelLogger.log(ChannelLogLevel.ERROR, "Health-check disabled: {0}", status);
subchannelLogger.log(ChannelLogLevel.INFO, "{0} (no health-check)", rawState); subchannelLogger.log(ChannelLogLevel.INFO, "{0} (no health-check)", rawState);
gotoState(rawState); gotoState(rawState);