From ad370d807b316cd5bb8b2211b29cb372ba6320c8 Mon Sep 17 00:00:00 2001 From: zpencer Date: Fri, 18 May 2018 12:54:17 -0700 Subject: [PATCH] services: fix lint on toString (#4481) BinlogHelper does not override toString so print something else that is more descriptive. --- .../java/io/grpc/services/BinlogHelper.java | 18 ++++++++++++------ 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/services/src/main/java/io/grpc/services/BinlogHelper.java b/services/src/main/java/io/grpc/services/BinlogHelper.java index 0736fd1fd1..faead35bd2 100644 --- a/services/src/main/java/io/grpc/services/BinlogHelper.java +++ b/services/src/main/java/io/grpc/services/BinlogHelper.java @@ -404,27 +404,33 @@ final class BinlogHelper { } if (methodOrSvc.equals("*")) { if (globalLog != null) { - logger.log(Level.SEVERE, "Ignoring duplicate entry: " + configuration); + logger.log(Level.SEVERE, "Ignoring duplicate entry: {0}", configuration); continue; } globalLog = binLog; - logger.info("Global binlog: " + globalLog); + logger.log(Level.INFO, "Global binlog: {0}", binlogOptionStr); } else if (isServiceGlob(methodOrSvc)) { String service = MethodDescriptor.extractFullServiceName(methodOrSvc); if (perServiceLogs.containsKey(service)) { - logger.log(Level.SEVERE, "Ignoring duplicate entry: " + configuration); + logger.log(Level.SEVERE, "Ignoring duplicate entry: {0}", configuration); continue; } perServiceLogs.put(service, binLog); - logger.info(String.format("Service binlog: service=%s log=%s", service, binLog)); + logger.log( + Level.INFO, + "Service binlog: service={0} config={1}", + new Object[] {service, binlogOptionStr}); } else { // assume fully qualified method name if (perMethodLogs.containsKey(methodOrSvc)) { - logger.log(Level.SEVERE, "Ignoring duplicate entry: " + configuration); + logger.log(Level.SEVERE, "Ignoring duplicate entry: {0}", configuration); continue; } perMethodLogs.put(methodOrSvc, binLog); - logger.info(String.format("Method binlog: method=%s log=%s", methodOrSvc, binLog)); + logger.log( + Level.INFO, + "Method binlog: method={0} config={1}", + new Object[] {methodOrSvc, binlogOptionStr}); } } }