mirror of https://github.com/grpc/grpc-java.git
xds: Enable least request by default (#12054)
Enable least request by default. It has seen good testing by users and behaved as expected. Fixes #11996
This commit is contained in:
parent
59adeb9d47
commit
b089761486
|
|
@ -60,7 +60,8 @@ class XdsClusterResource extends XdsResourceType<CdsUpdate> {
|
||||||
static boolean enableLeastRequest =
|
static boolean enableLeastRequest =
|
||||||
!Strings.isNullOrEmpty(System.getenv("GRPC_EXPERIMENTAL_ENABLE_LEAST_REQUEST"))
|
!Strings.isNullOrEmpty(System.getenv("GRPC_EXPERIMENTAL_ENABLE_LEAST_REQUEST"))
|
||||||
? Boolean.parseBoolean(System.getenv("GRPC_EXPERIMENTAL_ENABLE_LEAST_REQUEST"))
|
? Boolean.parseBoolean(System.getenv("GRPC_EXPERIMENTAL_ENABLE_LEAST_REQUEST"))
|
||||||
: Boolean.parseBoolean(System.getProperty("io.grpc.xds.experimentalEnableLeastRequest"));
|
: Boolean.parseBoolean(
|
||||||
|
System.getProperty("io.grpc.xds.experimentalEnableLeastRequest", "true"));
|
||||||
@VisibleForTesting
|
@VisibleForTesting
|
||||||
public static boolean enableSystemRootCerts =
|
public static boolean enableSystemRootCerts =
|
||||||
GrpcUtil.getFlag("GRPC_EXPERIMENTAL_XDS_SYSTEM_ROOT_CERTS", false);
|
GrpcUtil.getFlag("GRPC_EXPERIMENTAL_XDS_SYSTEM_ROOT_CERTS", false);
|
||||||
|
|
|
||||||
|
|
@ -186,7 +186,6 @@ public class GrpcXdsClientImplDataTest {
|
||||||
originalEnableRouteLookup = XdsRouteConfigureResource.enableRouteLookup;
|
originalEnableRouteLookup = XdsRouteConfigureResource.enableRouteLookup;
|
||||||
originalEnableLeastRequest = XdsClusterResource.enableLeastRequest;
|
originalEnableLeastRequest = XdsClusterResource.enableLeastRequest;
|
||||||
originalEnableUseSystemRootCerts = XdsClusterResource.enableSystemRootCerts;
|
originalEnableUseSystemRootCerts = XdsClusterResource.enableSystemRootCerts;
|
||||||
assertThat(originalEnableLeastRequest).isFalse();
|
|
||||||
}
|
}
|
||||||
|
|
||||||
@After
|
@After
|
||||||
|
|
|
||||||
Loading…
Reference in New Issue