all: Bump protobuf to 3.0.2, to fix protoc in CI

protoc no longer builds in 3.0.0 because auto-download of the gmock zip
now fails. 3.0.2 has a fix to autogen:
bba446bbf2

All that was strictly necessary was to update .travis.yml and
buildscripts/, but it helps our sanity to keep the rest of the protobuf
versions in sync. Lite is left on its existing version, because it did
not see a bump of neither the java library nor the protoc plugin.
This commit is contained in:
Eric Anderson 2016-09-27 17:15:12 -07:00
parent 34812835a8
commit b1d72e5c3e
14 changed files with 24 additions and 22 deletions

View File

@ -5,7 +5,7 @@ language: java
env: env:
global: global:
- GRADLE_OPTS=-Xmx512m - GRADLE_OPTS=-Xmx512m
- PROTOBUF_VERSION=3.0.0 - PROTOBUF_VERSION=3.0.2
- LDFLAGS=-L/tmp/protobuf/lib - LDFLAGS=-L/tmp/protobuf/lib
- CXXFLAGS=-I/tmp/protobuf/include - CXXFLAGS=-I/tmp/protobuf/include
- LD_LIBRARY_PATH=/tmp/protobuf/lib - LD_LIBRARY_PATH=/tmp/protobuf/lib

View File

@ -27,13 +27,13 @@ This section is only necessary if you are making changes to the code
generation. Most users only need to use `skipCodegen=true` as discussed above. generation. Most users only need to use `skipCodegen=true` as discussed above.
### Build Protobuf ### Build Protobuf
The codegen plugin is C++ code and requires protobuf 3.0.0. The codegen plugin is C++ code and requires protobuf 3.0.0 or later.
For Linux, Mac and MinGW: For Linux, Mac and MinGW:
``` ```
$ git clone https://github.com/google/protobuf.git $ git clone https://github.com/google/protobuf.git
$ cd protobuf $ cd protobuf
$ git checkout v3.0.0 $ git checkout v3.0.2
$ ./autogen.sh $ ./autogen.sh
$ ./configure $ ./configure
$ make $ make
@ -72,16 +72,16 @@ When building on Windows and VC++, you need to specify project properties for
Gradle to find protobuf: Gradle to find protobuf:
``` ```
.\gradlew install ^ .\gradlew install ^
-PvcProtobufInclude=C:\path\to\protobuf-3.0.0\src ^ -PvcProtobufInclude=C:\path\to\protobuf-3.0.2\src ^
-PvcProtobufLibs=C:\path\to\protobuf-3.0.0\vsprojects\Release ^ -PvcProtobufLibs=C:\path\to\protobuf-3.0.2\vsprojects\Release ^
-PtargetArch=x86_32 -PtargetArch=x86_32
``` ```
Since specifying those properties every build is bothersome, you can instead Since specifying those properties every build is bothersome, you can instead
create ``<project-root>\gradle.properties`` with contents like: create ``<project-root>\gradle.properties`` with contents like:
``` ```
vcProtobufInclude=C:\\path\\to\\protobuf-3.0.0\\src vcProtobufInclude=C:\\path\\to\\protobuf-3.0.2\\src
vcProtobufLibs=C:\\path\\to\\protobuf-3.0.0\\vsprojects\\Release vcProtobufLibs=C:\\path\\to\\protobuf-3.0.2\\vsprojects\\Release
targetArch=x86_32 targetArch=x86_32
``` ```

View File

@ -87,7 +87,7 @@ For protobuf-based codegen integrated with the Maven build system, you can use
protobuf-java directly, you will be transitively depending on the protobuf-java directly, you will be transitively depending on the
protobuf-java version that grpc depends on. protobuf-java version that grpc depends on.
--> -->
<protocArtifact>com.google.protobuf:protoc:3.0.0:exe:${os.detected.classifier}</protocArtifact> <protocArtifact>com.google.protobuf:protoc:3.0.2:exe:${os.detected.classifier}</protocArtifact>
<pluginId>grpc-java</pluginId> <pluginId>grpc-java</pluginId>
<pluginArtifact>io.grpc:protoc-gen-grpc-java:1.0.0:exe:${os.detected.classifier}</pluginArtifact> <pluginArtifact>io.grpc:protoc-gen-grpc-java:1.0.0:exe:${os.detected.classifier}</pluginArtifact>
</configuration> </configuration>
@ -128,7 +128,7 @@ protobuf {
// The version of protoc must match protobuf-java. If you don't depend on // The version of protoc must match protobuf-java. If you don't depend on
// protobuf-java directly, you will be transitively depending on the // protobuf-java directly, you will be transitively depending on the
// protobuf-java version that grpc depends on. // protobuf-java version that grpc depends on.
artifact = "com.google.protobuf:protoc:3.0.0" artifact = "com.google.protobuf:protoc:3.0.2"
} }
plugins { plugins {
grpc { grpc {

View File

@ -28,7 +28,7 @@ android {
protobuf { protobuf {
protoc { protoc {
artifact = 'com.google.protobuf:protoc:3.0.0' artifact = 'com.google.protobuf:protoc:3.0.2'
} }
plugins { plugins {
grpc { grpc {

View File

@ -62,7 +62,7 @@ subprojects {
javaPluginPath = "$rootDir/compiler/build/exe/java_plugin/$protocPluginBaseName$exeSuffix" javaPluginPath = "$rootDir/compiler/build/exe/java_plugin/$protocPluginBaseName$exeSuffix"
guavaVersion = '19.0' guavaVersion = '19.0'
protobufVersion = '3.0.0' protobufVersion = '3.0.2'
protobufNanoVersion = '3.0.0-alpha-5' protobufNanoVersion = '3.0.0-alpha-5'
configureProtoCompilation = { configureProtoCompilation = {
@ -154,6 +154,8 @@ subprojects {
protobuf: "com.google.protobuf:protobuf-java:${protobufVersion}", protobuf: "com.google.protobuf:protobuf-java:${protobufVersion}",
// swap to ${protobufVersion} after versions align again // swap to ${protobufVersion} after versions align again
protobuf_lite: "com.google.protobuf:protobuf-lite:3.0.1", protobuf_lite: "com.google.protobuf:protobuf-lite:3.0.1",
// swap to ${protobufVersion} after versions align again
protoc_lite: "com.google.protobuf:protoc-gen-javalite:3.0.0",
protobuf_nano: "com.google.protobuf.nano:protobuf-javanano:${protobufNanoVersion}", protobuf_nano: "com.google.protobuf.nano:protobuf-javanano:${protobufNanoVersion}",
protobuf_plugin: 'com.google.protobuf:protobuf-gradle-plugin:0.8.0', protobuf_plugin: 'com.google.protobuf:protobuf-gradle-plugin:0.8.0',
protobuf_util: "com.google.protobuf:protobuf-java-util:${protobufVersion}", protobuf_util: "com.google.protobuf:protobuf-java-util:${protobufVersion}",

View File

@ -14,5 +14,5 @@ set ESCWORKSPACE=%WORKSPACE:\=\\%
echo targetArch=x86_32> gradle.properties echo targetArch=x86_32> gradle.properties
echo failOnWarnings=true>> gradle.properties echo failOnWarnings=true>> gradle.properties
echo vcProtobufLibs=%ESCWORKSPACE%\\grpc-java-helper\\protobuf-3.0.0\\cmake\\build\\Release>> gradle.properties echo vcProtobufLibs=%ESCWORKSPACE%\\grpc-java-helper\\protobuf-%PROTOBUF_VER%\\cmake\\build\\Release>> gradle.properties
echo vcProtobufInclude=%ESCWORKSPACE%\\grpc-java-helper\\protobuf-3.0.0\\cmake\\build\\include>> gradle.properties echo vcProtobufInclude=%ESCWORKSPACE%\\grpc-java-helper\\protobuf-%PROTOBUF_VER%\\cmake\\build\\include>> gradle.properties

View File

@ -4,7 +4,7 @@ REM 7za is in http://www.7-zip.org/a/7z1507-extra.7z
REM Prerequisite: REM Prerequisite:
REM 7za.exe in current directory or PATH REM 7za.exe in current directory or PATH
set PROTOBUF_VER=3.0.0 set PROTOBUF_VER=3.0.2
set CMAKE_NAME=cmake-3.3.2-win32-x86 set CMAKE_NAME=cmake-3.3.2-win32-x86
if not exist "protobuf-%PROTOBUF_VER%\cmake\build\Release\" ( if not exist "protobuf-%PROTOBUF_VER%\cmake\build\Release\" (
@ -25,7 +25,7 @@ set PATH=%PATH%;%cd%\%CMAKE_NAME%\bin
powershell -command "& { iwr https://github.com/google/protobuf/archive/v%PROTOBUF_VER%.zip -OutFile protobuf.zip }" powershell -command "& { iwr https://github.com/google/protobuf/archive/v%PROTOBUF_VER%.zip -OutFile protobuf.zip }"
7za X protobuf.zip 7za X protobuf.zip
del protobuf.zip del protobuf.zip
pushd protobuf-3.0.0\cmake pushd protobuf-%PROTOBUF_VER%\cmake
mkdir build mkdir build
cd build cd build
cmake -Dprotobuf_BUILD_TESTS=OFF -G "Visual Studio %VisualStudioVersion:~0,2%" .. cmake -Dprotobuf_BUILD_TESTS=OFF -G "Visual Studio %VisualStudioVersion:~0,2%" ..

View File

@ -2,7 +2,7 @@ FROM protoc-artifacts:latest
RUN scl enable devtoolset-1.1 'bash -c "cd /protobuf && \ RUN scl enable devtoolset-1.1 'bash -c "cd /protobuf && \
git fetch && \ git fetch && \
git checkout v3.0.0 && \ git checkout v3.0.2 && \
./autogen.sh && \ ./autogen.sh && \
CXXFLAGS=-m32 ./configure --disable-shared --prefix=/protobuf-32 && \ CXXFLAGS=-m32 ./configure --disable-shared --prefix=/protobuf-32 && \
make clean && make -j$(nproc) && make -j$(nproc) install"' make clean && make -j$(nproc) && make -j$(nproc) install"'

View File

@ -163,7 +163,7 @@ protobuf {
if (project.hasProperty('protoc-gen-javalite')) { if (project.hasProperty('protoc-gen-javalite')) {
path = project['protoc-gen-javalite'] path = project['protoc-gen-javalite']
} else { } else {
artifact = "com.google.protobuf:protoc-gen-javalite:${protobufVersion}" artifact = libraries.protoc_lite
} }
} }
grpc { grpc {

View File

@ -27,7 +27,7 @@ android {
protobuf { protobuf {
protoc { protoc {
artifact = 'com.google.protobuf:protoc:3.0.0' artifact = 'com.google.protobuf:protoc:3.0.2'
} }
plugins { plugins {
javalite { javalite {

View File

@ -25,7 +25,7 @@ android {
protobuf { protobuf {
protoc { protoc {
artifact = 'com.google.protobuf:protoc:3.0.0' artifact = 'com.google.protobuf:protoc:3.0.2'
} }
plugins { plugins {
javalite { javalite {

View File

@ -35,7 +35,7 @@ protobuf {
// The version of protoc must match protobuf-java. If you don't depend on // The version of protoc must match protobuf-java. If you don't depend on
// protobuf-java directly, you will be transitively depending on the // protobuf-java directly, you will be transitively depending on the
// protobuf-java version that grpc depends on. // protobuf-java version that grpc depends on.
artifact = 'com.google.protobuf:protoc:3.0.0' artifact = 'com.google.protobuf:protoc:3.0.2'
} }
plugins { plugins {
grpc { grpc {

View File

@ -48,7 +48,7 @@
protobuf-java directly, you will be transitively depending on the protobuf-java directly, you will be transitively depending on the
protobuf-java version that grpc depends on. protobuf-java version that grpc depends on.
--> -->
<protocArtifact>com.google.protobuf:protoc:3.0.0:exe:${os.detected.classifier}</protocArtifact> <protocArtifact>com.google.protobuf:protoc:3.0.2:exe:${os.detected.classifier}</protocArtifact>
<pluginId>grpc-java</pluginId> <pluginId>grpc-java</pluginId>
<pluginArtifact>io.grpc:protoc-gen-grpc-java:${grpc.version}:exe:${os.detected.classifier}</pluginArtifact> <pluginArtifact>io.grpc:protoc-gen-grpc-java:${grpc.version}:exe:${os.detected.classifier}</pluginArtifact>
</configuration> </configuration>

View File

@ -42,7 +42,7 @@ protobuf {
if (project.hasProperty('protoc-gen-javalite')) { if (project.hasProperty('protoc-gen-javalite')) {
path = project['protoc-gen-javalite'] path = project['protoc-gen-javalite']
} else { } else {
artifact = "com.google.protobuf:protoc-gen-javalite:${protobufVersion}" artifact = libraries.protoc_lite
} }
} }
} }