From b2b67458684940d53febd58def63b35de99bea2f Mon Sep 17 00:00:00 2001 From: ZHANG Dapeng Date: Thu, 27 Apr 2017 13:10:53 -0700 Subject: [PATCH] stub: rm redundant call field in StreamObserverToCallListenerAdapter All that the `call` field was used for was to call `request` and nothing else. The `request` can be done by the `adapter` field, so the `call` field is redundant. --- .../main/java/io/grpc/stub/ClientCalls.java | 19 +++++++++++-------- 1 file changed, 11 insertions(+), 8 deletions(-) diff --git a/stub/src/main/java/io/grpc/stub/ClientCalls.java b/stub/src/main/java/io/grpc/stub/ClientCalls.java index 877cc25518..34acfb3b65 100644 --- a/stub/src/main/java/io/grpc/stub/ClientCalls.java +++ b/stub/src/main/java/io/grpc/stub/ClientCalls.java @@ -234,8 +234,11 @@ public final class ClientCalls { private static void asyncUnaryRequestCall( ClientCall call, ReqT param, StreamObserver responseObserver, boolean streamingResponse) { - asyncUnaryRequestCall(call, param, - new StreamObserverToCallListenerAdapter(call, responseObserver, + asyncUnaryRequestCall( + call, + param, + new StreamObserverToCallListenerAdapter( + responseObserver, new CallToStreamObserverAdapter(call), streamingResponse), streamingResponse); @@ -260,8 +263,11 @@ public final class ClientCalls { ClientCall call, StreamObserver responseObserver, boolean streamingResponse) { CallToStreamObserverAdapter adapter = new CallToStreamObserverAdapter(call); - startCall(call, new StreamObserverToCallListenerAdapter( - call, responseObserver, adapter, streamingResponse), streamingResponse); + startCall( + call, + new StreamObserverToCallListenerAdapter( + responseObserver, adapter, streamingResponse), + streamingResponse); return adapter; } @@ -340,18 +346,15 @@ public final class ClientCalls { private static class StreamObserverToCallListenerAdapter extends ClientCall.Listener { - private final ClientCall call; private final StreamObserver observer; private final CallToStreamObserverAdapter adapter; private final boolean streamingResponse; private boolean firstResponseReceived; StreamObserverToCallListenerAdapter( - ClientCall call, StreamObserver observer, CallToStreamObserverAdapter adapter, boolean streamingResponse) { - this.call = call; this.observer = observer; this.streamingResponse = streamingResponse; this.adapter = adapter; @@ -380,7 +383,7 @@ public final class ClientCalls { if (streamingResponse && adapter.autoFlowControlEnabled) { // Request delivery of the next inbound message. - call.request(1); + adapter.request(1); } }