grpc
/
grpc-java
mirror of https://github.com/grpc/grpc-java.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

core: JumpToApplicationThreadServerStreamListener should not close context (#3055) 

Calling CancellableContext#close() multiple times does not cause problems, but is unnecessary here. The return value of getListener() is a ServerStreamListenerImpl, which already calls CancellableContext#cancel() inside of the finally block of ServerStreamListener#closed().
This commit is contained in:
zpencer 2017-06-05 08:37:51 -07:00 committed by GitHub
parent 82fce837e4
commit c0fc6785c1
1 changed files with 0 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
core/src/main/java/io/grpc/internal/ServerImpl.java
View File

@ -585,9 +585,6 @@ public final class ServerImpl extends io.grpc.Server implements WithLogId {
callExecutor.execute(new ContextRunnable(context) { callExecutor.execute(new ContextRunnable(context) {
@Override @Override
public void runInContext() { public void runInContext() {
if (status.isOk()) {
context.cancel(status.getCause());
}
getListener().closed(status); getListener().closed(status);
} }
}); });