From c6bd97245c4bf21e423c5ee7740e9635ab8f1646 Mon Sep 17 00:00:00 2001 From: Jihun Cho Date: Wed, 1 Jul 2020 15:39:13 -0700 Subject: [PATCH] core: disable MigratingThreadDeframer (#7177) --- core/src/main/java/io/grpc/internal/AbstractStream.java | 3 ++- okhttp/src/main/java/io/grpc/okhttp/OkHttpClientStream.java | 4 ---- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/core/src/main/java/io/grpc/internal/AbstractStream.java b/core/src/main/java/io/grpc/internal/AbstractStream.java index 19bdbbc788..e066018249 100644 --- a/core/src/main/java/io/grpc/internal/AbstractStream.java +++ b/core/src/main/java/io/grpc/internal/AbstractStream.java @@ -157,7 +157,8 @@ public abstract class AbstractStream implements Stream { maxMessageSize, statsTraceCtx, transportTracer); - deframer = new MigratingThreadDeframer(this, this, rawDeframer); + // TODO(#7168): use MigratingThreadDeframer when enabling retry doesn't break. + deframer = rawDeframer; } final void optimizeForDirectExecutor() { diff --git a/okhttp/src/main/java/io/grpc/okhttp/OkHttpClientStream.java b/okhttp/src/main/java/io/grpc/okhttp/OkHttpClientStream.java index d4f6ec281a..baf659a627 100644 --- a/okhttp/src/main/java/io/grpc/okhttp/OkHttpClientStream.java +++ b/okhttp/src/main/java/io/grpc/okhttp/OkHttpClientStream.java @@ -101,10 +101,6 @@ class OkHttpClientStream extends AbstractClientStream { transport, initialWindowSize, method.getFullMethodName()); - - // TODO(#7168): fix a potential data race using MigratingThreadDeframer in OkHttp. - // disabling MigratingThreadDeframer in OkHttp due to the race - optimizeForDirectExecutor(); } @Override