From ca12e7a339add0ef48202fb72434b9dc0df41756 Mon Sep 17 00:00:00 2001 From: ZHANG Dapeng Date: Mon, 23 Nov 2020 11:09:28 -0800 Subject: [PATCH] grpclb: improve log for SRV lookup failure (#7647) --- .../src/main/java/io/grpc/grpclb/GrpclbNameResolver.java | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/grpclb/src/main/java/io/grpc/grpclb/GrpclbNameResolver.java b/grpclb/src/main/java/io/grpc/grpclb/GrpclbNameResolver.java index d917d8ed67..89615f1b65 100644 --- a/grpclb/src/main/java/io/grpc/grpclb/GrpclbNameResolver.java +++ b/grpclb/src/main/java/io/grpc/grpclb/GrpclbNameResolver.java @@ -110,9 +110,10 @@ final class GrpclbNameResolver extends DnsNameResolver { } } } - if (srvRecordsException != null - || (balancerAddressesException != null && balancerAddresses.isEmpty())) { - logger.log(Level.FINE, "Balancer resolution failure", srvRecordsException); + if (srvRecordsException != null) { + logger.log(Level.FINE, "SRV lookup failure", srvRecordsException); + } else if (balancerAddressesException != null && balancerAddresses.isEmpty()) { + logger.log(Level.FINE, "SRV-provided hostname lookup failure", balancerAddressesException); } return Collections.unmodifiableList(balancerAddresses); }