From d1146e20155fc01512af39ef50ab7ed44554acc6 Mon Sep 17 00:00:00 2001 From: zpencer Date: Thu, 16 Aug 2018 15:03:41 -0700 Subject: [PATCH] interop-testing: timeoutOnSleepingServer should check that RPC finished (#4766) If the RPC did not finish, then the remaining checks are red herrings. --- .../java/io/grpc/testing/integration/AbstractInteropTest.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/interop-testing/src/main/java/io/grpc/testing/integration/AbstractInteropTest.java b/interop-testing/src/main/java/io/grpc/testing/integration/AbstractInteropTest.java index ec03909f55..587299a5a3 100644 --- a/interop-testing/src/main/java/io/grpc/testing/integration/AbstractInteropTest.java +++ b/interop-testing/src/main/java/io/grpc/testing/integration/AbstractInteropTest.java @@ -1604,7 +1604,7 @@ public abstract class AbstractInteropTest { // This can happen if the stream has already been terminated due to deadline exceeded. } - responseObserver.awaitCompletion(operationTimeoutMillis(), TimeUnit.MILLISECONDS); + assertTrue(responseObserver.awaitCompletion(operationTimeoutMillis(), TimeUnit.MILLISECONDS)); assertEquals(0, responseObserver.getValues().size()); assertEquals(Status.DEADLINE_EXCEEDED.getCode(), Status.fromThrowable(responseObserver.getError()).getCode());