grpc
/
grpc-java
mirror of https://github.com/grpc/grpc-java.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix unused variables 

Unused variables in tests were deleted. The unused variable in Netty
was a future that needed completing; that was a bug.
This commit is contained in:
Eric Anderson 2018-07-04 07:32:57 -07:00 committed by GitHub
parent 02ad99e1f5
commit dd57b667cc
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
core/src/test/java/io/grpc/PickFirstLoadBalancerTest.java
View File

@ -132,7 +132,6 @@ public class PickFirstLoadBalancerTest {
@Test @Test
public void pickAfterResolvedAndChanged() throws Exception { public void pickAfterResolvedAndChanged() throws Exception {
SocketAddress socketAddr = new FakeSocketAddress("newserver"); SocketAddress socketAddr = new FakeSocketAddress("newserver");
List<SocketAddress> newSocketAddresses = Lists.newArrayList(socketAddr);
List<EquivalentAddressGroup> newServers = List<EquivalentAddressGroup> newServers =
Lists.newArrayList(new EquivalentAddressGroup(socketAddr)); Lists.newArrayList(new EquivalentAddressGroup(socketAddr));

4
core/src/test/java/io/grpc/internal/JndiResourceResolverTest.java
View File

@ -19,7 +19,6 @@ package io.grpc.internal;
import static com.google.common.truth.Truth.assertThat; import static com.google.common.truth.Truth.assertThat;
import static org.junit.Assert.assertEquals; import static org.junit.Assert.assertEquals;
import io.grpc.EquivalentAddressGroup;
import io.grpc.internal.DnsNameResolver.AddressResolver; import io.grpc.internal.DnsNameResolver.AddressResolver;
import io.grpc.internal.JndiResourceResolverFactory.JndiResourceResolver; import io.grpc.internal.JndiResourceResolverFactory.JndiResourceResolver;
import io.grpc.internal.JndiResourceResolverFactory.JndiResourceResolver.SrvRecord; import io.grpc.internal.JndiResourceResolverFactory.JndiResourceResolver.SrvRecord;
@ -58,9 +57,8 @@ public class JndiResourceResolverTest {
} }
}; };
JndiResourceResolver resolver = new JndiResourceResolver(); JndiResourceResolver resolver = new JndiResourceResolver();
List<EquivalentAddressGroup> results = null;
try { try {
results = resolver.resolveSrv(addressResolver, "localhost"); resolver.resolveSrv(addressResolver, "localhost");
} catch (javax.naming.CommunicationException e) { } catch (javax.naming.CommunicationException e) {
Assume.assumeNoException(e); Assume.assumeNoException(e);
} catch (javax.naming.NameNotFoundException e) { } catch (javax.naming.NameNotFoundException e) {

1
netty/src/main/java/io/grpc/netty/NettyClientHandler.java
View File

@ -634,6 +634,7 @@ class NettyClientHandler extends AbstractNettyHandler {
return true; return true;
} }
}); });
promise.setSuccess();
} }
/** /**