grpc
/
grpc-java
mirror of https://github.com/grpc/grpc-java.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

okhttp: Fix AsyncSink.close() NPE 

This fixes a regression introduced in e96d0477. The NullPointerException
only happens on client-side when some other error occurred during
handshaking.

I tried to add a test, but SerializingExecutor catches+logs the
exception and the expected behavior in the circumstance is that close()
is a noop. So the NPE was entirely benign other than annoying log
messages.
This commit is contained in:
Eric Anderson 2022-07-06 13:06:01 -07:00
parent 3de7e74c57
commit e767905f4a
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
okhttp/src/main/java/io/grpc/okhttp/AsyncSink.java
View File

@ -208,7 +208,7 @@ final class AsyncSink implements Sink {
@Override @Override
public void run() { public void run() {
try { try {
if (buffer.size() > 0) { if (sink != null && buffer.size() > 0) {
sink.write(buffer, buffer.size()); sink.write(buffer, buffer.size());
} }
} catch (IOException e) { } catch (IOException e) {