From ebb43a69e7a46202462ec811af6ca51eae98d933 Mon Sep 17 00:00:00 2001 From: Vindhya Ningegowda Date: Wed, 27 Nov 2024 10:59:54 -0800 Subject: [PATCH] Add "#server" as dataplane target value for xDS enabled gRPC servers. (#11715) As mentioned in [A71 xDS Fallback]( https://github.com/grpc/proposal/blob/master/A71-xds-fallback.md#update-csds-to-aggregate-configs-from-multiple-xdsclient-instances): updated dataplane target to "#server" for xDS-enabled gRPC servers. --- xds/src/main/java/io/grpc/xds/XdsServerWrapper.java | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/xds/src/main/java/io/grpc/xds/XdsServerWrapper.java b/xds/src/main/java/io/grpc/xds/XdsServerWrapper.java index 8c03e64f18..392f4c1a31 100644 --- a/xds/src/main/java/io/grpc/xds/XdsServerWrapper.java +++ b/xds/src/main/java/io/grpc/xds/XdsServerWrapper.java @@ -172,9 +172,7 @@ final class XdsServerWrapper extends Server { private void internalStart() { try { - // TODO(dnvindhya): Add "#server" as "grpc.target" attribute value for - // xDS enabled servers. - xdsClientPool = xdsClientPoolFactory.getOrCreate("", new MetricRecorder() {}); + xdsClientPool = xdsClientPoolFactory.getOrCreate("#server", new MetricRecorder() {}); } catch (Exception e) { StatusException statusException = Status.UNAVAILABLE.withDescription( "Failed to initialize xDS").withCause(e).asException();