From efcbef58e39bd8408cadb6893125967111fc972f Mon Sep 17 00:00:00 2001 From: Eric Anderson Date: Tue, 16 Jan 2018 14:59:34 -0800 Subject: [PATCH] core: add missing separator in user-agent The separator was accidentally removed in 1bbe126b4 --- core/src/main/java/io/grpc/internal/GrpcUtil.java | 1 + core/src/test/java/io/grpc/internal/GrpcUtilTest.java | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/core/src/main/java/io/grpc/internal/GrpcUtil.java b/core/src/main/java/io/grpc/internal/GrpcUtil.java index adbbecfce7..31be149840 100644 --- a/core/src/main/java/io/grpc/internal/GrpcUtil.java +++ b/core/src/main/java/io/grpc/internal/GrpcUtil.java @@ -433,6 +433,7 @@ public final class GrpcUtil { } builder.append("grpc-java-"); builder.append(transportName); + builder.append('/'); builder.append(IMPLEMENTATION_VERSION); return builder.toString(); } diff --git a/core/src/test/java/io/grpc/internal/GrpcUtilTest.java b/core/src/test/java/io/grpc/internal/GrpcUtilTest.java index 41b1befdcc..66e052c575 100644 --- a/core/src/test/java/io/grpc/internal/GrpcUtilTest.java +++ b/core/src/test/java/io/grpc/internal/GrpcUtilTest.java @@ -117,7 +117,7 @@ public class GrpcUtilTest { @Test public void grpcUserAgent() { - assertTrue(GrpcUtil.getGrpcUserAgent("netty", null).startsWith("grpc-java-netty")); + assertTrue(GrpcUtil.getGrpcUserAgent("netty", null).startsWith("grpc-java-netty/")); assertTrue(GrpcUtil.getGrpcUserAgent("okhttp", "libfoo/1.0") .startsWith("libfoo/1.0 grpc-java-okhttp")); }