From f2e34d772bb5d9294a633b3cf06bac63d33c889b Mon Sep 17 00:00:00 2001 From: Eric Anderson Date: Sat, 29 Sep 2018 07:01:43 -0700 Subject: [PATCH] testing: Wait for TIMEOUT_MS instead of 100ms The transport test flakes at the timeout(100) about .05% of the time. There's really no reason it should have a smaller timeout compared to the other timeouts. The timeout(250) wasn't flaking at all, but it should follow the convention. --- .../java/io/grpc/internal/testing/AbstractTransportTest.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/testing/src/main/java/io/grpc/internal/testing/AbstractTransportTest.java b/testing/src/main/java/io/grpc/internal/testing/AbstractTransportTest.java index 19f5e1f689..fc516f41ba 100644 --- a/testing/src/main/java/io/grpc/internal/testing/AbstractTransportTest.java +++ b/testing/src/main/java/io/grpc/internal/testing/AbstractTransportTest.java @@ -279,7 +279,7 @@ public abstract class AbstractTransportTest { serverStreamCreation.stream.writeHeaders(new Metadata()); serverStreamCreation.stream.flush(); - verify(mockClientStreamListener2, timeout(250)).headersRead(any(Metadata.class)); + verify(mockClientStreamListener2, timeout(TIMEOUT_MS)).headersRead(any(Metadata.class)); } @Test @@ -1812,7 +1812,7 @@ public abstract class AbstractTransportTest { ManagedClientTransport clientTransport, ManagedClientTransport.Listener listener) { runIfNotNull(clientTransport.start(listener)); - verify(listener, timeout(100)).transportReady(); + verify(listener, timeout(TIMEOUT_MS)).transportReady(); } private static class MockServerListener implements ServerListener {